* [PATCH] pinctrl: stm32: fix hwspinlock resource leak in probe function
@ 2025-10-29 1:42 Haotian Zhang
2025-10-29 9:30 ` Antonio Borneo
2025-10-29 22:38 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Haotian Zhang @ 2025-10-29 1:42 UTC (permalink / raw)
To: antonio.borneo, linus.walleij
Cc: mcoquelin.stm32, alexandre.torgue, linux-gpio, linux-stm32,
linux-arm-kernel, linux-kernel, Haotian Zhang
In stm32_pctl_probe(), hwspin_lock_request_specific() is called to
request a hwspinlock, but the acquired lock is not freed on multiple
error paths after this call. This causes resource leakage when the
function fails to initialize properly.
Use devm_hwspin_lock_request_specific() instead of
hwspin_lock_request_specific() to automatically manage the hwspinlock
resource lifecycle.
Fixes: 97cfb6cd34f2 ("pinctrl: stm32: protect configuration registers with a hwspinlock")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
index 823c8fe758e2..d9a2d20a7e6b 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
@@ -1671,7 +1671,7 @@ int stm32_pctl_probe(struct platform_device *pdev)
if (hwlock_id == -EPROBE_DEFER)
return hwlock_id;
} else {
- pctl->hwlock = hwspin_lock_request_specific(hwlock_id);
+ pctl->hwlock = devm_hwspin_lock_request_specific(dev, hwlock_id);
}
spin_lock_init(&pctl->irqmux_lock);
--
2.50.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: stm32: fix hwspinlock resource leak in probe function
2025-10-29 1:42 [PATCH] pinctrl: stm32: fix hwspinlock resource leak in probe function Haotian Zhang
@ 2025-10-29 9:30 ` Antonio Borneo
2025-10-29 22:38 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Antonio Borneo @ 2025-10-29 9:30 UTC (permalink / raw)
To: Haotian Zhang, linus.walleij
Cc: mcoquelin.stm32, alexandre.torgue, linux-gpio, linux-stm32,
linux-arm-kernel, linux-kernel
On Wed, 2025-10-29 at 09:42 +0800, Haotian Zhang wrote:
> In stm32_pctl_probe(), hwspin_lock_request_specific() is called to
> request a hwspinlock, but the acquired lock is not freed on multiple
> error paths after this call. This causes resource leakage when the
> function fails to initialize properly.
>
> Use devm_hwspin_lock_request_specific() instead of
> hwspin_lock_request_specific() to automatically manage the hwspinlock
> resource lifecycle.
>
> Fixes: 97cfb6cd34f2 ("pinctrl: stm32: protect configuration registers with a hwspinlock")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
> ---
> drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
> index 823c8fe758e2..d9a2d20a7e6b 100644
> --- a/drivers/pinctrl/stm32/pinctrl-stm32.c
> +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
> @@ -1671,7 +1671,7 @@ int stm32_pctl_probe(struct platform_device *pdev)
> if (hwlock_id == -EPROBE_DEFER)
> return hwlock_id;
> } else {
> - pctl->hwlock = hwspin_lock_request_specific(hwlock_id);
> + pctl->hwlock = devm_hwspin_lock_request_specific(dev, hwlock_id);
> }
>
> spin_lock_init(&pctl->irqmux_lock);
Reviewed-by: Antonio Borneo <antonio.borneo@foss.st.com>
Thanks!
Antonio
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: stm32: fix hwspinlock resource leak in probe function
2025-10-29 1:42 [PATCH] pinctrl: stm32: fix hwspinlock resource leak in probe function Haotian Zhang
2025-10-29 9:30 ` Antonio Borneo
@ 2025-10-29 22:38 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2025-10-29 22:38 UTC (permalink / raw)
To: Haotian Zhang
Cc: antonio.borneo, mcoquelin.stm32, alexandre.torgue, linux-gpio,
linux-stm32, linux-arm-kernel, linux-kernel
On Wed, Oct 29, 2025 at 2:43 AM Haotian Zhang <vulab@iscas.ac.cn> wrote:
> In stm32_pctl_probe(), hwspin_lock_request_specific() is called to
> request a hwspinlock, but the acquired lock is not freed on multiple
> error paths after this call. This causes resource leakage when the
> function fails to initialize properly.
>
> Use devm_hwspin_lock_request_specific() instead of
> hwspin_lock_request_specific() to automatically manage the hwspinlock
> resource lifecycle.
>
> Fixes: 97cfb6cd34f2 ("pinctrl: stm32: protect configuration registers with a hwspinlock")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-29 22:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-29 1:42 [PATCH] pinctrl: stm32: fix hwspinlock resource leak in probe function Haotian Zhang
2025-10-29 9:30 ` Antonio Borneo
2025-10-29 22:38 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).