linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	 Bartosz Golaszewski <brgl@bgdev.pl>,
	 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	 Daniel Scally <djrscally@gmail.com>,
	 Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	 Sakari Ailus <sakari.ailus@linux.intel.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 "Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	 Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-acpi@vger.kernel.org,
	 Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH v4 04/10] gpio: swnode: don't use the swnode's name as the key for GPIO lookup
Date: Mon, 03 Nov 2025 10:35:24 +0100	[thread overview]
Message-ID: <20251103-reset-gpios-swnodes-v4-4-6461800b6775@linaro.org> (raw)
In-Reply-To: <20251103-reset-gpios-swnodes-v4-0-6461800b6775@linaro.org>

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Looking up a GPIO controller by label that is the name of the software
node is wonky at best - the GPIO controller driver is free to set
a different label than the name of its firmware node. We're already being
passed a firmware node handle attached to the GPIO device to
swnode_get_gpio_device() so use it instead for a more precise lookup.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpiolib-swnode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib-swnode.c b/drivers/gpio/gpiolib-swnode.c
index f21dbc28cf2c8c2d06d034b7c89d302cc52bb9b5..e3806db1c0e077d76fcc71a50ca40bbf6872ca40 100644
--- a/drivers/gpio/gpiolib-swnode.c
+++ b/drivers/gpio/gpiolib-swnode.c
@@ -41,7 +41,7 @@ static struct gpio_device *swnode_get_gpio_device(struct fwnode_handle *fwnode)
 	    !strcmp(gdev_node->name, GPIOLIB_SWNODE_UNDEFINED_NAME))
 		return ERR_PTR(-ENOENT);
 
-	gdev = gpio_device_find_by_label(gdev_node->name);
+	gdev = gpio_device_find_by_fwnode(fwnode);
 	return gdev ?: ERR_PTR(-EPROBE_DEFER);
 }
 

-- 
2.51.0


  parent reply	other threads:[~2025-11-03  9:35 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-03  9:35 [PATCH v4 00/10] reset: rework reset-gpios handling Bartosz Golaszewski
2025-11-03  9:35 ` [PATCH v4 01/10] software node: read the reference args via the fwnode API Bartosz Golaszewski
2025-11-03 10:53   ` Sakari Ailus
2025-11-03  9:35 ` [PATCH v4 02/10] software node: increase the reference of the swnode by its fwnode Bartosz Golaszewski
2025-11-03 10:53   ` Sakari Ailus
2025-11-03  9:35 ` [PATCH v4 03/10] software node: allow referencing firmware nodes Bartosz Golaszewski
2025-11-03  9:49   ` Andy Shevchenko
2025-11-03 10:36     ` Bartosz Golaszewski
2025-11-03 10:52       ` Sakari Ailus
2025-11-03 10:56         ` Bartosz Golaszewski
2025-11-03 13:46       ` Andy Shevchenko
2025-11-03  9:35 ` Bartosz Golaszewski [this message]
2025-11-03  9:51   ` [PATCH v4 04/10] gpio: swnode: don't use the swnode's name as the key for GPIO lookup Andy Shevchenko
2025-11-03 10:53     ` Bartosz Golaszewski
2025-11-18 16:33   ` Charles Keepax
2025-11-18 18:01     ` Bartosz Golaszewski
2025-11-18 18:15       ` Charles Keepax
2025-11-18 18:23         ` Andy Shevchenko
2025-11-19  8:35         ` Bartosz Golaszewski
2025-11-19  8:41           ` Bartosz Golaszewski
2025-11-19  9:13             ` Bartosz Golaszewski
2025-11-03  9:35 ` [PATCH v4 05/10] gpio: swnode: allow referencing GPIO chips by firmware nodes Bartosz Golaszewski
2025-11-03  9:54   ` Andy Shevchenko
2025-11-03  9:35 ` [PATCH v4 06/10] gpio: swnode: update the property definitions Bartosz Golaszewski
2025-11-03  9:57   ` Andy Shevchenko
2025-11-03  9:35 ` [PATCH v4 07/10] reset: order includes alphabetically in reset/core.c Bartosz Golaszewski
2025-11-03  9:35 ` [PATCH v4 08/10] reset: make the provider of reset-gpios the parent of the reset device Bartosz Golaszewski
2025-11-03  9:35 ` [PATCH v4 09/10] reset: gpio: convert the driver to using the auxiliary bus Bartosz Golaszewski
2025-11-03  9:35 ` [PATCH v4 10/10] reset: gpio: use software nodes to setup the GPIO lookup Bartosz Golaszewski
2025-11-03 14:14 ` (subset) [PATCH v4 00/10] reset: rework reset-gpios handling Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251103-reset-gpios-swnodes-v4-4-6461800b6775@linaro.org \
    --to=brgl@bgdev.pl \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=dakr@kernel.org \
    --cc=djrscally@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=krzk@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).