From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH v1 1/3] pinctrl: intel: Refactor intel_gpio_add_pin_ranges() to make it shorter
Date: Mon, 17 Nov 2025 08:56:59 +0100 [thread overview]
Message-ID: <20251117075826.3332299-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20251117075826.3332299-1-andriy.shevchenko@linux.intel.com>
Refactor intel_gpio_add_pin_ranges() to make it shorter in binary
and source formats.
Function old new delta
intel_gpio_add_pin_ranges 219 215 -4
Total: Before=15522, After=15518, chg -0.03%
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-intel.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 8e067aaf3399..a8b80a24e81f 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -1348,16 +1348,15 @@ static int intel_gpio_irq_init_hw(struct gpio_chip *gc)
static int intel_gpio_add_pin_ranges(struct gpio_chip *gc)
{
struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
+ struct device *dev = pctrl->dev;
const struct intel_community *community;
const struct intel_padgroup *grp;
int ret;
for_each_intel_gpio_group(pctrl, community, grp) {
- ret = gpiochip_add_pin_range(&pctrl->chip, dev_name(pctrl->dev),
- grp->gpio_base, grp->base,
- grp->size);
+ ret = gpiochip_add_pin_range(gc, dev_name(dev), grp->gpio_base, grp->base, grp->size);
if (ret)
- return dev_err_probe(pctrl->dev, ret, "failed to add GPIO pin range\n");
+ return dev_err_probe(dev, ret, "failed to add GPIO pin range\n");
}
return 0;
--
2.50.1
next prev parent reply other threads:[~2025-11-17 7:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 7:56 [PATCH v1 0/3] pinctrl: intel: Export intel_gpio_add_pin_ranges() and use it Andy Shevchenko
2025-11-17 7:56 ` Andy Shevchenko [this message]
2025-11-17 11:27 ` [PATCH v1 1/3] pinctrl: intel: Refactor intel_gpio_add_pin_ranges() to make it shorter Mika Westerberg
2025-11-17 16:06 ` Andy Shevchenko
2025-11-18 5:27 ` Mika Westerberg
2025-11-18 10:02 ` Andy Shevchenko
2025-11-17 7:57 ` [PATCH v1 2/3] pinctrl: intel: Export intel_gpio_add_pin_ranges() Andy Shevchenko
2025-11-18 11:47 ` Mika Westerberg
2025-11-18 12:04 ` Andy Shevchenko
2025-11-17 7:57 ` [PATCH v1 3/3] pinctrl: cherryview: Convert to use intel_gpio_add_pin_ranges() Andy Shevchenko
2025-11-18 11:47 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117075826.3332299-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).