From: Jisheng Zhang <jszhang@kernel.org>
To: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Hoan Tran <hoan@os.amperecomputing.com>,
Andy Shevchenko <andy@kernel.org>,
Daniel Palmer <daniel@thingy.jp>,
Romain Perier <romain.perier@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Srinivas Neeli <srinivas.neeli@amd.com>,
Michal Simek <michal.simek@amd.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: [PATCH v2 10/15] gpio: pch: Use modern PM macros
Date: Tue, 18 Nov 2025 08:32:24 +0800 [thread overview]
Message-ID: <20251118003229.26636-11-jszhang@kernel.org> (raw)
In-Reply-To: <20251118003229.26636-1-jszhang@kernel.org>
Use the modern PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use __maybe_unused
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Acked-by: Andy Shevchenko <andy@kernel.org>
---
drivers/gpio/gpio-pch.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index 9925687e05fb..4ffa0955a9e3 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -171,7 +171,7 @@ static int pch_gpio_direction_input(struct gpio_chip *gpio, unsigned int nr)
/*
* Save register configuration and disable interrupts.
*/
-static void __maybe_unused pch_gpio_save_reg_conf(struct pch_gpio *chip)
+static void pch_gpio_save_reg_conf(struct pch_gpio *chip)
{
chip->pch_gpio_reg.ien_reg = ioread32(&chip->reg->ien);
chip->pch_gpio_reg.imask_reg = ioread32(&chip->reg->imask);
@@ -187,7 +187,7 @@ static void __maybe_unused pch_gpio_save_reg_conf(struct pch_gpio *chip)
/*
* This function restores the register configuration of the GPIO device.
*/
-static void __maybe_unused pch_gpio_restore_reg_conf(struct pch_gpio *chip)
+static void pch_gpio_restore_reg_conf(struct pch_gpio *chip)
{
iowrite32(chip->pch_gpio_reg.ien_reg, &chip->reg->ien);
iowrite32(chip->pch_gpio_reg.imask_reg, &chip->reg->imask);
@@ -402,7 +402,7 @@ static int pch_gpio_probe(struct pci_dev *pdev,
return pch_gpio_alloc_generic_chip(chip, irq_base, gpio_pins[chip->ioh]);
}
-static int __maybe_unused pch_gpio_suspend(struct device *dev)
+static int pch_gpio_suspend(struct device *dev)
{
struct pch_gpio *chip = dev_get_drvdata(dev);
unsigned long flags;
@@ -414,7 +414,7 @@ static int __maybe_unused pch_gpio_suspend(struct device *dev)
return 0;
}
-static int __maybe_unused pch_gpio_resume(struct device *dev)
+static int pch_gpio_resume(struct device *dev)
{
struct pch_gpio *chip = dev_get_drvdata(dev);
unsigned long flags;
@@ -428,7 +428,7 @@ static int __maybe_unused pch_gpio_resume(struct device *dev)
return 0;
}
-static SIMPLE_DEV_PM_OPS(pch_gpio_pm_ops, pch_gpio_suspend, pch_gpio_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(pch_gpio_pm_ops, pch_gpio_suspend, pch_gpio_resume);
static const struct pci_device_id pch_gpio_pcidev_id[] = {
{ PCI_DEVICE_DATA(INTEL, EG20T_PCH, INTEL_EG20T_PCH) },
@@ -444,7 +444,7 @@ static struct pci_driver pch_gpio_driver = {
.id_table = pch_gpio_pcidev_id,
.probe = pch_gpio_probe,
.driver = {
- .pm = &pch_gpio_pm_ops,
+ .pm = pm_sleep_ptr(&pch_gpio_pm_ops),
},
};
--
2.51.0
next prev parent reply other threads:[~2025-11-18 0:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 0:32 [PATCH v2 00/15] gpio: Use modern PM macros Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 01/15] gpio: dwapb: " Jisheng Zhang
2025-11-18 10:15 ` Andy Shevchenko
2025-11-19 12:42 ` Jisheng Zhang
2025-11-19 12:59 ` Jisheng Zhang
2025-11-19 14:05 ` Andy Shevchenko
2025-11-18 0:32 ` [PATCH v2 02/15] gpio: brcmstb: " Jisheng Zhang
2025-11-18 18:35 ` Florian Fainelli
2025-11-18 0:32 ` [PATCH v2 03/15] gpio: htc-egpio: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 04/15] gpio: pl061: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 05/15] gpio: pxa: " Jisheng Zhang
2025-11-18 12:06 ` Andy Shevchenko
2025-11-18 22:03 ` Robert Jarzmik
2025-11-19 7:56 ` Andy Shevchenko
2025-11-19 12:47 ` Jisheng Zhang
2025-11-19 13:58 ` Andy Shevchenko
2025-11-19 12:22 ` Jisheng Zhang
2025-11-20 20:48 ` Robert Jarzmik
2025-11-21 9:20 ` Andy Shevchenko
2025-11-18 0:32 ` [PATCH v2 06/15] gpio: ml-ioh: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 07/15] gpio: mlxbf2: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 08/15] gpio: msc313: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 09/15] gpio: omap: " Jisheng Zhang
2025-11-18 0:32 ` Jisheng Zhang [this message]
2025-11-18 0:32 ` [PATCH v2 11/15] gpio: tqmx86: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 12/15] gpio: uniphier: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 13/15] gpio: xgene: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 14/15] gpio: xilinx: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 15/15] gpio: zynq: " Jisheng Zhang
2025-11-19 13:40 ` [PATCH v2 00/15] gpio: " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118003229.26636-11-jszhang@kernel.org \
--to=jszhang@kernel.org \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=daniel@thingy.jp \
--cc=florian.fainelli@broadcom.com \
--cc=grygorii.strashko@ti.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hoan@os.amperecomputing.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=michal.simek@amd.com \
--cc=opendmb@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=romain.perier@gmail.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).