From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DEDE944F; Tue, 18 Nov 2025 00:50:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763427046; cv=none; b=mojbFX5OtR9rUVWS+LkhRbpVKL71dnoTn/st/ZUc22CCn1Pk3Q/SXJhE761Ekj08HJLn4+taRfE4bwpbiPpy2mIe2MvOfkUjVGDyRb8Y2uBbs8UMYre7G44iaARlIiuQUlCwttl/YRlcgYFH+K3jo46kRfB+NrvGPbYmsSq+twI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763427046; c=relaxed/simple; bh=iS5RSX5kssNbD8Tb7keOKotIOZ6qJnsVQ/Lih7t17O0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZAWbIoK/TmJaGR3qEphZE0myV7vzJ4026VK/D1ERfc0rV+CKO+kxNhpPjW950/4SB+EqyxTiJWZo9QnXrDc/RInflhRdkDtnm1eZOX0gHdVrqS7/tXPOQAKbHSlD7sLO/Xsv5LXptWMr0BgaI9yLiBLdauhSNyaC7uhlSoxMdrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IecAEEMt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IecAEEMt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EBF9C2BC86; Tue, 18 Nov 2025 00:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763427046; bh=iS5RSX5kssNbD8Tb7keOKotIOZ6qJnsVQ/Lih7t17O0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IecAEEMtC3ill6QNjdg4SprpRMemF0/93QHWEzqZyS5B4IWd77btuPZmqauhcnrz9 PREFJjSzjBq/f5O7RTsnB1FC9zLUleTbgHetJMgT0E79iijQ+5hZl70gOfiW/1YNnm qAgxkFlbCRRLOrdqhz94BC3VqsLrdfxkWHJTEctnSdVizDFpnoqI6IS4NSiYHv+z5G BBsCHecYSHsvSE4Vq+t1436HHUdQHqouHYyEbijQL67PHx5HYg8FuNIGq7rPSOkZyx TJF1ybi89eEvUCfS9wD2VVkWLAgUYMUoCilzoi6yNMDIDtvwMopQzLn0pAysEjO6oZ e9/tXi0ZhSyLw== From: Jisheng Zhang To: Doug Berger , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Linus Walleij , Bartosz Golaszewski , Hoan Tran , Andy Shevchenko , Daniel Palmer , Romain Perier , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Robert Jarzmik , Kunihiko Hayashi , Masami Hiramatsu , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: [PATCH v2 04/15] gpio: pl061: Use modern PM macros Date: Tue, 18 Nov 2025 08:32:18 +0800 Message-ID: <20251118003229.26636-5-jszhang@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251118003229.26636-1-jszhang@kernel.org> References: <20251118003229.26636-1-jszhang@kernel.org> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use the modern PM macros for the suspend and resume functions to be automatically dropped by the compiler when CONFIG_PM or CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards. This has the advantage of always compiling these functions in, independently of any Kconfig option. Thanks to that, bugs and other regressions are subsequently easier to catch. The pl061_context_save_regs structure is always embedded into struct pl061 to simplify code, so this brings a tiny 8 bytes memory overhead for !CONFIG_PM_SLEP. Signed-off-by: Jisheng Zhang Reviewed-by: Linus Walleij --- drivers/gpio/gpio-pl061.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c index 02e4ffcf5a6f..919cf86fd590 100644 --- a/drivers/gpio/gpio-pl061.c +++ b/drivers/gpio/gpio-pl061.c @@ -37,7 +37,6 @@ #define PL061_GPIO_NR 8 -#ifdef CONFIG_PM struct pl061_context_save_regs { u8 gpio_data; u8 gpio_dir; @@ -46,7 +45,6 @@ struct pl061_context_save_regs { u8 gpio_iev; u8 gpio_ie; }; -#endif struct pl061 { raw_spinlock_t lock; @@ -55,9 +53,7 @@ struct pl061 { struct gpio_chip gc; int parent_irq; -#ifdef CONFIG_PM struct pl061_context_save_regs csave_regs; -#endif }; static int pl061_get_direction(struct gpio_chip *gc, unsigned offset) @@ -367,7 +363,6 @@ static int pl061_probe(struct amba_device *adev, const struct amba_id *id) return 0; } -#ifdef CONFIG_PM static int pl061_suspend(struct device *dev) { struct pl061 *pl061 = dev_get_drvdata(dev); @@ -411,13 +406,7 @@ static int pl061_resume(struct device *dev) return 0; } -static const struct dev_pm_ops pl061_dev_pm_ops = { - .suspend = pl061_suspend, - .resume = pl061_resume, - .freeze = pl061_suspend, - .restore = pl061_resume, -}; -#endif +static DEFINE_SIMPLE_DEV_PM_OPS(pl061_dev_pm_ops, pl061_suspend, pl061_resume); static const struct amba_id pl061_ids[] = { { @@ -431,9 +420,7 @@ MODULE_DEVICE_TABLE(amba, pl061_ids); static struct amba_driver pl061_gpio_driver = { .drv = { .name = "pl061_gpio", -#ifdef CONFIG_PM - .pm = &pl061_dev_pm_ops, -#endif + .pm = pm_sleep_ptr(&pl061_dev_pm_ops), }, .id_table = pl061_ids, .probe = pl061_probe, -- 2.51.0