From: Jisheng Zhang <jszhang@kernel.org>
To: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Hoan Tran <hoan@os.amperecomputing.com>,
Andy Shevchenko <andy@kernel.org>,
Daniel Palmer <daniel@thingy.jp>,
Romain Perier <romain.perier@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Srinivas Neeli <srinivas.neeli@amd.com>,
Michal Simek <michal.simek@amd.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: [PATCH v2 05/15] gpio: pxa: Use modern PM macros
Date: Tue, 18 Nov 2025 08:32:19 +0800 [thread overview]
Message-ID: <20251118003229.26636-6-jszhang@kernel.org> (raw)
In-Reply-To: <20251118003229.26636-1-jszhang@kernel.org>
Use the modern PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/gpio/gpio-pxa.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index fa22f3faa163..288c72f9c015 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -66,13 +66,10 @@ struct pxa_gpio_bank {
unsigned long irq_mask;
unsigned long irq_edge_rise;
unsigned long irq_edge_fall;
-
-#ifdef CONFIG_PM
unsigned long saved_gplr;
unsigned long saved_gpdr;
unsigned long saved_grer;
unsigned long saved_gfer;
-#endif
};
struct pxa_gpio_chip {
@@ -746,7 +743,6 @@ static int __init pxa_gpio_dt_init(void)
}
device_initcall(pxa_gpio_dt_init);
-#ifdef CONFIG_PM
static int pxa_gpio_suspend(void)
{
struct pxa_gpio_chip *pchip = pxa_gpio_chip;
@@ -787,14 +783,10 @@ static void pxa_gpio_resume(void)
writel_relaxed(c->saved_gpdr, c->regbase + GPDR_OFFSET);
}
}
-#else
-#define pxa_gpio_suspend NULL
-#define pxa_gpio_resume NULL
-#endif
static struct syscore_ops pxa_gpio_syscore_ops = {
- .suspend = pxa_gpio_suspend,
- .resume = pxa_gpio_resume,
+ .suspend = pm_ptr(pxa_gpio_suspend),
+ .resume = pm_ptr(pxa_gpio_resume),
};
static int __init pxa_gpio_sysinit(void)
--
2.51.0
next prev parent reply other threads:[~2025-11-18 0:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 0:32 [PATCH v2 00/15] gpio: Use modern PM macros Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 01/15] gpio: dwapb: " Jisheng Zhang
2025-11-18 10:15 ` Andy Shevchenko
2025-11-19 12:42 ` Jisheng Zhang
2025-11-19 12:59 ` Jisheng Zhang
2025-11-19 14:05 ` Andy Shevchenko
2025-11-18 0:32 ` [PATCH v2 02/15] gpio: brcmstb: " Jisheng Zhang
2025-11-18 18:35 ` Florian Fainelli
2025-11-18 0:32 ` [PATCH v2 03/15] gpio: htc-egpio: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 04/15] gpio: pl061: " Jisheng Zhang
2025-11-18 0:32 ` Jisheng Zhang [this message]
2025-11-18 12:06 ` [PATCH v2 05/15] gpio: pxa: " Andy Shevchenko
2025-11-18 22:03 ` Robert Jarzmik
2025-11-19 7:56 ` Andy Shevchenko
2025-11-19 12:47 ` Jisheng Zhang
2025-11-19 13:58 ` Andy Shevchenko
2025-11-19 12:22 ` Jisheng Zhang
2025-11-20 20:48 ` Robert Jarzmik
2025-11-21 9:20 ` Andy Shevchenko
2025-11-18 0:32 ` [PATCH v2 06/15] gpio: ml-ioh: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 07/15] gpio: mlxbf2: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 08/15] gpio: msc313: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 09/15] gpio: omap: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 10/15] gpio: pch: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 11/15] gpio: tqmx86: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 12/15] gpio: uniphier: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 13/15] gpio: xgene: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 14/15] gpio: xilinx: " Jisheng Zhang
2025-11-18 0:32 ` [PATCH v2 15/15] gpio: zynq: " Jisheng Zhang
2025-11-19 13:40 ` [PATCH v2 00/15] gpio: " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118003229.26636-6-jszhang@kernel.org \
--to=jszhang@kernel.org \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=daniel@thingy.jp \
--cc=florian.fainelli@broadcom.com \
--cc=grygorii.strashko@ti.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hoan@os.amperecomputing.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=michal.simek@amd.com \
--cc=opendmb@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=romain.perier@gmail.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).