linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@kernel.org>
To: Doug Berger <opendmb@gmail.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Hoan Tran <hoan@os.amperecomputing.com>,
	Andy Shevchenko <andy@kernel.org>,
	Daniel Palmer <daniel@thingy.jp>,
	Romain Perier <romain.perier@gmail.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Kevin Hilman <khilman@kernel.org>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
	Srinivas Neeli <srinivas.neeli@amd.com>,
	Michal Simek <michal.simek@amd.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: [PATCH v5 12/14] gpio: xgene: Use modern PM macros
Date: Mon, 24 Nov 2025 08:21:03 +0800	[thread overview]
Message-ID: <20251124002105.25429-13-jszhang@kernel.org> (raw)
In-Reply-To: <20251124002105.25429-1-jszhang@kernel.org>

Use the modern PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use __maybe_unused

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
 drivers/gpio/gpio-xgene.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c
index 4f627de3f56c..809668449dbe 100644
--- a/drivers/gpio/gpio-xgene.c
+++ b/drivers/gpio/gpio-xgene.c
@@ -130,7 +130,7 @@ static int xgene_gpio_dir_out(struct gpio_chip *gc,
 	return 0;
 }
 
-static __maybe_unused int xgene_gpio_suspend(struct device *dev)
+static int xgene_gpio_suspend(struct device *dev)
 {
 	struct xgene_gpio *gpio = dev_get_drvdata(dev);
 	unsigned long bank_offset;
@@ -143,7 +143,7 @@ static __maybe_unused int xgene_gpio_suspend(struct device *dev)
 	return 0;
 }
 
-static __maybe_unused int xgene_gpio_resume(struct device *dev)
+static int xgene_gpio_resume(struct device *dev)
 {
 	struct xgene_gpio *gpio = dev_get_drvdata(dev);
 	unsigned long bank_offset;
@@ -156,7 +156,7 @@ static __maybe_unused int xgene_gpio_resume(struct device *dev)
 	return 0;
 }
 
-static SIMPLE_DEV_PM_OPS(xgene_gpio_pm, xgene_gpio_suspend, xgene_gpio_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(xgene_gpio_pm, xgene_gpio_suspend, xgene_gpio_resume);
 
 static int xgene_gpio_probe(struct platform_device *pdev)
 {
@@ -204,7 +204,7 @@ static struct platform_driver xgene_gpio_driver = {
 		.name = "xgene-gpio",
 		.of_match_table = xgene_gpio_of_match,
 		.acpi_match_table = ACPI_PTR(xgene_gpio_acpi_match),
-		.pm     = &xgene_gpio_pm,
+		.pm     = pm_sleep_ptr(&xgene_gpio_pm),
 	},
 	.probe = xgene_gpio_probe,
 };
-- 
2.51.0


  parent reply	other threads:[~2025-11-24  0:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24  0:20 [PATCH v5 00/14] gpio: Use modern PM macros Jisheng Zhang
2025-11-24  0:20 ` [PATCH v5 01/14] gpio: dwapb: " Jisheng Zhang
2025-11-24  0:20 ` [PATCH v5 02/14] gpio: brcmstb: " Jisheng Zhang
2025-11-24  7:51   ` Andy Shevchenko
2025-11-24 12:40   ` Jonas Gorski
2025-11-24 13:52     ` Andy Shevchenko
2025-11-24 14:20       ` Jonas Gorski
2025-11-24 14:49         ` Andy Shevchenko
2025-11-24 15:05           ` Jonas Gorski
2025-11-24 15:17             ` Andy Shevchenko
2025-11-24  0:20 ` [PATCH v5 03/14] gpio: htc-egpio: " Jisheng Zhang
2025-11-24  0:20 ` [PATCH v5 04/14] gpio: pl061: " Jisheng Zhang
2025-11-24  0:20 ` [PATCH v5 05/14] gpio: ml-ioh: " Jisheng Zhang
2025-11-24  0:20 ` [PATCH v5 06/14] gpio: mlxbf2: " Jisheng Zhang
2025-11-24  0:20 ` [PATCH v5 07/14] gpio: msc313: " Jisheng Zhang
2025-12-03  8:10   ` Daniel Palmer
2025-11-24  0:20 ` [PATCH v5 08/14] gpio: omap: " Jisheng Zhang
2025-11-24  0:21 ` [PATCH v5 09/14] gpio: pch: " Jisheng Zhang
2025-11-24  0:21 ` [PATCH v5 10/14] gpio: tqmx86: " Jisheng Zhang
2025-11-24  0:21 ` [PATCH v5 11/14] gpio: uniphier: " Jisheng Zhang
2025-11-24  0:21 ` Jisheng Zhang [this message]
2025-11-24  0:21 ` [PATCH v5 13/14] gpio: xilinx: " Jisheng Zhang
2025-11-24  0:21 ` [PATCH v5 14/14] gpio: zynq: " Jisheng Zhang
2025-11-25 13:11 ` [PATCH v5 00/14] gpio: " Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251124002105.25429-13-jszhang@kernel.org \
    --to=jszhang@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=brgl@bgdev.pl \
    --cc=daniel@thingy.jp \
    --cc=florian.fainelli@broadcom.com \
    --cc=grygorii.strashko@ti.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=hoan@os.amperecomputing.com \
    --cc=khilman@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=michal.simek@amd.com \
    --cc=opendmb@gmail.com \
    --cc=robert.jarzmik@free.fr \
    --cc=romain.perier@gmail.com \
    --cc=shubhrajyoti.datta@amd.com \
    --cc=srinivas.neeli@amd.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).