* [PATCH] [v2] gpio: tb10x: fix OF_GPIO dependency
@ 2025-12-05 9:54 Arnd Bergmann
2025-12-06 10:47 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-12-05 9:54 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Arnd Bergmann, Akhilesh Patil, linux-gpio, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Selecting OF_GPIO is generally not allowed, it always gets enabled
when both GPIOLIB and OF are turned on.
The tb10x driver now warns about this after it was enabled for
compile-testing:
WARNING: unmet direct dependencies detected for OF_GPIO
Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
Selected by [y]:
- GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])
OF_GPIO is not required for compile-testing and is already enabled
when the driver is usable, so just drop the 'select' line.
Fixes: 682fbb18e14c ("gpio: tb10x: allow building the module with COMPILE_TEST=y")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpio/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 02099ef48f22..e9dc19ce3545 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -737,7 +737,6 @@ config GPIO_TB10X
depends on ARC_PLAT_TB10X || COMPILE_TEST
select GPIO_GENERIC
select GENERIC_IRQ_CHIP
- select OF_GPIO
config GPIO_TEGRA
tristate "NVIDIA Tegra GPIO support"
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [v2] gpio: tb10x: fix OF_GPIO dependency
2025-12-05 9:54 [PATCH] [v2] gpio: tb10x: fix OF_GPIO dependency Arnd Bergmann
@ 2025-12-06 10:47 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2025-12-06 10:47 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Arnd Bergmann
Cc: Bartosz Golaszewski, Arnd Bergmann, Akhilesh Patil, linux-gpio,
linux-kernel
On Fri, 05 Dec 2025 10:54:09 +0100, Arnd Bergmann wrote:
> Selecting OF_GPIO is generally not allowed, it always gets enabled
> when both GPIOLIB and OF are turned on.
>
> The tb10x driver now warns about this after it was enabled for
> compile-testing:
>
> WARNING: unmet direct dependencies detected for OF_GPIO
> Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
> Selected by [y]:
> - GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])
>
> [...]
Applied, thanks!
[1/1] gpio: tb10x: fix OF_GPIO dependency
https://git.kernel.org/brgl/linux/c/a0cf7d69016e1917c2ac284840254b5f1dd75e23
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-06 10:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-05 9:54 [PATCH] [v2] gpio: tb10x: fix OF_GPIO dependency Arnd Bergmann
2025-12-06 10:47 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).