linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Linus Walleij <linusw@kernel.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH] pinctrl: fix compile test defaults
Date: Wed, 10 Dec 2025 14:22:02 +0000	[thread overview]
Message-ID: <20251210-judiciary-borough-1c28d14b9a3f@spud> (raw)
In-Reply-To: <20251210034148.34447-1-johan@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]

On Wed, Dec 10, 2025 at 12:41:48PM +0900, Johan Hovold wrote:
> Enabling compile testing should not enable every individual driver (we
> have "allyesconfig" for that) but two new drivers got this wrong.
> 
> Fixes: 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
> Fixes: 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
> Cc: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/pinctrl/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index bc7f37afc48b..ce5685215b92 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -491,7 +491,7 @@ config PINCTRL_PIC64GX
>  	depends on ARCH_MICROCHIP || COMPILE_TEST
>  	depends on OF
>  	select GENERIC_PINCONF
> -	default y
> +	default ARCH_MICROCHIP

Nah, not a fan of this kind of thing, please just make it default n if
this compile test behaviour bothers you.

>  	help
>  	  This selects the pinctrl driver for gpio2 on pic64gx.
>  
> @@ -511,7 +511,7 @@ config PINCTRL_POLARFIRE_SOC
>  	depends on ARCH_MICROCHIP || COMPILE_TEST
>  	depends on OF
>  	select GENERIC_PINCONF
> -	default y
> +	default ARCH_MICROCHIP
>  	help
>  	  This selects the pinctrl driver for Microchip Polarfire SoC.
>  
> -- 
> 2.52.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-12-10 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10  3:41 [PATCH] pinctrl: fix compile test defaults Johan Hovold
2025-12-10 14:22 ` Conor Dooley [this message]
2025-12-12  2:11   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251210-judiciary-borough-1c28d14b9a3f@spud \
    --to=conor@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=johan@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).