* [PATCH] pinctrl: fix compile test defaults
@ 2025-12-10 3:41 Johan Hovold
2025-12-10 14:22 ` Conor Dooley
0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2025-12-10 3:41 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, linux-kernel, Johan Hovold, Conor Dooley
Enabling compile testing should not enable every individual driver (we
have "allyesconfig" for that) but two new drivers got this wrong.
Fixes: 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
Fixes: 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
Cc: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/pinctrl/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index bc7f37afc48b..ce5685215b92 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -491,7 +491,7 @@ config PINCTRL_PIC64GX
depends on ARCH_MICROCHIP || COMPILE_TEST
depends on OF
select GENERIC_PINCONF
- default y
+ default ARCH_MICROCHIP
help
This selects the pinctrl driver for gpio2 on pic64gx.
@@ -511,7 +511,7 @@ config PINCTRL_POLARFIRE_SOC
depends on ARCH_MICROCHIP || COMPILE_TEST
depends on OF
select GENERIC_PINCONF
- default y
+ default ARCH_MICROCHIP
help
This selects the pinctrl driver for Microchip Polarfire SoC.
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: fix compile test defaults
2025-12-10 3:41 [PATCH] pinctrl: fix compile test defaults Johan Hovold
@ 2025-12-10 14:22 ` Conor Dooley
2025-12-12 2:11 ` Johan Hovold
0 siblings, 1 reply; 3+ messages in thread
From: Conor Dooley @ 2025-12-10 14:22 UTC (permalink / raw)
To: Johan Hovold; +Cc: Linus Walleij, linux-gpio, linux-kernel, Conor Dooley
[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]
On Wed, Dec 10, 2025 at 12:41:48PM +0900, Johan Hovold wrote:
> Enabling compile testing should not enable every individual driver (we
> have "allyesconfig" for that) but two new drivers got this wrong.
>
> Fixes: 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
> Fixes: 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
> Cc: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/pinctrl/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index bc7f37afc48b..ce5685215b92 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -491,7 +491,7 @@ config PINCTRL_PIC64GX
> depends on ARCH_MICROCHIP || COMPILE_TEST
> depends on OF
> select GENERIC_PINCONF
> - default y
> + default ARCH_MICROCHIP
Nah, not a fan of this kind of thing, please just make it default n if
this compile test behaviour bothers you.
> help
> This selects the pinctrl driver for gpio2 on pic64gx.
>
> @@ -511,7 +511,7 @@ config PINCTRL_POLARFIRE_SOC
> depends on ARCH_MICROCHIP || COMPILE_TEST
> depends on OF
> select GENERIC_PINCONF
> - default y
> + default ARCH_MICROCHIP
> help
> This selects the pinctrl driver for Microchip Polarfire SoC.
>
> --
> 2.52.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: fix compile test defaults
2025-12-10 14:22 ` Conor Dooley
@ 2025-12-12 2:11 ` Johan Hovold
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2025-12-12 2:11 UTC (permalink / raw)
To: Conor Dooley; +Cc: Linus Walleij, linux-gpio, linux-kernel, Conor Dooley
[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]
On Wed, Dec 10, 2025 at 02:22:02PM +0000, Conor Dooley wrote:
> On Wed, Dec 10, 2025 at 12:41:48PM +0900, Johan Hovold wrote:
> > Enabling compile testing should not enable every individual driver (we
> > have "allyesconfig" for that) but two new drivers got this wrong.
> >
> > Fixes: 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
> > Fixes: 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
> > Cc: Conor Dooley <conor.dooley@microchip.com>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> > drivers/pinctrl/Kconfig | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> > index bc7f37afc48b..ce5685215b92 100644
> > --- a/drivers/pinctrl/Kconfig
> > +++ b/drivers/pinctrl/Kconfig
> > @@ -491,7 +491,7 @@ config PINCTRL_PIC64GX
> > depends on ARCH_MICROCHIP || COMPILE_TEST
> > depends on OF
> > select GENERIC_PINCONF
> > - default y
> > + default ARCH_MICROCHIP
>
> Nah, not a fan of this kind of thing, please just make it default n if
> this compile test behaviour bothers you.
Sure, I guess that's better here as these drivers are not needed in
every Microchip build either.
Johan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-12 2:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-10 3:41 [PATCH] pinctrl: fix compile test defaults Johan Hovold
2025-12-10 14:22 ` Conor Dooley
2025-12-12 2:11 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).