* [PATCH] gpio: max77759: drop use of irqd_get_trigger_type
@ 2025-12-17 11:45 André Draszik
0 siblings, 0 replies; only message in thread
From: André Draszik @ 2025-12-17 11:45 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: linux-kernel, linux-gpio, Peter Griffin, Tudor Ambarus,
Will McVicker, Juan Yescas, André Draszik
irqd_get_trigger_type() is meant for cases where the driver needs to
know the configured IRQ trigger type and e.g. wants to change its
behaviour accordingly. Furthermore, platform support code, e.g. DT
handling, will configure the hardware based on that, and drivers don't
need to pass the trigger type into request_irq() and friends.
Drop the use from this driver, as it doesn't need to know the trigger
type.
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
drivers/gpio/gpio-max77759.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/gpio/gpio-max77759.c b/drivers/gpio/gpio-max77759.c
index 5e48eb03e7b366465e24383a7d1152351906968a..3bf9f23d1532848d8706f7291f59b5c20e9715a4 100644
--- a/drivers/gpio/gpio-max77759.c
+++ b/drivers/gpio/gpio-max77759.c
@@ -435,8 +435,6 @@ static int max77759_gpio_probe(struct platform_device *pdev)
int irq;
struct gpio_irq_chip *girq;
int ret;
- unsigned long irq_flags;
- struct irq_data *irqd;
chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);
if (!chip)
@@ -486,13 +484,9 @@ static int max77759_gpio_probe(struct platform_device *pdev)
return dev_err_probe(&pdev->dev, ret,
"Failed to add GPIO chip\n");
- irq_flags = IRQF_ONESHOT | IRQF_SHARED;
- irqd = irq_get_irq_data(irq);
- if (irqd)
- irq_flags |= irqd_get_trigger_type(irqd);
-
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
- max77759_gpio_irqhandler, irq_flags,
+ max77759_gpio_irqhandler,
+ IRQF_ONESHOT | IRQF_SHARED,
dev_name(&pdev->dev), chip);
if (ret < 0)
return dev_err_probe(&pdev->dev, ret,
---
base-commit: 12b95d29eb979e5c4f4f31bb05817bc935c52050
change-id: 20251217-max77759-gpio-irq-trigger-8e08bfb10b35
Best regards,
--
André Draszik <andre.draszik@linaro.org>
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-12-17 11:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-17 11:45 [PATCH] gpio: max77759: drop use of irqd_get_trigger_type André Draszik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).