public inbox for linux-gpio@vger.kernel.org
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Linus Walleij <linusw@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Jason Gunthorpe <jgg@nvidia.com>, Johan Hovold <johan@kernel.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	chrome-platform@lists.linux.dev, tzungbi@kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	linux-gpio@vger.kernel.org
Subject: [PATCH v2 01/11] gpio: Access `gpio_bus_type` in gpiochip_setup_dev()
Date: Tue,  3 Feb 2026 06:10:48 +0000	[thread overview]
Message-ID: <20260203061059.975605-2-tzungbi@kernel.org> (raw)
In-Reply-To: <20260203061059.975605-1-tzungbi@kernel.org>

To make the intent clear, access `gpio_bus_type` only when it's ready in
gpiochip_setup_dev().

Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
v2:
- No changes.

v1: https://lore.kernel.org/all/20260116081036.352286-7-tzungbi@kernel.org

 drivers/gpio/gpiolib.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 039cd3e56baf..f51f53511ae3 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -902,6 +902,8 @@ static int gpiochip_setup_dev(struct gpio_device *gdev)
 	struct fwnode_handle *fwnode = dev_fwnode(&gdev->dev);
 	int ret;
 
+	gdev->dev.bus = &gpio_bus_type;
+
 	/*
 	 * If fwnode doesn't belong to another device, it's safe to clear its
 	 * initialized flag.
@@ -1078,7 +1080,6 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
 
 	device_initialize(&gdev->dev);
 	gdev->dev.type = &gpio_dev_type;
-	gdev->dev.bus = &gpio_bus_type;
 	gdev->dev.parent = gc->parent;
 	device_set_node(&gdev->dev, gpiochip_choose_fwnode(gc));
 
@@ -1216,8 +1217,8 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
 	 * we get a device node entry in sysfs under
 	 * /sys/bus/gpio/devices/gpiochipN/dev that can be used for
 	 * coldplug of device nodes and other udev business.
-	 * We can do this only if gpiolib has been initialized.
-	 * Otherwise, defer until later.
+	 * We can do this only if gpiolib has been initialized
+	 * (i.e., `gpio_bus_type` is ready).  Otherwise, defer until later.
 	 */
 	if (gpiolib_initialized) {
 		ret = gpiochip_setup_dev(gdev);
-- 
2.53.0.rc2.204.g2597b5adb4-goog


  reply	other threads:[~2026-02-03  6:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03  6:10 [PATCH v2 00/11] gpio: Adopt revocable mechanism for UAF prevention Tzung-Bi Shih
2026-02-03  6:10 ` Tzung-Bi Shih [this message]
2026-02-03  6:10 ` [PATCH v2 02/11] gpio: Remove redundant check for struct gpio_chip Tzung-Bi Shih
2026-02-03  6:10 ` [PATCH v2 03/11] gpio: sysfs: " Tzung-Bi Shih
2026-02-04 10:33   ` Bartosz Golaszewski
2026-02-05  8:51     ` Tzung-Bi Shih
2026-02-03  6:10 ` [PATCH v2 04/11] gpio: Ensure struct gpio_chip for gpiochip_setup_dev() Tzung-Bi Shih
2026-02-04 10:36   ` Bartosz Golaszewski
2026-02-05  8:51     ` Tzung-Bi Shih
2026-02-03  6:10 ` [PATCH v2 05/11] gpio: cdev: Don't check struct gpio_chip in gpio_chrdev_open() Tzung-Bi Shih
2026-02-03  6:10 ` [PATCH v2 06/11] selftests: gpio: Add gpio-cdev-uaf tests Tzung-Bi Shih
2026-02-03  6:10 ` [PATCH v2 07/11] gpio: Add revocable provider handle for struct gpio_chip Tzung-Bi Shih
2026-02-04 12:58   ` Bartosz Golaszewski
2026-02-05  8:52     ` Tzung-Bi Shih
2026-02-05 16:57       ` Bartosz Golaszewski
2026-02-06  9:13         ` Tzung-Bi Shih
2026-02-03  6:10 ` [PATCH v2 08/11] gpio: cdev: Leverage revocable for accessing " Tzung-Bi Shih
2026-02-03  9:51   ` Tzung-Bi Shih
2026-02-04 13:02   ` Bartosz Golaszewski
2026-02-03  6:10 ` [PATCH v2 09/11] gpio: Remove gpio_chip_guard by using revocable Tzung-Bi Shih
2026-02-04 13:05   ` Bartosz Golaszewski
2026-02-03  6:10 ` [PATCH v2 10/11] gpio: Leverage revocable for accessing struct gpio_chip Tzung-Bi Shih
2026-02-03  6:10 ` [PATCH v2 11/11] gpio: Remove unused `chip` and `srcu` in struct gpio_device Tzung-Bi Shih
2026-02-03 11:15 ` [PATCH v2 00/11] gpio: Adopt revocable mechanism for UAF prevention Bartosz Golaszewski
2026-02-03 16:53 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260203061059.975605-2-tzungbi@kernel.org \
    --to=tzungbi@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=chrome-platform@lists.linux.dev \
    --cc=corbet@lwn.net \
    --cc=dakr@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jgg@nvidia.com \
    --cc=johan@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=shuah@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox