Re: [PATCH] tof: Add VL53L4CX TOF drivers

[kernel test robot <lkp@intel.com>]

Hi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v6.19-rc8 next-20260205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/434779359-qq-com/tof-Add-VL53L4CX-TOF-drivers/20260207-174646
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/tencent_326708D02875274DF25B10B91402B3828606%40qq.com
patch subject: [PATCH] tof: Add VL53L4CX TOF drivers
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260208/202602080159.l0CRmkUf-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260208/202602080159.l0CRmkUf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602080159.l0CRmkUf-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/iio/proximity/vl53l4cx-i2c.c: In function 'ctrl_mz_data_blocking_common':
>> drivers/iio/proximity/vl53l4cx-i2c.c:16100:13: warning: variable 'rc0' set but not used [-Wunused-but-set-variable]
   16100 |         int rc0;
         |             ^~~


vim +/rc0 +16100 drivers/iio/proximity/vl53l4cx-i2c.c

 16096	
 16097	static int ctrl_mz_data_blocking_common(struct stmvl53lx_data *data, void __user *p, bool is_additional)
 16098	{
 16099		int rc = 0;
 16100		int rc0;
 16101		struct stmvl53lx_data_with_additional __user *d = p;
 16102		pid_t pid = current->pid;
 16103	
 16104		mutex_lock(&data->work_mutex);
 16105		if (data->is_device_remove) {
 16106			rc = -ENODEV;
 16107			goto done;
 16108		}
 16109		if (!data->enable_sensor) {
 16110			rc = -ENODEV;
 16111			goto done;
 16112		}
 16113		if (!is_new_data_for_me(data, pid, &data->mz_data_reader_list))
 16114			rc = sleep_for_data(data, pid, &data->mz_data_reader_list);
 16115		if (rc) {
 16116			kill_mz_data(&data->meas.multi_range_data);
 16117			rc0 = copy_to_user(&d->data, &data->meas.multi_range_data, sizeof(VL53LX_MultiRangingData_t));
 16118			goto done;
 16119		}
 16120	
 16121		rc = copy_to_user(&d->data, &data->meas.multi_range_data, sizeof(VL53LX_MultiRangingData_t));
 16122		if (rc)
 16123			goto done;
 16124		if (is_additional) {
 16125			rc = copy_to_user(&d->additional_data, &data->meas.additional_data, sizeof(VL53LX_AdditionalData_t));
 16126			if (rc)
 16127				goto done;
 16128		}
 16129		rc = add_reader(pid, &data->mz_data_reader_list);
 16130	
 16131	done:
 16132		mutex_unlock(&data->work_mutex);
 16133	
 16134		return rc;
 16135	}
 16136	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki