From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: [PATCH v2 1/4] iio: adc: ti-ads7950: normalize return value of gpio_get
Date: Wed, 18 Feb 2026 18:29:25 -0800 [thread overview]
Message-ID: <20260219022929.3558081-2-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20260219022929.3558081-1-dmitry.torokhov@gmail.com>
The GPIO get callback is expected to return 0 or 1 (or a negative error
code). Ensure that the value returned by ti_ads7950_get() for output
pins is normalized to the [0, 1] range.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/iio/adc/ti-ads7950.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c
index bbe1ce577789..b8cc39fc39fb 100644
--- a/drivers/iio/adc/ti-ads7950.c
+++ b/drivers/iio/adc/ti-ads7950.c
@@ -433,7 +433,7 @@ static int ti_ads7950_get(struct gpio_chip *chip, unsigned int offset)
/* If set as output, return the output */
if (st->gpio_cmd_settings_bitmask & BIT(offset)) {
- ret = st->cmd_settings_bitmask & BIT(offset);
+ ret = (st->cmd_settings_bitmask & BIT(offset)) ? 1 : 0;
goto out;
}
--
2.53.0.335.g19a08e0c02-goog
next prev parent reply other threads:[~2026-02-19 2:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 2:29 [PATCH v2 0/4] ti-ads7950: fix gpio handling and facelift Dmitry Torokhov
2026-02-19 2:29 ` Dmitry Torokhov [this message]
2026-02-19 7:52 ` [PATCH v2 1/4] iio: adc: ti-ads7950: normalize return value of gpio_get Andy Shevchenko
2026-02-19 9:17 ` Bartosz Golaszewski
2026-02-19 18:25 ` Linus Walleij
2026-02-22 14:03 ` Jonathan Cameron
2026-02-22 21:22 ` Dmitry Torokhov
2026-02-19 2:29 ` [PATCH v2 2/4] iio: adc: ti-ads7950: do not clobber gpio state in ti_ads7950_get() Dmitry Torokhov
2026-02-19 7:55 ` Andy Shevchenko
2026-02-21 17:21 ` David Lechner
2026-02-19 2:29 ` [PATCH v2 3/4] iio: adc: ti-ads7950: switch to using guard() notation Dmitry Torokhov
2026-02-19 7:51 ` Andy Shevchenko
2026-02-21 17:20 ` David Lechner
2026-02-22 21:31 ` Dmitry Torokhov
2026-02-23 16:35 ` David Lechner
2026-02-21 17:34 ` David Lechner
2026-02-22 21:37 ` Dmitry Torokhov
2026-02-23 16:31 ` David Lechner
2026-02-19 2:29 ` [PATCH v2 4/4] iio: adc: ti-ads7950: complete conversion to using managed resources Dmitry Torokhov
2026-02-19 7:59 ` Andy Shevchenko
2026-02-21 0:09 ` Dmitry Torokhov
2026-02-22 19:12 ` Andy Shevchenko
2026-02-23 20:52 ` Jonathan Cameron
2026-02-21 17:43 ` David Lechner
2026-02-22 14:09 ` Jonathan Cameron
2026-02-22 21:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219022929.3558081-2-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox