From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF0CD282F16; Mon, 2 Mar 2026 22:08:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772489328; cv=none; b=DSMx9iby6xIljZ2tuYXuxWdff4v7V4Fmu3cMwoda6dEpTWhlbzg2eiB1WRgqnbV2BEeSymh+SDqpyuiRdzcyA316zpLBIeo+WQMA5AQOALQc27D0lHUpzwT849BW6zX37LyMCGxwYNInJ3N8wq4Bw0Ibjy27zb9u5O6o6W/n3x4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772489328; c=relaxed/simple; bh=MWeiRHOZVMp8f8oX8Z0AIictRy9pyjV/mPA9ZtkT2AQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S6P+vs0Mt/bOROIyFcs5kU49pniJjytvW4ctsrf1/zZ7wFsnzPh/QRWi7V27HbQ+e/W8wUvX98aKqZiecLr/lH3cAnS8PiW1WzYkTxj/FSes0ziJyFyEx6FYCMy0SjPh+KAH3+C19QRg3D+Nvy0RWXdsC7JOr1O975D+G5SA6sU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mTfh1LSL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mTfh1LSL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94699C19423; Mon, 2 Mar 2026 22:08:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772489328; bh=MWeiRHOZVMp8f8oX8Z0AIictRy9pyjV/mPA9ZtkT2AQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mTfh1LSL3ln5ZRLjHnCQOQE2MGQjVfSGFu6Y+lcOa36J6O6p0e52/K4tId/GbXuGP 0eR8ggeMIFIuDSwHINvXBV+wUPHYOgb89fRnVXxuqRW1JoSvaWudstKXG91Lk8s3uZ 62S6r0Z2TsBMPaMaRTI4Gv1iuZIKe2mocQ1pNcpQ3ZdrsGvbGYyeV9E1kF/0+WjhLM fyQ8cyRlkW4hybha8goZCuWpTZrJpThuP5W0YUESgQ5SGFcoN518y28h24wmvxUI0e umK6cv52O5R7AKdTUVJdQUrY+k+tQJwRPOfnaibb3dyMOM8FK9N0/E+4Lo79DMLyzm N2Ec5s2Zdl4jg== Date: Mon, 2 Mar 2026 22:08:44 +0000 From: Conor Dooley To: Felix Gu Cc: Conor Dooley , Daire McNamara , Linus Walleij , linux-riscv@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: microchip-mssio: Fix missing return in probe Message-ID: <20260302-mayflower-filing-e111fbcc7d30@spud> References: <20260303-mssio-v1-1-ea0fdf3bf202@gmail.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="b9dU3SrgV6WWXKXq" Content-Disposition: inline In-Reply-To: <20260303-mssio-v1-1-ea0fdf3bf202@gmail.com> --b9dU3SrgV6WWXKXq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 03, 2026 at 02:13:17AM +0800, Felix Gu wrote: > In mpfs_pinctrl_probe(), when pctrl->regmap fails, it just print out an > error message without return, which could lead serious errors. >=20 > Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver") > Signed-off-by: Felix Gu Reviewed-by: Conor Dooley --b9dU3SrgV6WWXKXq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaaYKbAAKCRB4tDGHoIJi 0uf8AQCDlTaYPVh8zUpVkl/UC7RIvNq8xGN1yjVKohZC8GIqZAD/cKb+4dvv6/0O 8KAgzRWqTAcSvrgFQNI9NTsj6p+h7gM= =75b+ -----END PGP SIGNATURE----- --b9dU3SrgV6WWXKXq--