From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B83383AEF53; Tue, 3 Mar 2026 14:12:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772547163; cv=none; b=VQrRfjVWg51egNW5LaoUVok+SJkAhy31rauFTB/vtUbDszqLIgfKHpRKjDaBCGtbfuqVwmgyajqz1f11CqSGYuHHXvKJ38Mt+ROFaSrHSoXI0lA/n1rgZ3AhqGGA/Xn9k+6Ka+/wI8P6qJud6XM4/ZkJnEPI2tivsCUXk58bG2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772547163; c=relaxed/simple; bh=dPGInr9bJSJ4aaTC8V6Vfs27BwEv/iSgsWjWG9xQ8Pk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VgGNSRa/nRW5IUISlBVLbf+ovl5eEyjETSImOEm7ZHdN6xbs09HGwUiqCOD9N5rkwRvh5+5wy0VtvRYM6iNiW8ozPXwpeLp2AzAzmdgZ0XA7900RLSh2scJtePmNbDrAurC4XHdAOjg4ge0m18Xp2EONxBKsdHQmhZQHwKW0PJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=PKXnJBTJ; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="PKXnJBTJ" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 838BCC40FAB; Tue, 3 Mar 2026 14:12:56 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B0FF95FF87; Tue, 3 Mar 2026 14:12:38 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 29A51102F19D0; Tue, 3 Mar 2026 15:12:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1772547155; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=NDntnEFk19MkiUVyHnkpMvjEQ0xuOComNTKHqxzRgtY=; b=PKXnJBTJeOSAhEFdsakoatz9eZVQJsYsja7QCQMQzgMh/5rn1PRNYjh0Y43mXfXGOsBQe3 ylbpcNlkEYOZJgf5w2TjuKlN6BoKRqaUv2T7NSWnft4+R5CB1JRZXmzrvE9foIFtljC0dX 9lnks0jyXkMRsFdgc/AIne583SVg0IBmmZGSlbX4ZFFiZoIRIMxN3ep1XEp5lG3ykQNMTV 2MMAGU53bJevHap0Qjn6XIWdND7dFzJBZWAWKL1cGUcMwe1FByNjIm1aDXdWkatlTF4u4d eRAAosIijuZ77ayzdkxgCV3s0AjnR8VvyjdUbgJKG2IeDC3gKeA+0ZFLN444JQ== Date: Tue, 3 Mar 2026 15:12:10 +0100 From: Herve Codina To: Jonathan Cameron Cc: Andrew Lunn , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , "Geert Uytterhoeven" , Kalle Niemi , Matti Vaittinen , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Frank Li , "Sascha Hauer" , Pengutronix Kernel Team , Fabio Estevam , "Michael Turquette" , Stephen Boyd , "Andi Shyti" , Wolfram Sang , Peter Rosin , "Arnd Bergmann" , Saravana Kannan , "Bjorn Helgaas" , Charles Keepax , Richard Fitzgerald , David Rhodes , "Linus Walleij" , Ulf Hansson , "Mark Brown" , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Davidlohr Bueso , "Dave Jiang" , Alison Schofield , Vishal Verma , "Ira Weiny" , Dan Williams , "Shawn Guo" , Wolfram Sang , , , , , , , , , , , , , , , , Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v5 07/28] driver core: fw_devlink: Introduce fw_devlink_set_device() Message-ID: <20260303151210.6e8462b8@bootlin.com> In-Reply-To: <20260302122336.00006bd8@huawei.com> References: <20260227135428.783983-1-herve.codina@bootlin.com> <20260227135428.783983-8-herve.codina@bootlin.com> <20260302122336.00006bd8@huawei.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Jonathan, On Mon, 2 Mar 2026 12:23:36 +0000 Jonathan Cameron wrote: > On Fri, 27 Feb 2026 14:54:04 +0100 > Herve Codina wrote: > > > Setting fwnode->dev is specific to fw_devlink. > > > > In order to avoid having a direct 'fwnode->dev = dev;' in several > > place in the kernel, introduce fw_devlink_set_device() helper to perform > > this operation. > > > I don't mind the helper, but the description could do with a little > detail on why. Is it just to avoid visibility of internal details, or > is there a stronger reason? I think the idea was to avoid visibility. It cames from feedback received on my first iteration https://lore.kernel.org/all/20250408145139.293c79a2@bootlin.com/ I found the idea relevant and so I did the patch. Best regards, Hervé