From: Rosen Penev <rosenp@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: Lixu Zhang <lixu.zhang@intel.com>,
linux-hardening@vger.kernel.org, gustavoars@kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] gpio: ljca: reduce struct allocation
Date: Sat, 7 Mar 2026 18:12:01 -0800 [thread overview]
Message-ID: <20260308021201.47820-1-rosenp@gmail.com> (raw)
Convert connect_mode to a flexible array member to avoid calling
kcalloc and to combine the allocations.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/gpio/gpio-ljca.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-ljca.c b/drivers/gpio/gpio-ljca.c
index f32d1d237795..a531aaa0425f 100644
--- a/drivers/gpio/gpio-ljca.c
+++ b/drivers/gpio/gpio-ljca.c
@@ -63,7 +63,6 @@ struct ljca_gpio_dev {
DECLARE_BITMAP(enabled_irqs, LJCA_MAX_GPIO_NUM);
DECLARE_BITMAP(reenable_irqs, LJCA_MAX_GPIO_NUM);
DECLARE_BITMAP(output_enabled, LJCA_MAX_GPIO_NUM);
- u8 *connect_mode;
/* protect irq bus */
struct mutex irq_lock;
struct work_struct work;
@@ -72,6 +71,8 @@ struct ljca_gpio_dev {
u8 obuf[LJCA_GPIO_BUF_SIZE];
u8 ibuf[LJCA_GPIO_BUF_SIZE];
+
+ u8 connect_mode[];
};
static int ljca_gpio_config(struct ljca_gpio_dev *ljca_gpio, u8 gpio_id,
@@ -400,22 +401,19 @@ static int ljca_gpio_probe(struct auxiliary_device *auxdev,
const struct auxiliary_device_id *aux_dev_id)
{
struct ljca_client *ljca = auxiliary_dev_to_ljca_client(auxdev);
+ struct ljca_gpio_info *gpio_info;
struct ljca_gpio_dev *ljca_gpio;
struct gpio_irq_chip *girq;
int ret;
- ljca_gpio = devm_kzalloc(&auxdev->dev, sizeof(*ljca_gpio), GFP_KERNEL);
+ gpio_info = dev_get_platdata(&auxdev->dev);
+ ljca_gpio = devm_kzalloc(&auxdev->dev, struct_size(ljca_gpio, connect_mode, gpio_info->num),
+ GFP_KERNEL);
if (!ljca_gpio)
return -ENOMEM;
ljca_gpio->ljca = ljca;
- ljca_gpio->gpio_info = dev_get_platdata(&auxdev->dev);
- ljca_gpio->connect_mode = devm_kcalloc(&auxdev->dev,
- ljca_gpio->gpio_info->num,
- sizeof(*ljca_gpio->connect_mode),
- GFP_KERNEL);
- if (!ljca_gpio->connect_mode)
- return -ENOMEM;
+ ljca_gpio->gpio_info = gpio_info;
ret = devm_mutex_init(&auxdev->dev, &ljca_gpio->irq_lock);
if (ret)
--
2.53.0
next reply other threads:[~2026-03-08 2:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 2:12 Rosen Penev [this message]
2026-03-08 12:19 ` [PATCH] gpio: ljca: reduce struct allocation Sakari Ailus
2026-03-08 18:54 ` Rosen Penev
2026-03-09 7:19 ` Sakari Ailus
2026-03-09 7:32 ` Rosen Penev
2026-03-09 9:22 ` Bartosz Golaszewski
2026-03-09 21:48 ` Rosen Penev
2026-03-10 11:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260308021201.47820-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=brgl@kernel.org \
--cc=gustavoars@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox