public inbox for linux-gpio@vger.kernel.org
 help / color / mirror / Atom feed
From: Antti Laakso <antti.laakso@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	linusw@kernel.org, brgl@kernel.org, sakari.ailus@linux.intel.com,
	mchehab@kernel.org, dan.scally@ideasonboard.com,
	hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
	hverkuil+cisco@kernel.org, sre@kernel.org, hao.yao@intel.com,
	jimmy.su@intel.com, miguel.vadillo@intel.com, kees@kernel.org,
	ribalda@chromium.org
Subject: [PATCH v2 4/5] gpio: tps68470: Add i2c daisy chain support
Date: Wed, 11 Mar 2026 15:19:09 +0200	[thread overview]
Message-ID: <20260311131910.835513-5-antti.laakso@linux.intel.com> (raw)
In-Reply-To: <20260311131910.835513-1-antti.laakso@linux.intel.com>

The tps68470 daisy chain make use of gpio 1 and 2. When in use, these
gpios must be configured as inputs without pull-up.

Signed-off-by: Antti Laakso <antti.laakso@linux.intel.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
---
 drivers/gpio/gpio-tps68470.c | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-tps68470.c b/drivers/gpio/gpio-tps68470.c
index d4fbdf90e190..8541acecfbbe 100644
--- a/drivers/gpio/gpio-tps68470.c
+++ b/drivers/gpio/gpio-tps68470.c
@@ -120,6 +120,17 @@ static int tps68470_gpio_input(struct gpio_chip *gc, unsigned int offset)
 				   TPS68470_GPIO_MODE_MASK, 0x00);
 }
 
+static int tps68470_enable_i2c_daisy_chain(struct gpio_chip *gc)
+{
+	int ret;
+
+	ret = tps68470_gpio_input(gc, 1);
+	if (ret)
+		return ret;
+
+	return tps68470_gpio_input(gc, 2);
+}
+
 static const char *tps68470_names[TPS68470_N_GPIO] = {
 	"gpio.0", "gpio.1", "gpio.2", "gpio.3",
 	"gpio.4", "gpio.5", "gpio.6",
@@ -129,6 +140,7 @@ static const char *tps68470_names[TPS68470_N_GPIO] = {
 static int tps68470_gpio_probe(struct platform_device *pdev)
 {
 	struct tps68470_gpio_data *tps68470_gpio;
+	int ret;
 
 	tps68470_gpio = devm_kzalloc(&pdev->dev, sizeof(*tps68470_gpio),
 				     GFP_KERNEL);
@@ -149,7 +161,14 @@ static int tps68470_gpio_probe(struct platform_device *pdev)
 	tps68470_gpio->gc.base = -1;
 	tps68470_gpio->gc.parent = &pdev->dev;
 
-	return devm_gpiochip_add_data(&pdev->dev, &tps68470_gpio->gc, tps68470_gpio);
+	ret = devm_gpiochip_add_data(&pdev->dev, &tps68470_gpio->gc, tps68470_gpio);
+	if (ret)
+		return ret;
+
+	if (device_property_present(&pdev->dev, "daisy-chain-enable"))
+		ret = tps68470_enable_i2c_daisy_chain(&tps68470_gpio->gc);
+
+	return ret;
 }
 
 static struct platform_driver tps68470_gpio_driver = {
-- 
2.53.0


  parent reply	other threads:[~2026-03-11 13:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 13:19 [PATCH v2 0/5] platform: int3472: Add MSI prestige 14 AI EVO data Antti Laakso
2026-03-11 13:19 ` [PATCH v2 1/5] media: i2c: ov5675: Wait for endpoint Antti Laakso
2026-03-11 14:31   ` Hans de Goede
2026-03-11 19:10   ` Dan Scally
2026-03-11 13:19 ` [PATCH v2 2/5] media: ipu-bridge: Add ov5675 sensor Antti Laakso
2026-03-17 12:52   ` Sakari Ailus
2026-03-11 13:19 ` [PATCH v2 3/5] platform: int3472: Add gpio software node Antti Laakso
2026-03-11 14:33   ` Hans de Goede
2026-03-11 14:43   ` Bartosz Golaszewski
2026-03-17 11:53   ` Ilpo Järvinen
2026-03-11 13:19 ` Antti Laakso [this message]
2026-03-11 14:33   ` [PATCH v2 4/5] gpio: tps68470: Add i2c daisy chain support Hans de Goede
2026-03-11 14:42   ` Bartosz Golaszewski
2026-03-11 13:19 ` [PATCH v2 5/5] platform: int3472: Add MSI prestige board data Antti Laakso
2026-03-11 14:35   ` Hans de Goede
2026-03-12 21:00     ` Sakari Ailus
2026-03-11 14:43   ` Bartosz Golaszewski
2026-03-11 19:27   ` Dan Scally
2026-03-17 11:52   ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311131910.835513-5-antti.laakso@linux.intel.com \
    --to=antti.laakso@linux.intel.com \
    --cc=brgl@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=hansg@kernel.org \
    --cc=hao.yao@intel.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jimmy.su@intel.com \
    --cc=kees@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=miguel.vadillo@intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=ribalda@chromium.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox