Re: [PATCH v2 5/5] platform: int3472: Add MSI prestige board data

Sakari Ailus
2026-03-12T20:58:13Z

Hi Hans, others,

On Wed, Mar 11, 2026 at 03:35:28PM +0100, Hans de Goede wrote:
> > +static const struct regulator_init_data msi_p14_ai_evo_tps68470_vio_reg_init_data = {
> > + .constraints = {
> > + .min_uV = 1800600,
> > + .max_uV = 1800600,
> > + .apply_uV = 1,
> > + .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> > + },
>
> > + .num_consumer_supplies = 0,
> > + .consumer_supplies = NULL,
>
> Nit (no need to fix unless you need to do a v3 for other reasons),
> these 2 explicit foo = 0 initializers are not necessary and can
> be dropped.

I can fix this while applying...

>
> Otherwise this looks good to me:
>
> Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

...assuming everyone is fine with merging these via the media tree. Let me
know if there are concerns.

Thank you for the reviews.

--
Kind regards,

Sakari Ailus