Re: [PATCH v2 3/5] platform: int3472: Add gpio software node

Hans de Goede
2026-03-11T14:33:18Z

Hi,

On 11-Mar-26 14:19, Antti Laakso wrote:
> The tps68470 supports i2c daisy chain, which need to be configured by
> gpio-tps68470 driver. Add daisy chain information to software node.

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Regards,

Hans

>
> Signed-off-by: Antti Laakso <antti.laakso@linux.intel.com>
> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> ---
> drivers/platform/x86/intel/int3472/tps68470.c | 1 +
> drivers/platform/x86/intel/int3472/tps68470.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/intel/int3472/tps68470.c b/drivers/platform/x86/intel/int3472/tps68470.c
> index a496075c0d2a..a77ed32abe55 100644
> --- a/drivers/platform/x86/intel/int3472/tps68470.c
> +++ b/drivers/platform/x86/intel/int3472/tps68470.c
> @@ -197,6 +197,7 @@ static int skl_int3472_tps68470_probe(struct i2c_client *client)
> cells[1].platform_data = (void *)board_data->tps68470_regulator_pdata;
> cells[1].pdata_size = sizeof(struct tps68470_regulator_platform_data);
> cells[2].name = "tps68470-gpio";
> + cells[2].swnode = board_data->tps68470_gpio_swnode;
>
> for (i = 0; i < board_data->n_gpiod_lookups; i++)
> gpiod_add_lookup_table(board_data->tps68470_gpio_lookup_tables[i]);
> diff --git a/drivers/platform/x86/intel/int3472/tps68470.h b/drivers/platform/x86/intel/int3472/tps68470.h
> index 35915e701593..3bbaade96c57 100644
> --- a/drivers/platform/x86/intel/int3472/tps68470.h
> +++ b/drivers/platform/x86/intel/int3472/tps68470.h
> @@ -17,6 +17,7 @@ struct tps68470_regulator_platform_data;
> struct int3472_tps68470_board_data {
> const char *dev_name;
> const struct tps68470_regulator_platform_data *tps68470_regulator_pdata;
> + const struct software_node *tps68470_gpio_swnode;
> unsigned int n_gpiod_lookups;
> struct gpiod_lookup_table *tps68470_gpio_lookup_tables[];
> };