From: Rosen Penev <rosenp@gmail.com>
To: linux-tegra@vger.kernel.org
Cc: Linus Walleij <linusw@kernel.org>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] pinctrl: tegra: use flexible array member for array
Date: Sun, 15 Mar 2026 16:10:00 -0700 [thread overview]
Message-ID: <20260315231000.50543-1-rosenp@gmail.com> (raw)
Simplifies allocation slightly by removing a kcalloc call and using
struct_size.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/pinctrl/tegra/pinctrl-tegra.c | 9 ++-------
drivers/pinctrl/tegra/pinctrl-tegra.h | 2 +-
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
index 11ecbd6a9b2a..b09d7675a33a 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
@@ -832,19 +832,14 @@ int tegra_pinctrl_probe(struct platform_device *pdev,
int fn, gn, gfn;
unsigned long backup_regs_size = 0;
- pmx = devm_kzalloc(&pdev->dev, sizeof(*pmx), GFP_KERNEL);
+ pmx = devm_kzalloc(&pdev->dev,
+ struct_size(pmx, pingroup_configs, soc_data->ngroups), GFP_KERNEL);
if (!pmx)
return -ENOMEM;
pmx->dev = &pdev->dev;
pmx->soc = soc_data;
- pmx->pingroup_configs = devm_kcalloc(&pdev->dev,
- pmx->soc->ngroups, sizeof(*pmx->pingroup_configs),
- GFP_KERNEL);
- if (!pmx->pingroup_configs)
- return -ENOMEM;
-
/*
* Each mux group will appear in 4 functions' list of groups.
* This over-allocates slightly, since not all groups are mux groups.
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.h b/drivers/pinctrl/tegra/pinctrl-tegra.h
index bc7b70913b89..c74272c82828 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra.h
+++ b/drivers/pinctrl/tegra/pinctrl-tegra.h
@@ -26,7 +26,7 @@ struct tegra_pmx {
void __iomem **regs;
u32 *backup_regs;
/* Array of size soc->ngroups */
- struct tegra_pingroup_config *pingroup_configs;
+ struct tegra_pingroup_config pingroup_configs[];
};
enum tegra_pinconf_param {
--
2.53.0
next reply other threads:[~2026-03-15 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 23:10 Rosen Penev [this message]
2026-03-19 13:27 ` [PATCH] pinctrl: tegra: use flexible array member for array Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260315231000.50543-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox