From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linusw@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 3/3] pinctrl: pinconf-generic: Convert ..._parse_dt_pinmux() to fwnode API
Date: Tue, 17 Mar 2026 11:36:13 +0100 [thread overview]
Message-ID: <20260317103817.1982584-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20260317103817.1982584-1-andriy.shevchenko@linux.intel.com>
Convert pinconf_generic_parse_dt_pinmux() to fwnode API. This makes code
cleaner and potentially reusable for some other types of fwnodes, such as
software nodes.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/pinconf-generic.c | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c
index 0ed57720ae61..88eacd1aa2de 100644
--- a/drivers/pinctrl/pinconf-generic.c
+++ b/drivers/pinctrl/pinconf-generic.c
@@ -312,20 +312,19 @@ int pinconf_generic_parse_dt_pinmux(struct device_node *np, struct device *dev,
unsigned int **pid, unsigned int **pmux,
unsigned int *npins)
{
+ struct fwnode_handle *fwnode = of_fwnode_handle(np);
unsigned int *pid_t;
unsigned int *pmux_t;
- struct property *prop;
unsigned int npins_t, i;
- u32 value;
int ret;
- prop = of_find_property(np, "pinmux", NULL);
- if (!prop) {
+ ret = fwnode_property_count_u32(fwnode, "pinmux");
+ if (ret < 0) {
dev_info(dev, "Missing pinmux property\n");
- return -ENOENT;
+ return ret;
}
- npins_t = prop->length / sizeof(u32);
+ npins_t = ret;
if (npins_t == 0) {
dev_info(dev, "pinmux property doesn't have entries\n");
return -ENODATA;
@@ -342,14 +341,16 @@ int pinconf_generic_parse_dt_pinmux(struct device_node *np, struct device *dev,
dev_err(dev, "kalloc memory fail\n");
return -ENOMEM;
}
+
+ ret = fwnode_property_read_u32_array(fwnode, "pinmux", pmux_t, npins_t);
+ if (ret) {
+ dev_err(dev, "get pinmux value fail\n");
+ goto exit;
+ }
+
for (i = 0; i < npins_t; i++) {
- ret = of_property_read_u32_index(np, "pinmux", i, &value);
- if (ret) {
- dev_err(dev, "get pinmux value fail\n");
- goto exit;
- }
- pmux_t[i] = value & 0xff;
- pid_t[i] = (value >> 8) & 0xffffff;
+ pid_t[i] = pmux_t[i] >> 8;
+ pmux_t[i] = pmux_t[i] & 0xff;
}
*pid = pid_t;
*pmux = pmux_t;
--
2.50.1
next prev parent reply other threads:[~2026-03-17 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 10:36 [PATCH v1 0/3] pinctrl: pinconf-generic: More fwnode related conversions Andy Shevchenko
2026-03-17 10:36 ` [PATCH v1 1/3] pinctrl: pinconf-generic: Fully validate 'pinmux' property Andy Shevchenko
2026-03-17 10:36 ` [PATCH v1 2/3] pinctrl: pinconf-generic: Validate fwnode instead of device node Andy Shevchenko
2026-03-17 10:36 ` Andy Shevchenko [this message]
2026-03-19 18:22 ` [PATCH v1 0/3] pinctrl: pinconf-generic: More fwnode related conversions Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317103817.1982584-4-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox