Re: [PATCH v8 0/6] mfd: Add support for NXP MC33978/MC34978 MSDI

Rob Herring
2026-03-31T15:13:08Z

On Sun, Mar 29, 2026 at 08:34:31AM -0700, Guenter Roeck wrote:
> Hi Oleksij,
>
> On 3/29/26 02:05, Oleksij Rempel wrote:
> > changes v7:
> > - drop gpiolib irq fix and make pinctrl more robust against NULL point
> > dereference.
> >
> > This series adds support for the NXP MC33978/MC34978 Multiple Switch Detection
> > Interface (MSDI) via the MFD framework.
> >
> > Architecture overview:
> > * mfd: Core driver handling 2-frame pipelined SPI, regulator sequencing, and
> > linear irq_domain. Harvests status bits from SPI MISO MSB.
> > * pinctrl: Exposes 22 physical switch inputs as standard GPIOs. Proxies IRQs to
> > the MFD domain.
> > * hwmon: Exposes thermal limits, VBATP/VDDQ voltage boundaries, and dynamic
> > fault alarms.
> > * mux: Controls the 24-to-1 AMUX routing analog signals (switch voltages,
> > temperature, VBATP) to an external ADC.
> >
> > Initial pinctrl implementation by David Jander, reworked into this MFD
> > architecture.
> >
>
> I Acked the hwmon driver, but Sashiko is still not happy with several of the other
> patches in the series:
>
> https://sashiko.dev/#/patchset/20260329090601.532477-1-o.rempel%40pengutronix.de
>
> If the remaining issues are false positives, please let Roman and/or me know.

The binding issue is valid. However, it's an issue with many GPIO
controller bindings that's been on my todo to address. Generally, there
is only a reference to the provider schema when there's child nodes.
Originally, there wheren't child nodes for GPIO, but then we added hog
nodes. Changing things probably entails changes to gpio.yaml, so there's
really nothing to do on this binding yet.

I really hope this sashiko stuff gains support soon in a form I can
review first and email out rather than dropping links into threads. It
is not a great workflow as-is.

Rob