Re: [libgpiod][PATCH 9/9] bindings: python: update linter configuration

Bartosz Golaszewski
2026-04-03T09:02:53Z

On Thu, Apr 2, 2026 at 7:01 PM Vincent Fazio <vfazio@gmail.com> wrote:
>
> On Thu, Apr 2, 2026 at 11:43 AM Bartosz Golaszewski <brgl@kernel.org> wrote:
> > > Some repositories try to implement these checks as part of pre-commit
> > > hooks but I wasn't sure if we wanted to go so far as requiring these
> > > checks
> >
> > How about making it part of the dist package generation?
>
> If you think it would be valuable, that seems reasonable? I don't know
> what that entails however.
>
> It may be "late" in the development flow, as in, at the time you want
> to make a dist package, the lint checks now say that there are
> suggested modifications or fixes necessary preventing you from
> building the distribution.
>
> Ideally the lint checks are done prior to patch submission to inform
> users that they may have overlooked something.
>
> It wouldn't surprise me if I'm the only one that really cares about
> the strict type checking and formatting. They're obviously not
> performing logic analysis; they just make sure that data types are
> correct/accounted for and all code is consistent in format.

I do run them but don't necessarily want them as a commit hook since
not everyone is working on python side of libgpiod.

I queued the patches, thanks! I have to say: it's crazy how much
faster ruff is compared to mypy.

Bartosz