* [PATCH] gpiolib: Make deferral warnings debug messages
@ 2026-04-01 13:34 Jon Hunter
2026-04-02 8:10 ` Bartosz Golaszewski
2026-04-03 9:03 ` Bartosz Golaszewski
0 siblings, 2 replies; 4+ messages in thread
From: Jon Hunter @ 2026-04-01 13:34 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski; +Cc: linux-gpio, linux-tegra, Jon Hunter
With the recent addition of the shared GPIO support, warning messages
such as the following are being observed ...
reg-fixed-voltage regulator-vdd-3v3-pcie: cannot find GPIO chip
gpiolib_shared.proxy.6, deferring
These are seen even with GPIO_SHARED_PROXY=y.
Given that the GPIOs are successfully found a bit later during boot and
the code is intentionally returning -EPROBE_DEFER when they are not
found, downgrade these messages to debug prints to avoid unnecessary
warnings being observed.
Note that although the 'cannot find GPIO line' warning has not been
observed in this case, it seems reasonable to make this print a debug
print for consistency too.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
drivers/gpio/gpiolib.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 96c776ff2669..1e6dce430dca 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -4624,8 +4624,8 @@ static struct gpio_desc *gpio_desc_table_match(struct device *dev, const char *c
return desc;
}
- dev_warn(dev, "cannot find GPIO line %s, deferring\n",
- p->key);
+ dev_dbg(dev, "cannot find GPIO line %s, deferring\n",
+ p->key);
return ERR_PTR(-EPROBE_DEFER);
}
@@ -4639,8 +4639,8 @@ static struct gpio_desc *gpio_desc_table_match(struct device *dev, const char *c
* consumer be probed again or let the Deferred
* Probe infrastructure handle the error.
*/
- dev_warn(dev, "cannot find GPIO chip %s, deferring\n",
- p->key);
+ dev_dbg(dev, "cannot find GPIO chip %s, deferring\n",
+ p->key);
return ERR_PTR(-EPROBE_DEFER);
}
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gpiolib: Make deferral warnings debug messages
2026-04-01 13:34 [PATCH] gpiolib: Make deferral warnings debug messages Jon Hunter
@ 2026-04-02 8:10 ` Bartosz Golaszewski
2026-04-02 8:18 ` Jon Hunter
2026-04-03 9:03 ` Bartosz Golaszewski
1 sibling, 1 reply; 4+ messages in thread
From: Bartosz Golaszewski @ 2026-04-02 8:10 UTC (permalink / raw)
To: Jon Hunter; +Cc: Linus Walleij, linux-gpio, linux-tegra
On Wed, Apr 1, 2026 at 3:35 PM Jon Hunter <jonathanh@nvidia.com> wrote:
>
> With the recent addition of the shared GPIO support, warning messages
> such as the following are being observed ...
>
> reg-fixed-voltage regulator-vdd-3v3-pcie: cannot find GPIO chip
> gpiolib_shared.proxy.6, deferring
>
> These are seen even with GPIO_SHARED_PROXY=y.
>
> Given that the GPIOs are successfully found a bit later during boot and
> the code is intentionally returning -EPROBE_DEFER when they are not
> found, downgrade these messages to debug prints to avoid unnecessary
> warnings being observed.
>
> Note that although the 'cannot find GPIO line' warning has not been
> observed in this case, it seems reasonable to make this print a debug
> print for consistency too.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
Yes, this makes sense. FYI I also have a grand plan of introducing
support for fw_devlink for software nodes and assigning them to shared
proxies with the aim of them respecting the probe order that way.
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpiolib: Make deferral warnings debug messages
2026-04-02 8:10 ` Bartosz Golaszewski
@ 2026-04-02 8:18 ` Jon Hunter
0 siblings, 0 replies; 4+ messages in thread
From: Jon Hunter @ 2026-04-02 8:18 UTC (permalink / raw)
To: Bartosz Golaszewski; +Cc: Linus Walleij, linux-gpio, linux-tegra
On 02/04/2026 09:10, Bartosz Golaszewski wrote:
> On Wed, Apr 1, 2026 at 3:35 PM Jon Hunter <jonathanh@nvidia.com> wrote:
>>
>> With the recent addition of the shared GPIO support, warning messages
>> such as the following are being observed ...
>>
>> reg-fixed-voltage regulator-vdd-3v3-pcie: cannot find GPIO chip
>> gpiolib_shared.proxy.6, deferring
>>
>> These are seen even with GPIO_SHARED_PROXY=y.
I meant CONFIG_GPIO_SHARED_PROXY=y here :-)
Let me know if you want me to send an updated version?
>>
>> Given that the GPIOs are successfully found a bit later during boot and
>> the code is intentionally returning -EPROBE_DEFER when they are not
>> found, downgrade these messages to debug prints to avoid unnecessary
>> warnings being observed.
>>
>> Note that although the 'cannot find GPIO line' warning has not been
>> observed in this case, it seems reasonable to make this print a debug
>> print for consistency too.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>
> Yes, this makes sense. FYI I also have a grand plan of introducing
> support for fw_devlink for software nodes and assigning them to shared
> proxies with the aim of them respecting the probe order that way.
OK, good to know.
Thanks
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpiolib: Make deferral warnings debug messages
2026-04-01 13:34 [PATCH] gpiolib: Make deferral warnings debug messages Jon Hunter
2026-04-02 8:10 ` Bartosz Golaszewski
@ 2026-04-03 9:03 ` Bartosz Golaszewski
1 sibling, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2026-04-03 9:03 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Jon Hunter
Cc: Bartosz Golaszewski, linux-gpio, linux-tegra
On Wed, 01 Apr 2026 14:34:41 +0100, Jon Hunter wrote:
> With the recent addition of the shared GPIO support, warning messages
> such as the following are being observed ...
>
> reg-fixed-voltage regulator-vdd-3v3-pcie: cannot find GPIO chip
> gpiolib_shared.proxy.6, deferring
>
> These are seen even with GPIO_SHARED_PROXY=y.
>
> [...]
Applied, thanks!
[1/1] gpiolib: Make deferral warnings debug messages
https://git.kernel.org/brgl/c/c0cd31bc3a92ac04147660a3821780f57b76bf1f
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-03 9:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-01 13:34 [PATCH] gpiolib: Make deferral warnings debug messages Jon Hunter
2026-04-02 8:10 ` Bartosz Golaszewski
2026-04-02 8:18 ` Jon Hunter
2026-04-03 9:03 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox