[PATCH] pinctrl: qcom: sdm670-lpass-lpi: label variables as static

[PATCH] pinctrl: qcom: sdm670-lpass-lpi: label variables as static

[Richard Acayan]

These variables are local to the driver and have no need to be exported
to the global namespace. Label them as static to fix compiler warnings.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202604080950.Mvm8aN0a-lkp@intel.com/
Fixes: 9826035a75da ("pinctrl: qcom: add sdm670 lpi tlmm")
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
 drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c
index 6270c6d09c22..858146c408d0 100644
--- a/drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c
+++ b/drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c
@@ -80,7 +80,7 @@ static const char * const pdm_sync_groups[] = { "gpio19" };
 static const char * const pdm_tx_groups[] = { "gpio20" };
 static const char * const slimbus_clk_groups[] = { "gpio18" };
 
-const struct lpi_pingroup sdm670_lpi_pinctrl_groups[] = {
+static const struct lpi_pingroup sdm670_lpi_pinctrl_groups[] = {
 	LPI_PINGROUP(0, LPI_NO_SLEW, _, _, _, _),
 	LPI_PINGROUP(1, LPI_NO_SLEW, _, _, _, _),
 	LPI_PINGROUP(2, LPI_NO_SLEW, _, _, _, _),
@@ -115,7 +115,7 @@ const struct lpi_pingroup sdm670_lpi_pinctrl_groups[] = {
 	LPI_PINGROUP(31, LPI_NO_SLEW, _, _, _, _),
 };
 
-const struct lpi_function sdm670_lpi_pinctrl_functions[] = {
+static const struct lpi_function sdm670_lpi_pinctrl_functions[] = {
 	LPI_FUNCTION(comp_rx),
 	LPI_FUNCTION(dmic1_clk),
 	LPI_FUNCTION(dmic1_data),
-- 
2.53.0

Re: [PATCH] pinctrl: qcom: sdm670-lpass-lpi: label variables as static

[Linus Walleij]

On Thu, Apr 9, 2026 at 12:29 AM Richard Acayan <mailingradian@gmail.com> wrote:

> These variables are local to the driver and have no need to be exported
> to the global namespace. Label them as static to fix compiler warnings.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202604080950.Mvm8aN0a-lkp@intel.com/
> Fixes: 9826035a75da ("pinctrl: qcom: add sdm670 lpi tlmm")
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>

Oh I just made the same patch, nevermind I'll apply this one instead.

Yours,
Linus Walleij