From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4463439A809 for ; Mon, 20 Apr 2026 10:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776682561; cv=none; b=MJXbAwBGanAB2SbivmfqHS0fwFCbuOrtbI31FMmxA7JFuGfnBdOsd/aRQw6RXWyJsgSLB2igwCP09P/v9GglYM3oTagU2XcIO8Jkyakeu0mFzRd8eQWYSWiRah5tHm3y+i68VEESEN/P+/I6NyvfUmwTOoST+meZqfs4qnsOG1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776682561; c=relaxed/simple; bh=A1WSNvZBH7Gl27blE0SBf08sIf2c8iIjtoiwnzlc7uU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=fgHCqcbD6cEkpa8vBKwM+JzEZxOPCM2FwzA2wam5MQKgjUbo+rGB4Ibdn4GIPMYFYPEaLM/4IPshNCi9pqm19JwmgAgQKWV6nyCdNCsb9fv65PZjBxz0xWEX/PI6AEa08K7uacSfQyFlJ6fI41MLO8TUeEW/OtNQZJQ05FRzqmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C2GApaAd; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C2GApaAd" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82f946efa38so1262364b3a.0 for ; Mon, 20 Apr 2026 03:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776682559; x=1777287359; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=86QtRyfODNt78/15/vwrG7dKY8dGMsIZ3LKVUkBa3Dc=; b=C2GApaAdsHE7hO+QI7QaLC/4rKSN2OBn/3C3cmOQ/fffZy0NdG0dDnyHdIkuYyHGox v7PSppjq7MuPiB1sWepxOamDkZosu+uhls4qDhCx10bEYXzjxNXqfIOnjr+iLRUi4OfL JAd4BrAP3bt3jhwHi8dP0o/DqfkmQr+CflM9PZ5Vq8DODxfmjdNc6nf+U78UEkkDNNgm 2QeCoku0INurif9YOJbzXzHN7yUywsJz2RcK4hty66vfso6haffGsbZpEGG1ZE422PQb exrRwC/v6L2uErWsB5C4GRivZdfhumqbVCThkUIq16mLQsmPhj2UA1Q54VO8LRp0GaI0 /S2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776682559; x=1777287359; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=86QtRyfODNt78/15/vwrG7dKY8dGMsIZ3LKVUkBa3Dc=; b=ewTCb35TMGQxsyTi4I2sQpFvxFShVfjuiYw7aG8xMKubVfZYS1gX+ldN5WOKeAVLnX WXvjo6689CGmn0+Eft99zItRTbxWcP63DHuu3B8J2fm4ZqmWsQidsKxdyr8A/6dbZRux EpnFOZNWbEiD1RbpaSFy5mZVInDdKuGLJg1RehgDHqVG8RExh1Xr+4tNcNBb2GIbIhbY n4P9GtKPo8YhHiZO5mNpS1nfzdbpHux1Yi5afIja1osfks4tMYKtMqGEWVk5W5ZAQOxU nkapz4vdb9NRmZgF211sYujFOk9u+42GJmfY0WeCXqmTA++lu591sFJJfONOvYiNOY7r q2IQ== X-Gm-Message-State: AOJu0Yx8VAl/zXqMUpMiYIsnERfQyW5x2GkOE06xsQW4n4Fgie4uGSwC sdJNeiddqtRFlKAoW2Dos1r64O/Fx/6XwS9kibaGKCl+KXqdhVCzI+2WbzeoYRDt X-Gm-Gg: AeBDietfU3vFG7LFwp1yTboxwiGDXMOS5ODuu35ps1rmWDYWyGFbKhrah1ywp8VZvxd aOgHMPkypu3V8kBhG8UGf++A9/atMva0oateVzlhM+pI2Sm8hYy1Rh+tnnTWxK4G8vZ5wBSPLZo lmbRiktziDWd3smvOBsS4EIQki38TvRm6YPxtsdmEE8lBZdalBZ62MGmOz7KaH5I1iKxGC3GdWb n1ch+8+909hJu9WFvY+k9VQLluKUlOrKXnrv1ca7UsIbMCTGxavpYOL6BmtIZj69A5GpZSs1n7R zvrxAGSibY/QSOnHhpt+9SWB3Bpi1ftFl+/VAGuj1NMJhupp5zk623sbClIwKveRfpuQWeuSDQn 08QKx/jzh+2tpVa3eRAALFi+NnheX0e3U5M321e3wffE6ohzrUc78q2cGilHAE20W4eDS1uSKVv k9zCA9wmocCCcV07+xO8jN991p5ilB5ElOCqMzqdE4UCU9melFLajzDGl0SvD7oWNstqS6ubdzP JWDrzGweJXf0JbpLdjWwt3/ZeMajB8= X-Received: by 2002:a05:6a00:181b:b0:824:b304:2d1e with SMTP id d2e1a72fcca58-82f8b389d04mr12288256b3a.8.1776682559260; Mon, 20 Apr 2026 03:55:59 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.125]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ec06cbfsm12227889b3a.58.2026.04.20.03.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 03:55:58 -0700 (PDT) From: Felix Gu Date: Mon, 20 Apr 2026 18:55:55 +0800 Subject: [PATCH] pinctrl: pinconf-generic: fix properties bitmap leak in parse_fw_cfg() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260420-pinconf-v1-1-82f8276d8aec@gmail.com> X-B4-Tracking: v=1; b=H4sIADoG5mkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDEyMD3YLMvOT8vDTdtFRDC0uTxGQDo8RkJaDqgqLUtMwKsEnRsbW1AOW jILdZAAAA X-Change-ID: 20260420-pinconf-fe1894ac02ac To: Linus Walleij , Conor Dooley Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776682557; l=1640; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=A1WSNvZBH7Gl27blE0SBf08sIf2c8iIjtoiwnzlc7uU=; b=4KG3p0Phbq/joYNJzNNSAXc7vV/V3sEXN3+vnu2zRTfQmR2eDxVA4yNT4p/ETdVhM12Xwlmww PhEA3EdTXZ8AvyBc47tS9XL/nhySJYHqz7zo+yMuXlKamMJK2eGgLgF X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In parse_fw_cfg(), if fwnode_property_match_property_string() fails with -ENOENT, the code returns directly and leaks the bitmap. Use __free(bitmap) for automatic cleanup to fix the leak. Fixes: 9c105255108b ("pinctrl: pinconf-generic: perform basic checks on pincfg properties") Signed-off-by: Felix Gu --- drivers/pinctrl/pinconf-generic.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c index 64ed28309788..077149121628 100644 --- a/drivers/pinctrl/pinconf-generic.c +++ b/drivers/pinctrl/pinconf-generic.c @@ -225,10 +225,9 @@ static int parse_fw_cfg(struct fwnode_handle *fwnode, unsigned int count, unsigned long *cfg, unsigned int *ncfg) { - unsigned long *properties; int i, test; - properties = bitmap_zalloc(count, GFP_KERNEL); + unsigned long *properties __free(bitmap) = bitmap_zalloc(count, GFP_KERNEL); for (i = 0; i < count; i++) { u32 val; @@ -263,7 +262,6 @@ static int parse_fw_cfg(struct fwnode_handle *fwnode, if (ret) { pr_err("%pfw: conflicting setting detected for %s\n", fwnode, par->property); - bitmap_free(properties); return -EINVAL; } } @@ -295,7 +293,6 @@ static int parse_fw_cfg(struct fwnode_handle *fwnode, pr_err("%pfw: cannot have multiple drive configurations\n", fwnode); - bitmap_free(properties); return 0; } --- base-commit: c7275b05bc428c7373d97aa2da02d3a7fa6b9f66 change-id: 20260420-pinconf-fe1894ac02ac Best regards, -- Felix Gu