From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDD6737B033; Mon, 27 Apr 2026 14:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777301024; cv=none; b=lXtJiG7unlc0D/b8c785tST8/S6CHgrKbYUAHc7+Kq7pLPiBo5AWn/Qw4w/Rokc2vCA/FovQNGdPODkDBRzhfKvUNX95VktJdGgCljoCqK2exT/D0Aypvbn6+lOwRGXUgQ/H40L5t5xMvS+hDEiurzR567G9v+w1gqAdMtKZ/Gc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777301024; c=relaxed/simple; bh=BDpvtcWKS1jt59tEm7D9HL+3Jofqortm0TkjwNkILqo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=FyMb+yzjSVPMEyrPPP2dEw2hAfu+W4JwGh71g+3n9B750Z0wxp+fs8ip31S0JWASW2neOEBvlJwsdBQybH5/sd42AztDz1yRq7bkPURQY0iZBJ1gpFoAshd3hbx2W9Up3XKvO501bQpNPt3ycm7nEO726R3jc9Z27rhcFwuh+Iw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DcGCs3CX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DcGCs3CX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB7C9C2BCB7; Mon, 27 Apr 2026 14:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777301024; bh=BDpvtcWKS1jt59tEm7D9HL+3Jofqortm0TkjwNkILqo=; h=From:To:Cc:Subject:Date:From; b=DcGCs3CXM7Tws5OEmsIaAtTxjy5iORbz8iCtZ/i8ov4lUyqPVTmx5drIZbcrxPhlY FvZx6i21Berg27fR5cHrek2qcXtN/vTKJ/8jX98c5H9ORFad+0PeBZyG3qq3D3/AXr SwNix4uaeYum5G0yREY0B74kUqnqzguh7lDTxBFOGf5NuVkOTS01pC5If4MyrjtY0L jCxcZ1rdoi85mqqpK4d2malr0E+g1vgOIVTRV9YIfzvqQpRbPraU2XGVMlcJZ29Smv ehr3W5Vr1W2CHz0Mgh/2s/miD6EjgFery9qn0S2mA1eJsGxkDf0Yf3UQelgqvhTqAg wsN9oik70+LGw== From: Arnd Bergmann To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski Cc: Arnd Bergmann , "H. Peter Anvin" , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [PATCH] x86/olpc: select GPIOLIB_LEGACY Date: Mon, 27 Apr 2026 16:43:05 +0200 Message-Id: <20260427144338.3436940-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann The OLPC GPIO controller sets up a fixed number space that is used by at least two drivers: arch/x86/platform/olpc/olpc-xo1-sci.c: In function 'setup_ec_sci': arch/x86/platform/olpc/olpc-xo1-sci.c:358:13: error: implicit declaration of function 'gpio_request' [-Wimplicit-function-declaration] 358 | r = gpio_request(OLPC_GPIO_ECSCI, "OLPC-ECSCI"); | ^~~~~~~~~~~~ sound/pci/cs5535audio/cs5535audio_olpc.c: In function 'olpc_analog_input': sound/pci/cs5535audio/cs5535audio_olpc.c:41:9: error: implicit declaration of function 'gpio_set_value'; did you mean 'gpiod_set_value'? [-Wimplicit-function-declaration] 41 | gpio_set_value(OLPC_GPIO_MIC_AC, on); Select CONFIG_GPIOLIB_LEGACY for this platform and make sure the sound driver portion cannot be compiled without this. Acked-by: Borislav Petkov (AMD) Signed-off-by: Arnd Bergmann --- arch/x86/Kconfig | 1 + sound/pci/Kconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index f3f7cb01d69d..5ada2c108f4a 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -3022,6 +3022,7 @@ config OLPC bool "One Laptop Per Child support" depends on !X86_PAE select GPIOLIB + select GPIOLIB_LEGACY select OF select OF_PROMTREE select IRQ_DOMAIN diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig index e0996a9d90b0..6366f72b3667 100644 --- a/sound/pci/Kconfig +++ b/sound/pci/Kconfig @@ -300,6 +300,7 @@ config SND_CS5535AUDIO tristate "CS5535/CS5536 Audio" depends on X86_32 || MIPS || COMPILE_TEST depends on HAS_IOPORT + depends on GPIOLIB_LEGACY || !OLPC select SND_PCM select SND_AC97_CODEC help -- 2.39.5