From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 367413358B6 for ; Thu, 30 Apr 2026 05:54:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777528480; cv=none; b=lBue71fnKv4HO09fbvFujS1eNBMI4UAbD/zhwB2s/SGeExS7f6q7miiWaeMH3GVZdwGV9MXvdU6e9oVMF/5yd4AJf87CEi/iUllwpqVdnubQmnJ3rkZ1bVpoLQ1Ow73zfFfRvyB4W4go+z2E2cEHwvMFOHpr10YHqC1CwlPqHo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777528480; c=relaxed/simple; bh=BpJgaliSBx+fohZC+GCBnwXiaNlDF3bUebjJWarb3lM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=WXFinQ/17yyAGB71gC8s2CaZNR8hnQpbk9n6/Jxlrbc1tdjvI9Vy15hcoJG7KuUCy+ZLGY15yEIdj1lflzVZDnmFA5pt+ji+xiOrYh+3I5H5bW59FN22hdwO6VeDLTM1wAUTI+bbtibrlGZ/mEVqVFDuhnYQEA6G3i3GEkkgMmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YsD07KxO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VMQb29MZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YsD07KxO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VMQb29MZ" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63U3HBLO3729421 for ; Thu, 30 Apr 2026 05:54:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=LRDx2hiugsE5taRYICgVuQ HfUVZXUoQKUB8tQDrNhNo=; b=YsD07KxOosc0UkbwqQea2k1VHrUi4Wc5Zbuezf CAhFtinwlY9qupVQE+h58dfgFFT7K1EoZjAXNALsV3/T61cBbsx7EYss3gQtIHOI fQPrdKsDaT/2HSi5toaUq5IOoZOQtqlq4vbQjRjKvWMbVA9HsDOfgZuPW2lfxENf D7sluI8ZohlKM0/PATbz98hEzIDFk6zKYtLDnFQ8U3QCT9ymObXe0qkA0kqK3Z7U +KS18tdMN16cmLBJLvGsn3cgzYcdlIXIdgJL8KKCUgIC8/O+DuYCX/gqHvZhsVhf qywxyPEDXyU0r8ba7fmqnbwqSKXPQcxu7mEM6OCgEp18pzjQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4duy1w8e83-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Apr 2026 05:54:38 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c7993b17335so210345a12.0 for ; Wed, 29 Apr 2026 22:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777528478; x=1778133278; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=LRDx2hiugsE5taRYICgVuQHfUVZXUoQKUB8tQDrNhNo=; b=VMQb29MZIDiyICXwAFNMsnDF/x7cXkOxwn+cXELm6R/2nmNJxNgtO1rwUh+0ebCvVL 7scIuR/1UQqMNLDY3AVnb++ccJp38qrnFmvbS5UqwDhcXGwFuIuglphpvzbbFG0ecnUk Znzf2h0fR2P3UhMp8cnz4UrQNQ4+KEOa1pO7SpgE3Xno9TCT4fVu56MN9FF3uue4KWyh KuqnykURAKDk/M7pwcY9jYDw7OiB/tttEsUAjzk+ZzrMA6tUnUpJiLZCdfqdRmx8A0vx Q5Xwj5Z2trW3KKBM/Iwsu/FTqDcS1mr2h1AyZMAk3k6mGiYDunIplv02D3X/sOQmfyoY L6jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777528478; x=1778133278; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LRDx2hiugsE5taRYICgVuQHfUVZXUoQKUB8tQDrNhNo=; b=Efp9/yJ3AZIiZy+y5EXEFuzAZ74Xb8arixOjoYTINRnGEO1VeRx02bymtfR9nrKiMc hPzQcbaKr9Q0ojkagFwM95VjyKv1cqhPZW8i/oAhmOGMe9P/S7tGS03evkxNJfip8RM1 3KDtX/O+HBT+csbJ8KK+nvkh+xXYPI6ERVHxFC5650RkO8NLJWw2nuSGHGuBxkqNjfh6 9r6C/kBbdNnCvBbb1tPed1RsaqDQqvo+ZfKI1VMthIpSwX2dB6QxpejOAsb8idUuxHce JxUWpUFHrbv67l6TJEkW25dREW9SKhqF0+551uCeQZSAU4TwnSkFv4TWf1GCF8TIxj8j +KSQ== X-Forwarded-Encrypted: i=1; AFNElJ/D79LDfcmHWZnUl/7icd/3075hVmgAzqGgxouA/BZrbgoy/ALo1pEp1tn9cniVuLTem0baDRcfn5zA@vger.kernel.org X-Gm-Message-State: AOJu0YzEwM+tjpIYTYwDmTwh+Tlpe42nQWuISAD+Do7+iJ9T9GKi7ju/ AyB1OFqnwHikm1k2DkFaTN7JcD2EkZC6sNb377sDgE7jfdjgWzt/2CFB3yPGirfonvENwURbaEU +z2ZvJMxMlvMCVHisckK2KtMoMThFVk4Z9UtSW1k5J7dT2/XGuEecNxKzYlDP1Rj0NqATHnAw X-Gm-Gg: AeBDietFhORvY/Zv4qNb0wacoxlAaU9JOCwde6F7H4ESfZFHbkP/uX37aZj4KdjpID5 CXMbxLG67dL2t/iktc6PB/P/SwX6Q4rCceBodZWOFvM578WC52pgPmTRt+sIaD/SNT1uhTZxV5n X2Li170hnO/7+CeSme0djWjTArdsZpr+6x36r/tq5LI2Eif3KeoJo5LP+crkQZacpZXM4uVQ0EC MMksJVQ3oFCbk4CII6KkE2TByyCsxFwdatjaQKt/o7D90uMKxWbtE+yDQMiJdiSKBZJWLFKI+Er WQKDkmizmhKOYIMWhHZsKqXuj+jYZfbSFzuFKL7rFowSq9J+0dmyOmXgK+aRLC9m/PTlSLqi0st A+JRBJX1K4qAcjb5EzNWVTn5Ujv4w+jAKACcB81J1JXfIUmq0HPX13sX6TlP6HA== X-Received: by 2002:a05:6a20:7291:b0:398:abe1:eaac with SMTP id adf61e73a8af0-3a3cf78d1f4mr1736538637.27.1777528477638; Wed, 29 Apr 2026 22:54:37 -0700 (PDT) X-Received: by 2002:a05:6a20:7291:b0:398:abe1:eaac with SMTP id adf61e73a8af0-3a3cf78d1f4mr1736503637.27.1777528477176; Wed, 29 Apr 2026 22:54:37 -0700 (PDT) Received: from hu-smankad-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7fd5e6c682sm3914516a12.1.2026.04.29.22.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 22:54:36 -0700 (PDT) From: Sneh Mankad Date: Thu, 30 Apr 2026 11:24:20 +0530 Subject: [PATCH] pinctrl: qcom: Unconditionally mark gpio as wakeup enable Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260430-enable_wakeup_capable_gpios-v1-1-5de39bf06094@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAIvu8mkC/x3MTQqDMBAG0KvIrBtIo/h3lSIyxk8dKjEkaAvi3 Q0u3+adFBEEkdrspIBDomwu4f3KyC7sZigZk8loU+oi1wqOhxX9j7/YfW/ZP5y9bFHZoSnyhlF XlaE0+IBJ/s/+6a7rBquweuFtAAAA X-Change-ID: 20260430-enable_wakeup_capable_gpios-cb9439ae8772 To: Bjorn Andersson , Linus Walleij , Neil Armstrong , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sneh Mankad X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777528473; l=1989; i=sneh.mankad@oss.qualcomm.com; s=20250818; h=from:subject:message-id; bh=BpJgaliSBx+fohZC+GCBnwXiaNlDF3bUebjJWarb3lM=; b=m26lDkjcrLAmhfPzGeQ80LMthG6PD/5pZWiZuoYoco4Ka556NNVcA8ZK6PJK0kiAB7nuM3Cyv znxLFoObgW0AyLGx8YtC4AMjv7nK3zFqKAU6slaui8vBLYZkH2Bu5XV X-Developer-Key: i=sneh.mankad@oss.qualcomm.com; a=ed25519; pk=sv57EGwdcfnp6xJmoBCIT1JFSqWI+gawRHkJWj/T2B0= X-Proofpoint-GUID: GnFQ2XI7kB0A73jzIN3i-VvgPetnAZDM X-Proofpoint-ORIG-GUID: GnFQ2XI7kB0A73jzIN3i-VvgPetnAZDM X-Authority-Analysis: v=2.4 cv=DPy/JSNb c=1 sm=1 tr=0 ts=69f2ee9e cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=9gMZ1K9C5k9pR_rhVsIA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDMwMDA1NSBTYWx0ZWRfX+1qX3tsVd7A6 OTxcR+O7thLJ6113lg9RG1llzUEmrViFn6fNylhr5Odix/9DlkQ95lTV7qWrSGfMY+JptGJ8Knk JEt4Xpz9yR8W2T2nsy4ZH/ndsZcxDAw8XHjHar6wUAuSsIf/Ilv5yAJIijqUYSqH0p/2SNb5yF3 3Azt8I5qD6V8wHrPyekYhq0KKRWP6V+/KQm6ayI4QwKvISZFsGIFZcvOYxzOGZL62PzwXj4nc5R sbF6xtWPfEc7Mvi6/vpaN3RgR6SOaECDULjwl4JEDfjOZwj3NBmLUe+iBvfMCFxozJAViPdc7JR 7XI7zXN+jn2P8SdWgL53FlT7vfLZxUcWTQUqjk2r8BbB0iMj5UqznFd9WtvDO5B0EaiUj2hced2 OC3NeHnsecu3IF5SfgBuARY7hYo62WTquCxoYK8gXNV5jRF2ZE15P1fbVR+2kjGwtZZ7eUAnq/h 8RreX/3NHZFJXFt9T7w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-30_01,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604300055 The wakeup enable bit needs to be set irrespective of the SoC using PDC or MPM as wakeup capable irqchip to allow the GPIO interrupts to be forwarded to parent irqchip. This is set only for PDC irqchip using additional check skip_wake_irqs making it impossible for MPM irqchip to detect the GPIO interrupt during SoC low power mode since for MPM irqchip the skip_wake_irqs is always false. Remove skip_wake_irqs condition when setting wakeup enable bit to allow forwarding GPIO interrupts for SoCs using MPM irqchip too. Fixes: 76b446f5b86e ("pinctrl: qcom: handle intr_target_reg wakeup_present/enable bits") Signed-off-by: Sneh Mankad --- drivers/pinctrl/qcom/pinctrl-msm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c index 45b3a2763eb85405fecdd4770ba3d4ab684563f0..96df8eb8f5d3f3bcfe165ac02a07414e491f1178 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.c +++ b/drivers/pinctrl/qcom/pinctrl-msm.c @@ -1247,7 +1247,7 @@ static int msm_gpio_irq_reqres(struct irq_data *d) * While the name implies only the wakeup event, it's also required for * the interrupt event. */ - if (test_bit(d->hwirq, pctrl->skip_wake_irqs) && g->intr_wakeup_present_bit) { + if (g->intr_wakeup_present_bit) { u32 intr_cfg; raw_spin_lock_irqsave(&pctrl->lock, flags); @@ -1275,7 +1275,7 @@ static void msm_gpio_irq_relres(struct irq_data *d) unsigned long flags; /* Disable the wakeup_enable bit if it has been set in msm_gpio_irq_reqres() */ - if (test_bit(d->hwirq, pctrl->skip_wake_irqs) && g->intr_wakeup_present_bit) { + if (g->intr_wakeup_present_bit) { u32 intr_cfg; raw_spin_lock_irqsave(&pctrl->lock, flags); --- base-commit: b4e07588e743c989499ca24d49e752c074924a9a change-id: 20260430-enable_wakeup_capable_gpios-cb9439ae8772 Best regards, -- Sneh Mankad