Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Zhang Xiaolei <zxl434815272@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: brgl@kernel.org, warthog618@gmail.com,
	linux-kernel@vger.kernel.org,
	Zhang Xiaolei <zxl434815272@gmail.com>
Subject: [PATCH v2 1/3] tools: gpio: use strscpy() for consumer name
Date: Mon,  4 May 2026 15:50:34 +0800	[thread overview]
Message-ID: <20260504075036.12190-1-zxl434815272@gmail.com> (raw)
In-Reply-To: <20260503190016.13439-1-zxl434815272@gmail.com>

Replace strcpy() with strscpy() to avoid potential buffer overflow
when copying the consumer string.

Signed-off-by: Zhang Xiaolei <zxl434815272@gmail.com>
---
 tools/gpio/gpio-utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c
index 4096bcd511d1..176bccfcccb0 100644
--- a/tools/gpio/gpio-utils.c
+++ b/tools/gpio/gpio-utils.c
@@ -82,7 +82,7 @@ int gpiotools_request_line(const char *device_name, unsigned int *lines,
 		req.offsets[i] = lines[i];
 
 	req.config = *config;
-	strcpy(req.consumer, consumer);
+	strcpy(req.consumer, consumer, sizeof(req.consumer));
 	req.num_lines = num_lines;
 
 	ret = ioctl(fd, GPIO_V2_GET_LINE_IOCTL, &req);
-- 
2.34.1


  parent reply	other threads:[~2026-05-04  7:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03 19:00 [PATCH] tools: gpio: fix buffer overflow and add bounds check Zhang Xiaolei
2026-05-03 20:56 ` Maxwell Doose
2026-05-04  5:46   ` 007
2026-05-04  5:55   ` 007
2026-05-04  7:50 ` Zhang Xiaolei [this message]
2026-05-04  7:50   ` [PATCH v2 2/3] tools: gpio: validate arguments in gpiotools_request_line Zhang Xiaolei
2026-05-04 16:13     ` Maxwell Doose
2026-05-07  0:04       ` 007
2026-05-04  7:50   ` [PATCH v2 3/3] tools: gpio: fix ioctl name in error message Zhang Xiaolei
2026-05-04 17:47     ` Maxwell Doose
2026-05-07  0:03       ` 007
2026-05-07  0:41     ` [PATCH v3] " Zhang Xiaolei
2026-05-04 12:45   ` [PATCH v2 1/3] tools: gpio: use strscpy() for consumer name David Laight
2026-05-07  0:02     ` 007

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260504075036.12190-1-zxl434815272@gmail.com \
    --to=zxl434815272@gmail.com \
    --cc=brgl@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox