From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0E5F36EAB0; Fri, 8 May 2026 14:35:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778250918; cv=fail; b=vB0pJS4Ec50YEa3Upc8GU8Q6AEUWZVw/us7KuXS58hzYLLYmR13v0XoKN6vDfJD2YtTZkTUAcb8PtNfYyAms3g6bpLZvIRbCaR/iISIdKdmjZR+TPYVR7sFVsVK56pf5Qge9CWu/Qq2i3IVDYuw69pZq71ouaa7G+tvsvueCmmI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778250918; c=relaxed/simple; bh=jCXmGHurFny81C+nDWKg6bkyMr+gGze93CaokjqYu9w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Abc0DarweH7ERKbcwYhG7C07gh8h7fdVZs6Efao2h4ArdffG9vHiJj29/G0WjHPSFIal3Mvpm+uMPoP2TMvzFyfpJpQZBtIRP6di0JML6SPRn/tL3WCKi+ncbLyMlfuO5KCy9x1oyRZ5qgRS2dDf7SwoHc7wkl7y1RZ2b6I3zyg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=Wr2943qc; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=uf51ltJR; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="Wr2943qc"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="uf51ltJR" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6484qXZu685223; Fri, 8 May 2026 09:35:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=PODMain02222019; bh=fyGK/15lssFJ9wqC AHELfU4IBYhDh+DOdHRfGvbrwgc=; b=Wr2943qcArsAVXCagAHbrbjWomaASxJ5 RSzZjwAVPDDyYqjemTGCXrDKrTH/fpwXAdgKOFeW+hgSuPvQ9m1Mg5oXKmJAoQah 0t7/K60sOoeVFBm80k35VsKgbiQ9j10HUTUrBn/aHJbNFyKMZnwWeHUsRzi/FC0v dLhQDaODCgY6mKszEg1EAi/M3AEJOUoqlzA1p6AZd41nKA/SEPyLDS3ZgxlLuFSu tb12XBJ4hqPwx7kKqUrP8Rl+J272pFCEYN7foHK7JirLligEaByO/9PYzmAMYi2b zOIQKVKijOUAUS2kuY3zK6POVMcWpmvVT8880lNBUWLHJ36yX83F6Q== Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021115.outbound.protection.outlook.com [40.93.194.115]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4e0upb9tvh-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 08 May 2026 09:35:03 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J63uwXoYn7Grzj1HM5XPWTkow4ITvXGRTWolnG8aZZGvuvsiFr8zmiDh1SDNeRWSu0I3HyetSlZSSuhD6i4rWcdVwlQcHkxUsZTYP492BuIn/2dY47tpgv/8h0HgZi80AsOk/tIVk7tfBn/+n8vorBbQsXp/wEyBj29yv656+OHFdX9sOSgJORucleKBGj1w+vM5NqW4aiiS/KjrVrVniRE0r++32QDEveOP5NVExgat4fbfjMo3oCZmC7cgF00RepCYGrNo6hV5xmmnN9SrYnJkrj4N2XdvqUVQCOpLPy7MIyN/Zx2cx64RS+F9w2R4FqXaqiIgsBjxJq+T1KFDUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fyGK/15lssFJ9wqCAHELfU4IBYhDh+DOdHRfGvbrwgc=; b=UGVfdIELyhy5B1l+KozecnjNNNExVVQuSZXYEc6ICzTX+6VSRNsDWu6kgW1QTdYOGgHEDmTHSk4Vce9Xx6yfKzffsj6lnoX3pUeTZcn3mOWtbGAitE1uMXOB4i87vcFzy1uHWgl1D75fHAJkba5wYGiHUCLl3vAx5XLELnyqBr49146eMs9AaFbo5Ra694uW8ZEqRlNDmr27PsqG9WeHfpnmjIOYZKZmlccJrZCHcwBt0euvi5iYDD7rGcsfbXg8Bev0xDk5nAUKdDfWx7+o2IrRb4+zsTbiPUYgx9+siaJY8nHKCuyRVjeuyCaLU85quvzpvuRvxgRcW3REkujdww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fyGK/15lssFJ9wqCAHELfU4IBYhDh+DOdHRfGvbrwgc=; b=uf51ltJRZzxnEKa4IBnex6xXpVBahebAEFvlbFCm/kpu+MP0pstRqUpfRRuGMmtNX+JsFfSh9jKVrOR7JsiVyVNXWH2cFXPTnGkQgADCVpQBgBh+dj1OM9kdN70M2BYTlLzTFq5R9bKjEWYZy5V0ycIpvlP8DoiMvjeFZ95aRt0= Received: from PH5P220CA0002.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:34a::17) by PH8PR19MB6668.namprd19.prod.outlook.com (2603:10b6:510:1c7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.19; Fri, 8 May 2026 14:34:59 +0000 Received: from MW1PEPF0001615F.namprd21.prod.outlook.com (2603:10b6:510:34a:cafe::85) by PH5P220CA0002.outlook.office365.com (2603:10b6:510:34a::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.20 via Frontend Transport; Fri, 8 May 2026 14:34:59 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by MW1PEPF0001615F.mail.protection.outlook.com (10.167.249.90) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.1 via Frontend Transport; Fri, 8 May 2026 14:34:58 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 6305F406555; Fri, 8 May 2026 14:34:56 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 479B682024A; Fri, 8 May 2026 14:34:56 +0000 (UTC) From: Charles Keepax To: linusw@kernel.org Cc: brgl@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 1/2] pinctrl: cs42l43: Fix leaked pm reference on error path Date: Fri, 8 May 2026 15:34:52 +0100 Message-ID: <20260508143453.1886569-1-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW1PEPF0001615F:EE_|PH8PR19MB6668:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 6f16e4db-0cd7-41a6-cda6-08dead0efb22 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|61400799027|36860700016|82310400026|16102099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: kQCuijNeYkz7oNhzdXaUZ6GBOAqdbCNY+3dEJRG5biAoH5XjDESj/NCP1/gswaygmi6CMJxOc2gSaVf58N5kHBanRSmGRVj6RUGBAy9TTT8lT7IckRrTznKrWuheKrJ9KlUsJ1yW/wF/hWJTfANLRRl1rBfYDnFsnQCqILDesJREW8GowH+rbzUuxkECZi41PiMf1FrXEQFmVCMVBiKvuUfQP6ifuYbBdeofsBN47hcVRqYSyIcLcMdloPVjXfdiYaEF45o6zy3pLuHNmhGWeV+xWEHFDtMXYynsswJ7/xjHx76VBDrFO0B2kS92KyhR30Jr3qzNPwcn7U01qAxOfJlpUBk/sBTSRyI5peRSvRYSLQrQQLwiMw6v+EmiCsN0KPWlf2rwcQMirT0HkNl3iD9coLMUeudof7V1PtsNTloKepB/4ep7Swzq+PUU5qy6Qf8PqOIJKA62XLUxKpW1vCTH1/xT1fTSiym7U/vbjfrIiq+5GXfl8QLeVUP+liNnzaEYgQpmQCDTtTJNCWR8BxHrKdR9weinUdVvnRe3PJkVKHgtUZjE3x5QuPLiBupDVdAr7ZOY2MnAhrn8YCdS8PN52heSxh0k1BjKSz61xbeA4jBHnpSoKYiM4jk8xOpikwGZ1gwQ5rS/tdTtaLF7ThgMVEpvZszg+SSaI+ztkDRjj3UXDqhURAz0HE7ivzYT6ulXGx1oce0lwxxjdZF+zCWtIxQ431rr5M3xPP4qVp0= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(61400799027)(36860700016)(82310400026)(16102099003)(18002099003)(56012099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: pI5ncF37B4hhBvjk4TmbyMrIj6KqeUy4up2f7eN6AKFaqsy2sQNlSGSALv6AyokSNwb6oZn0W6bVICVBdwai3jaVsOZMupDs2qfdKHDAU66FHvWMoMoNDkj8jzoQcNqNk0wki3n8ECsZdsG/er6JScS+1BZVO16tOsCH+upcmBNJhgr94o0AjOqtTUULjwMt60DXC5GR/o1aSrg1ubmbaExQUvoS2mRKM67HHCMJFGnyCGsTuHVh6xNMGf8rZQfnZCDrTToS/Yiir0/t7RQD6Uvw3NWUW5xEbIMX2Kx2y8NoNudSjnqV6zM9HvJOtXviAWYAC8xYIi42yNwX3YSvuFamGonQTyJl5PqlzrGbiGHvV9+ldcfQrbpStVLIhtgpoUAdubrC/mz+yXQEJhHIjwcVeoFep+dNeIjqBuDkRRb+fgjx5xwFI1XVUvxRybXj X-Exchange-RoutingPolicyChecked: X8U1XAh78QC+8QGEHNrqDJQtD1tzNJJZpOSlsAhb0466HN3gi68H+UFFDlrzZzpey8wt5fNhNRZsv4ajW23VmvwRXICNtNHFEcwMox7R8td9jD//7ryGZjeC/6ut4lUs1l+oMK4CbTr3Jhk7mCUGX/Jb0jaBX/WEbHyiSZcMbQV5WBX/Ckd2uEMqiGhIWhTAUk/YW+heI72m4hrf9LP9Gr6fGBAkWpKtvZwFIBi1ZvSiUr40kQ7hg8gyzhLvgRYu3ZiHX2hrUfxjGiJFfljJLgYylcrm2COBQlOyLVuZhfoyYAdX8sSoX1Dp7DLGzp/haRGdJqctI9LbsYAK8cOm/g== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 14:34:58.4435 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6f16e4db-0cd7-41a6-cda6-08dead0efb22 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-MW1PEPF0001615F.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR19MB6668 X-Authority-Analysis: v=2.4 cv=L9otheT8 c=1 sm=1 tr=0 ts=69fdf497 cx=c_pps a=oHfrqWki8W1Zk6zcsj6tgA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=NGcC8JguVDcA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=ITwTPoNtF3mdZAw3_0sA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDE1MCBTYWx0ZWRfX06SND1yyxbX1 hfcx+RQQ6aMA3zAebqbcSIJooutRMuoWOTcuEhrSVPm3d6fK3eBp9SpRF1hTFu2xlyzNLCu0Wpn SjxBhZNrIukwvK+k+2h2ljikdjsVVsn6xw4gLQMz47WKTnakLoDhima2yh106DrbwU9bm9tNFfB u9TOF9UC2nJxwPqAqGWz44DHHSw2xLLTZObf7B6Mn5MrU15F85LQxT6q5BRIOrIVbZugzy9lrN1 WuLZN9qRSM03I21F6nrOP79urNWOh+Ch1ZXmVEN/vOP6d9FlrUNbX3AG/iPOWh2uxJLIABTPavB PZ/JD6qPFWVtsgD2pIwBySOA64AhqC2n+VM4FhOUs/gQj+6iYs4p37nFRRt22hYbeU027rJWv07 jf40dmy/i80o80hg6If0bKLvOTnlNqyIaQ1LKbXqRZD8qY9WUDw7EacFnVZt+dvyCZ3lFPj9ASK pWSKAaQVCHVOIOJ8oYQ== X-Proofpoint-GUID: yUJ9-ZTmdKm8t_d-MOBkS7nDr-3uyYUe X-Proofpoint-ORIG-GUID: yUJ9-ZTmdKm8t_d-MOBkS7nDr-3uyYUe X-Proofpoint-Spam-Reason: safe Returning directly if the regmap_update_bits() fails causes a pm runtime reference to be leaked, let things run to the end of the function instead. Fixes: e52c741907fb ("pinctrl: cirrus: cs42l43: use new GPIO line value setter callbacks") Signed-off-by: Charles Keepax --- drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c index 227c37c360e19..3cc1835206077 100644 --- a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c +++ b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c @@ -499,12 +499,10 @@ static int cs42l43_gpio_set(struct gpio_chip *chip, unsigned int offset, ret = regmap_update_bits(priv->regmap, CS42L43_GPIO_CTRL1, BIT(shift), value << shift); - if (ret) - return ret; pm_runtime_put(priv->dev); - return 0; + return ret; } static int cs42l43_gpio_direction_out(struct gpio_chip *chip, -- 2.47.3