From: Conor Dooley <conor@kernel.org>
To: linusw@kernel.org
Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>,
Frank Li <Frank.Li@nxp.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1] pinctrl: fix signature of extract pinctrl_generic_to_map() in nop case
Date: Thu, 14 May 2026 21:01:27 +0100 [thread overview]
Message-ID: <20260514-slum-sprinkler-8f858eb81faf@spud> (raw)
From: Conor Dooley <conor.dooley@microchip.com>
The signature of extract pinctrl_generic_to_map() is incorrect when
CONFIG_GENERIC_PINCTRL and CONFIG_OF are not enabled. Probably a
hangover from an earlier revision of the patchset that was not updated
that went undetected given it depends on OF being disabled.
Fixes: aaaf31be04260 ("pinctrl: extract pinctrl_generic_to_map() from pinctrl_generic_pins_function_dt_node_to_map()")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
CC: Linus Walleij <linusw@kernel.org>
CC: Frank Li <Frank.Li@nxp.com>
CC: Conor Dooley <conor.dooley@microchip.com>
CC: linux-gpio@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
drivers/pinctrl/pinconf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinconf.h b/drivers/pinctrl/pinconf.h
index fa8fb0d290d1d..9711d16c38b62 100644
--- a/drivers/pinctrl/pinconf.h
+++ b/drivers/pinctrl/pinconf.h
@@ -195,7 +195,7 @@ pinctrl_generic_to_map(struct pinctrl_dev *pctldev, struct device_node *parent,
unsigned int *num_maps, unsigned int *num_reserved_maps,
const char **group_name, unsigned int ngroups,
const char **functions, unsigned int *pins,
- void *function_data)
+ unsigned int npins)
{
return -ENOTSUPP;
}
--
2.53.0
next reply other threads:[~2026-05-14 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 20:01 Conor Dooley [this message]
2026-05-14 21:08 ` [PATCH v1] pinctrl: fix signature of extract pinctrl_generic_to_map() in nop case Frank Li
2026-05-14 21:17 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514-slum-sprinkler-8f858eb81faf@spud \
--to=conor@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor.dooley@microchip.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox