From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29B2738E5EF; Thu, 18 Jun 2026 08:18:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781770726; cv=none; b=l4LehJfiFjsoTFPrFhvLIs2/5a8YLUFdGzAX3GmoYVPFP5aClY7gvXH15+hC43142f3kKtrgOBPAZhdfvL9dUjIsmH9X9fEUnoh/81P5thJiTgIRbYtaXkcUYz2a+9OUmQJJYJZjk+wRi6Ob5+l2RAjdOFJ61RArCU2hAy9DmTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781770726; c=relaxed/simple; bh=QWZAgUG33sDVoOYvsZHlVsv36qxjPW2xLkggJ9D40hM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n+vYC9FOSp7vD6oZMDJCAPJ2rDdd7CkJZT5O5BiGNq6kroLWLo9XVFgCQEqorlWskGZ16gFmfF/GN+yJPHUhjI/IRdC1MkUTiAc1gRCoUAkwlGz/S6sXFduiflqNkT0z5iClKWW2peDGxdNQ8vjqJCLTSRfoKykhMO+RyfBgYuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=bgpoXraC; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=+PAOCBZ6; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="bgpoXraC"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="+PAOCBZ6" Date: Thu, 18 Jun 2026 10:18:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1781770722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=esNCyoPGjThitgO/ONZd6FII4CTw4WW+HhHMD7dROhE=; b=bgpoXraCqEcTq/A1VHEfomvk7NjTwbH52o92fLD0lTRIqkRAEopghmZJIgYaX0rO7SRcfP 7N5y3xITSWfAigN+yUpqrRZltUGQ1uXFo0VCAE4MpRuwjpuFNGqbNhpqqT05W1YdAzdTz1 Z3px8lS1RoJE4mx/3/KQMc5YyJEVhtJ56cu6g6FErAW6i6ob53ydVsGq/0obmxAJ9WcxCk m+7RjQ3eKdovQ6vN299Awepf22cjql56wSwGk+KLZBoShc/lAPryI8WLmwPtDbebw8J8Tl uf8lUIg3Nffr1bn9h+yDo69xFLqd/O05CynGpM42SCnQP9XqN9v2fXMHqC2E/w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1781770722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=esNCyoPGjThitgO/ONZd6FII4CTw4WW+HhHMD7dROhE=; b=+PAOCBZ6krTyj3cKO28sUF+z9qnobDQbrowNq7D7oCQD31FisaxSCZhWTNTc4azTwf3SM6 LVas/zdYRlOgSpDg== From: Sebastian Andrzej Siewior To: Andy Shevchenko Cc: Runyu Xiao , Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Clark Williams , Steven Rostedt , Jan Kiszka , linux-gpio@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn, stable@vger.kernel.org Subject: Re: [PATCH 1/2] gpio: sch: use raw_spinlock_t in the irq startup path Message-ID: <20260618081841.QBWh0eV5@linutronix.de> References: <20260617154035.1199948-1-runyu.xiao@seu.edu.cn> <20260617154035.1199948-2-runyu.xiao@seu.edu.cn> <20260618062839.4o1ewdEn@linutronix.de> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: On 2026-06-18 09:41:50 [+0300], Andy Shevchenko wrote: > On Thu, Jun 18, 2026 at 09:40:31AM +0300, Andy Shevchenko wrote: > > On Thu, Jun 18, 2026 at 08:28:39AM +0200, Sebastian Andrzej Siewior wro= te: > > > On 2026-06-17 23:40:34 [+0800], Runyu Xiao wrote: > > > > sch_irq_unmask() enables the GPIO IRQ and then updates the controll= er > > > > state through sch_irq_mask_unmask(), which takes sch->lock with > > > > spin_lock_irqsave(). The callback can be reached from irq_startup() > > > > while setting up a requested IRQ. That path is not sleepable, but = on > > > > PREEMPT_RT a regular spinlock_t becomes a sleeping lock. > =E2=80=A6 > > > > Fixes: 7a81638485c1 ("gpio: sch: Add edge event support") > > > > Cc: stable@vger.kernel.org > > > > Signed-off-by: Runyu Xiao > > >=20 > > > Reviewed-by: Sebastian Andrzej Siewior > >=20 > > There is already a v2. >=20 > Or not... I might have been confused with other patch that got two versio= ns > in a row. I am catching up so I wouldn't be surprised ;) And it is entirely possible that sashiko came up with the pre-existing condition worth fixing ;) Sebastian