From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2473E397692 for ; Sat, 20 Jun 2026 15:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781970807; cv=none; b=F5s/2EHZMy3cg8x9MIhDjjkldyhuei0cN9nlK39gE34KSeRXmvVyl7FhicFbldv6X03IOPC/mxDXlC0G/7CiesZ8hUjVwVrt8Zs/cQtziuLlPUZNoSQj7wJD/WHnhheYjpha7RK0c/gOZZ5YOosT5xAEuFahDIsaP2uf0bPhIl4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781970807; c=relaxed/simple; bh=DlgWLEzGgG0nUyN9ICtW/q8163w7vFFOvs9xVKURyBo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UarYbQ2AMPpSmSwuhbcUGfKe5YJD6qDUrog/J8k/xCqO0SkG0fenn2/gYE5/eDeE/BW64K979Ur0lkaoYEn1RmGBRWXaYkdV/PSst+MTZ9rCjv106S8Ip/RDzsxhg9cCWD6cA3pVLKzbKPT8jB/IvgWG7y8NZnJg4xMf6ka89D4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PF7bCSmS; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PF7bCSmS" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2c6c57c5bcfso25642655ad.1 for ; Sat, 20 Jun 2026 08:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781970805; x=1782575605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=99ux+NmuUXucZal6I4fcMAQAAFgyJ7Vb7HpRZz/S0uk=; b=PF7bCSmSV2CZvnExFontBouG8n2GZkngd7/UWYRnwsbmc5k/Xv0JV4DoKWzIljUAS7 prwisRt3UPjcBpai2nHL0CV4SJCMNYmDwV5foWR6nZLN88hmOUu840+oodqo/mcoqngV Aqdq0YUnQdETMzTSGIJ1GL+yIrX5IT/SbTUZXhPM1JIQz0h0ZaVM8LvfO8AaqC7DNlSm 5zfQG63w604+UUOJrAGirEuzVB5Q8QYaPZkTJlIOUf6uhmjI3xLHO/FRyJCSmX6yencG LI+jV0xsURJtoP+gZZN2O1/Kx5bT+SvZT/s8xrW7pUvXyPxP6nh22zBX2TpHLWfV9yPN lrxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781970805; x=1782575605; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=99ux+NmuUXucZal6I4fcMAQAAFgyJ7Vb7HpRZz/S0uk=; b=aYD6eVpJ4nOmnprGjsTg90G2Noi8JGIVOpUIrwO5bCy+m8BLlhxNKn29BuGbozwdLs VSSP7QEti4IT/TR6bGABnmgxeI6ExNRLGMep8ncxjA8U4lmJdfzSNsw56I+F3S30b+1L oywdhfR5+2qk+mIIezdN4BeAqQ6YE369qRzkgBhQIIeumxbVlJGTRwgMjbXsfmOGvEpG 9z9SrWCM2KLcagRaBaOwuQlGiSr8drZZw+UVaFicNv25mU+zWJJuZxJqNivnoGg9tGsS 7tQMu23xuPUPn8nIr2YNMJX/TJAUzluSMk8V+eEIWzlWi6xCxQAy1S/SFtjlH25bVs5j Wr4Q== X-Gm-Message-State: AOJu0Yyd+5KU9GprkXoO3QziriQtTab0PET6K7rLhXm8dm3PZTeiBCu9 Jhfnv0BPmrZyTd54ySK2NwEuBBdBYaORE5vl5rqGCHYTxvkjHc2UPKM9 X-Gm-Gg: AfdE7clC1y924KCMB+/d9tzLNxt3+e5mzBy7B/0++rbUZYniequcCXHtKDkIgFR+pgQ lzvvFrMezHtuDxEwWS9YQJJr5d7cYmZDXIyqUhUdYY5tzd7L7xfab7THtuiieaOEDylkfIq2L6x U54YGC46g35AvsCFoEnCAPlXzRg6dTRBOIJnUyHp6r5CNS/1GQq5AYVarnG4hhZ1Y5N7x8Cy0vk ibtizN5kvdRH6UQ4Mwcxcf/mUTBfWLTZ9V8Dnfdu4xPW+hOrufWpjI1i4ZEu86WL5SBKBUTyroq 83or5+NufP5SC9ndU4ajNHvlG+uOXF8T7zOnmWU3jLYR7GFCA73DBXZOvZLam/D7HSdZ+eIADj7 9iXCTAwn19Dp+70iTOuBo7HH5MRn1ejQli3EYlIhd5vfgJzeNIM5W1Lx7fLiZKW/thOKt+fd3l+ V5eUvjGrdkanKqJdps7cbcHPCGtLYEbJ8gkZOsZ4dqbZs= X-Received: by 2002:a17:902:f688:b0:2c1:f262:494d with SMTP id d9443c01a7336-2c718f622d4mr84491185ad.19.1781970805414; Sat, 20 Jun 2026 08:53:25 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:8e0e:956e:b09c:23cd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c743bfdcb6sm26221285ad.57.2026.06.20.08.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2026 08:53:24 -0700 (PDT) From: Ruoyu Wang To: Linus Walleij , Bartosz Golaszewski , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] gpiolib: initialize return value in gpiochip_set_multiple() Date: Sat, 20 Jun 2026 23:53:19 +0800 Message-ID: <20260620155319.79994-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit gpiochip_set_multiple() falls back to setting lines one by one when the chip does not provide set_multiple(). If the fallback path receives an empty mask, the loop is skipped and ret is returned without being initialized. Initialize ret to 0 so an empty mask is treated as a successful no-op. Fixes: 9b407312755f ("gpiolib: rework the wrapper around gpio_chip::set_multiple()") Signed-off-by: Ruoyu Wang --- drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 1e6dce430dca..cd2a619da456 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3778,7 +3778,7 @@ static int gpiochip_set_multiple(struct gpio_chip *gc, unsigned long *mask, unsigned long *bits) { unsigned int i; - int ret; + int ret = 0; lockdep_assert_held(&gc->gpiodev->srcu);