From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>
Subject: [PATCH 24/32] drivers/gpio: Stop using 32-bit MSR interfaces
Date: Mon, 29 Jun 2026 08:05:15 +0200 [thread overview]
Message-ID: <20260629060526.3638272-25-jgross@suse.com> (raw)
In-Reply-To: <20260629060526.3638272-1-jgross@suse.com>
The 32-bit MSR interfaces rdmsr() and wrmsr() are planned to be
removed. Use the related 64-bit variants instead.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
drivers/gpio/gpio-cs5535.c | 10 +++++-----
include/linux/cs5535.h | 10 +++++-----
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio-cs5535.c b/drivers/gpio/gpio-cs5535.c
index 5f5373d86397..a97ec7561889 100644
--- a/drivers/gpio/gpio-cs5535.c
+++ b/drivers/gpio/gpio-cs5535.c
@@ -143,17 +143,17 @@ EXPORT_SYMBOL_GPL(cs5535_gpio_isset);
int cs5535_gpio_set_irq(unsigned group, unsigned irq)
{
- uint32_t lo, hi;
+ struct msr val;
if (group > 7 || irq > 15)
return -EINVAL;
- rdmsr(MSR_PIC_ZSEL_HIGH, lo, hi);
+ rdmsrq(MSR_PIC_ZSEL_HIGH, val.q);
- lo &= ~(0xF << (group * 4));
- lo |= (irq & 0xF) << (group * 4);
+ val.l &= ~(0xF << (group * 4));
+ val.l |= (irq & 0xF) << (group * 4);
- wrmsr(MSR_PIC_ZSEL_HIGH, lo, hi);
+ wrmsrq(MSR_PIC_ZSEL_HIGH, val.q);
return 0;
}
EXPORT_SYMBOL_GPL(cs5535_gpio_set_irq);
diff --git a/include/linux/cs5535.h b/include/linux/cs5535.h
index 2be1120174eb..5ec2aca537bb 100644
--- a/include/linux/cs5535.h
+++ b/include/linux/cs5535.h
@@ -49,12 +49,12 @@
static inline int cs5535_pic_unreqz_select_high(unsigned int group,
unsigned int irq)
{
- uint32_t lo, hi;
+ struct msr val;
- rdmsr(MSR_PIC_ZSEL_HIGH, lo, hi);
- lo &= ~(0xF << (group * 4));
- lo |= (irq & 0xF) << (group * 4);
- wrmsr(MSR_PIC_ZSEL_HIGH, lo, hi);
+ rdmsrq(MSR_PIC_ZSEL_HIGH, val.q);
+ val.l &= ~(0xF << (group * 4));
+ val.l |= (irq & 0xF) << (group * 4);
+ wrmsrq(MSR_PIC_ZSEL_HIGH, val.q);
return 0;
}
--
2.54.0
next prev parent reply other threads:[~2026-06-29 6:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 6:04 [PATCH 00/32] x86/msr: Drop 32-bit MSR interfaces Juergen Gross
2026-06-29 6:05 ` Juergen Gross [this message]
2026-06-29 10:33 ` [PATCH 24/32] drivers/gpio: Stop using " Bartosz Golaszewski
2026-06-29 6:05 ` [PATCH 31/32] treewide: convert rdmsrq() from a macro to an inline function Juergen Gross
2026-06-29 6:52 ` [PATCH 00/32] x86/msr: Drop 32-bit MSR interfaces Arnd Bergmann
2026-06-29 7:01 ` Jürgen Groß
2026-06-29 8:06 ` Arnd Bergmann
2026-06-29 8:15 ` Jürgen Groß
2026-06-29 8:38 ` Arnd Bergmann
2026-06-29 11:19 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629060526.3638272-25-jgross@suse.com \
--to=jgross@suse.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox