From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4F3225776; Sun, 12 Jul 2026 01:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783820368; cv=none; b=g++3/WRveQlTlF06/xJ/YmxupX2N6EnhEcCm19Fkq8uN9GNHCwZSqI98LcohK3mZki9J+dRoTTMNUQ6LC5FhxXPOnS6YJ6R6ig0mYwkwFQLqhcm8WlKNIb6fcz8r1TtBABfyneTXUewzNvFG+r6BzE0isLMkVjN+qJ2raHsCpVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783820368; c=relaxed/simple; bh=5oijIS0WvNE8eYZwIxcmNY3efe9YwRaa2Y8G79AVRe4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hRQ3WXjGZhdTgrCKIi2BbWcrMtwbbvL0gmVESLPunpTmeXtMUdjgIRmrI6l8wbIjPt/cgTlueFrnc705Uw+VZgcs6Y7+UhiOkr9njo6Gqse5AIrbks079Ir4xvspU6Z+5dOl/efsgOHI08Pnkb5UJACn9EzYIxOdIoz1y1chVY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MSSyOB44; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MSSyOB44" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B5D31F000E9; Sun, 12 Jul 2026 01:39:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783820367; bh=lx6UIKORYr83MRZW/mBwgJxoSVTHyf6D4qI4x8AJ3uY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=MSSyOB44OPV2UFjmYVfxjl2DA4q93sKXHnTTVQtN2VhXxARW1pUPWQnNCY5J/Ydyr YMorTtU6Q4tml6uVSemegYj879GlJHOjAe9gu0phFMyArDIoPPmxDlRdW3zpqm9e8d s2WTbdFY7Kl3azgO0pOL2H1neZqQ4jbUhAJIEl5E2F5KQyuHe0oKrSdKpNPqg+WUYc /DVSpkQb/Q8B959GDIaYj1sgJVO3iTacGoa3o3aiN5Ng5MQfGGQ75U6NyT7/fLDD1I OAguLeUshgo5S+lVVe4QhI++F5GImTcZmlY9xaDY+JIU+DrIJxzsmtdmIwL+D4gDiJ 9EhZfIfvwTJFA== Date: Sun, 12 Jul 2026 02:39:18 +0100 From: Jonathan Cameron To: David Lechner Cc: Janani Sunil , Nuno =?UTF-8?B?U8Oh?= , Michael Hennerich , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Olivier Moysan , Philipp Zabel , Linus Walleij , Bartosz Golaszewski , Jonathan Corbet , Shuah Khan , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, jananisunil.dev@gmail.com Subject: Re: [PATCH 1/6] dt-bindings: iio: adc: Add AD7768 Message-ID: <20260712023918.119fbecd@jic23-huawei> In-Reply-To: References: <20260709-ad7768-driver-v1-0-44e1194fd96a@analog.com> <20260709-ad7768-driver-v1-1-44e1194fd96a@analog.com> <36df7c4f-82ea-4ed5-a4f9-3a29c75dc99a@baylibre.com> <20260710013322.595f8ee4@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 11 Jul 2026 09:40:32 -0500 David Lechner wrote: > On 7/9/26 7:33 PM, Jonathan Cameron wrote: > >>> + adi,common-mode-output: > >>> + $ref: /schemas/types.yaml#/definitions/string > >>> + enum: > >>> + - avdd-avss-half > >>> + - 1.65V > >>> + - 2.5V > >>> + - 2.14V > >>> + description: > >>> + Common mode voltage output selection. > >> > >> Why not using standard regulator provider bindings for this? > > > > Interesting question. If that was done there would need to be > > a consumer which means explicit modelling of any analog circuit. > > We do that in a few cases but so far (and yup this is a driver thing > > in a dt-binding) I don't think we have any way to consumer data when > > a backend is involved. > > There is also the regulator-always-on property, so strictly speaking, > a consumer is not required. Makes some sense I guess. How would the voltage be controlled? Set min and max to same value? J > > > > >> > >>> + > >>> + adi,vcm-power-down: > >>> + type: boolean > >>> + description: Power down the common mode output buffer > >> > >> Is the buffer separate from the output? In that case I would expect > >> buffer to be in the property name, otherwise this should just be > >> part of the enum options above (and the default one at that). > >> >