From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4720640B10D; Thu, 30 Jul 2026 17:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785431015; cv=none; b=I0jgQKoE3Sb3objCr9ZABEouwXNHygrj8eWuQpkM0cXR8R0c1ydchHSUjdvuTlKsHlssKEy3oWgMmMlW0OwYkOZoURc9jRDG+L48DUKDyeg/CRcjFD6j3chPOeoXuB5d/iONsuAKDvbH9+pl/4LTlouAx9SETX6BXbv/UzSeKYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785431015; c=relaxed/simple; bh=VpZja1y/RWt93PvaU/vvjDYTa3N16DEdAcfC2EAvwxo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MhA8wAJoFM+P/c4Krzm9x36nhAPvHy/wb/C6DaEVcY/ENeDNL24O82Pmq8vHH1uzztCZbVEpb2ZTk/HnFwXJD1LQCmJ5I+XPEgc5mjYnkdnP0oDx9zsyQOGDgAkB2wB4bvu/qrW+/PtyS3/GMpA+yRClwFyBV8k+OAvWUBYjXKw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mFVUyJ0C; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mFVUyJ0C" Received: by smtp.kernel.org (Postfix) with ESMTPS id 1D723C2BD05; Thu, 30 Jul 2026 17:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1785431015; bh=VpZja1y/RWt93PvaU/vvjDYTa3N16DEdAcfC2EAvwxo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=mFVUyJ0CjqT2o6yMwSopsroaYoPmlNbkOKvej7WqsBJf6gR327cEXuVT59hppdTU4 b57ZlR3PkKPad50a7tUq9xYkackEmnzQzyMCz4A9DA6ID6dI5EycoS0sQ6XsJcBkRy ZnD7ipHcOGqKSAj/wWRGkkUPDUkvXWF/Byacgj8rPEzh8oFb1Eqd9Ug1hQWOY+kASK VgNG/tGzU0YiWAwYDGdOrVxJHlY2R2o6ljCxNEQNsChXI1MKkJjiVxjoCxPm7oHMFq VasEieEXGY/QefWsiKBc4xJAWuxrpyi7vm/dRBJyOXs6J/Y+k2PdfljBjb5kxeyRb+ wmAHJX7cUOI/w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AE5EC5516D; Thu, 30 Jul 2026 17:03:35 +0000 (UTC) From: Miao Wang via B4 Relay Date: Fri, 31 Jul 2026 01:03:28 +0800 Subject: [PATCH RFC v4 7/7] mfd: ls2kbmc: Capture the reset event of BMC through GPIO Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260731-ls2kbmc-mod-v4-7-d201502ba239@gmail.com> References: <20260731-ls2kbmc-mod-v4-0-d201502ba239@gmail.com> In-Reply-To: <20260731-ls2kbmc-mod-v4-0-d201502ba239@gmail.com> To: Binbin Zhou , Chong Qiao , Lee Jones , Huacai Chen , Corey Minyard , Linus Walleij , Bartosz Golaszewski Cc: Xi Ruoyao , WANG Xuerui , Yinbo Zhu , Jiaxun Yang , mfd@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, openipmi-developer@lists.sourceforge.net, Miao Wang X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=8716; i=shankerwangmiao@gmail.com; s=20250715; h=from:subject:message-id; bh=QfkEvKpccAhXMfcU20Tm8bG3GeIFkW2sEnGcMzWjRlY=; b=owEBbQKS/ZANAwAKAbAx48p7/tluAcsmYgBqa4PkmD51mUNBJJWhRL4wywQjQpGCoG+1l5sI6 8omfSQw1piJAjMEAAEKAB0WIQREqPWPgPJBxluezBOwMePKe/7ZbgUCamuD5AAKCRCwMePKe/7Z bjsqD/0QUw+M4X7bZ+LGPbNFLMdsA4G+eyq9aJdxf7vTZP1/daW5dW1Utpp19v8Ncl2fqeU0awS DlvbNMHuFSY4qhc1B9VTIaStuqecoYXqXjWanVVGLtM9d20DSwUXccQUC/yabuJJIpGXS2/MTws TA1fLpV+VdK4xdtSYqrcwdEKr4oj2Npv7QqyRhEYj+xlJx7VLPusJ+LnZ0U+3xB7EN5PvVfI3rJ 0KVzlNhfLkRpQXJ5TthsFziDjHb2qzwuS2NwKx8aI1kj6M7h2cO+RwqgjYHdizcURQDxm+1zqjY 0dXM10T88Itc4tEnPFWTbQT/nh37xyjHhmRQ8DtXOS2ts3kaQ+1jQQaLvIfoOq1l20/bNAuAp8C dFYrXzmnx0stRCc13IR6Umj+a3vBhe65NOBAT1aHjxCgZeXPQvzd+ZsZeCxDOwvW15FyJ+ZuQgq hNvOY0FSxtW7gNvpr+q8guV4YyhR4JlV0KlO8+Ppw6wlBou4OxecyDbDfMd8a593ZHfXgK9mp11 5vSa5R/S/sdCZnTfKrFYN5vbSDBBA6yKEZ81Vxki0wzB+zSjALKHZhFXGV7tZq188pHSgRNLrfj uvKH27HYV4nls7A2tPGZIfjYFRS+bgamKSzRo90WnR3wGW6jWuC65x5Dxgph2jDlR3MyNVKw+dp KzMl6JGcJfYiGgQ== X-Developer-Key: i=shankerwangmiao@gmail.com; a=openpgp; fpr=6FAEFF06B7D212A774C60BFDFA0D166D6632EF4A X-Endpoint-Received: by B4 Relay for shankerwangmiao@gmail.com/20250715 with auth_id=462 X-Original-From: Miao Wang Reply-To: shankerwangmiao@gmail.com From: Miao Wang The reset event of BMC is captured through GPIO. However, this driver bypasses the GPIO framework and directly accesses the GPIO controller through the fixed address. When the same GPIO controller is also exposed through ACPI and probed by the corresponding GPIO driver, there would be a conflict between the two drivers. This patch will try to find the GPIO through declared GPIO pin in the _CRS resources of the ACPI node. If no such delaration is found, the driver will fall back to search for the correct GPIO controller and pin according to the fixed address and pin number. A possible DSDT declaration for the GPIO pin might be as follows: Device (BMC0) { Name (_ADR, ...) // Match the PCI address of the BMC device // \_SB.GPO1 is the ACPI path of the GPIO controller Name (_CRS, ResourceTemplate () { GpioInt (Edge, ActiveLow, Exclusive, PullNone, 0, "\\_SB.GPO1", 0) { 14 // 14 is the GPIO pin number } } Signed-off-by: Miao Wang --- drivers/mfd/ls2k-bmc-core.c | 163 +++++++++++++++++++++++++++++++------------- 1 file changed, 116 insertions(+), 47 deletions(-) diff --git a/drivers/mfd/ls2k-bmc-core.c b/drivers/mfd/ls2k-bmc-core.c index 1466b314fc4e577fe5e31404444648b5b0447ebb..48ce7197c77445df9228aaacbc025d59a2788977 100644 --- a/drivers/mfd/ls2k-bmc-core.c +++ b/drivers/mfd/ls2k-bmc-core.c @@ -26,6 +26,10 @@ #include #include #include +#include +#include +#include +#include /* LS2K BMC resources */ #define LS2K_DISPLAY_RES_START (SZ_16M + SZ_2M) @@ -81,18 +85,6 @@ #define PCI_REG_STRIDE 0x4 -#define LS2K_BMC_RESET_GPIO 14 -#define LOONGSON_GPIO_REG_BASE 0x1FE00500 -#define LOONGSON_GPIO_REG_SIZE 0x18 -#define LOONGSON_GPIO_OEN 0x0 -#define LOONGSON_GPIO_FUNC 0x4 -#define LOONGSON_GPIO_INTPOL 0x10 -#define LOONGSON_GPIO_INTEN 0x14 - -#define LOONGSON_IO_INT_BASE 16 -#define LS2K_BMC_RESET_GPIO_INT_VEC (LS2K_BMC_RESET_GPIO % 8) -#define LS2K_BMC_RESET_GPIO_GSI (LOONGSON_IO_INT_BASE + LS2K_BMC_RESET_GPIO_INT_VEC) - enum { LS2K_BMC_DISPLAY, LS2K_BMC_IPMI0, @@ -186,6 +178,7 @@ struct ls2k_bmc_ddata { struct work_struct bmc_reset_work; struct ls2k_bmc_pci_data bmc_pci_data; struct ls2k_bmc_bridge_pci_data bridge_pci_data; + struct gpio_desc *reset_gpio; }; static bool ls2k_bmc_bar0_addr_is_set(struct pci_dev *pdev) @@ -375,6 +368,91 @@ static void ls2k_bmc_save_pci_data(struct pci_dev *pdev, struct ls2k_bmc_ddata * pci_read_config_dword(pdev, PCI_INTERRUPT_LINE, &ddata->bmc_pci_data.interrupt_line); } +static struct fwnode_handle *gpio_dev_get_fwnode(struct gpio_device *gdev) +{ + struct device *gdev_dev; + + gdev_dev = gpio_device_to_device(gdev); + return dev_fwnode(gdev_dev); +} + +static int ls2k_bmc_gpiochip_find(struct gpio_chip *gc, const void *data) +{ + struct acpi_device *adev; + struct list_head resource_list; + struct resource_entry *rentry; + struct fwnode_handle *fwnode = gpio_dev_get_fwnode(gc->gpiodev); + phys_addr_t start_addr = (phys_addr_t) data; + int ret, found = 0; + + if (!is_acpi_node(fwnode)) + goto out; + + adev = to_acpi_device_node(fwnode); + if (!adev) + goto out; + + INIT_LIST_HEAD(&resource_list); + + ret = acpi_dev_get_memory_resources(adev, &resource_list); + if (ret < 0) + goto out; + /* + * ACPI memory resources are ordered and only the first one is + * considered by the driver of the expected GPIO controller. So + * here we also only check the first one to see if it matches the + * expected address. + */ + rentry = list_first_entry_or_null(&resource_list, struct resource_entry, node); + if (!rentry) + goto free_resource_list; + if (rentry->res->start == start_addr) + found = 1; + +free_resource_list: + acpi_dev_free_resource_list(&resource_list); +out: + return found; +} + +static struct gpio_desc *ls2k_bmc_find_gpio(struct ls2k_bmc_ddata *ddata) +{ + /* + * In conventional way, the GPIO should be obtained through ACPI or + * device tree. However, when the information is not available, + * we should find the GPIO according to the convention of the server + * boards with LS2K BMC, the gpio signal reflecting the reset event + * of the BMC should be connected to pin 14 of the GPIO input of + * the first CPU node. The address of that GPIO controller is fixed. + */ + static const phys_addr_t LOONGSON_GPIO_REG_BASE = 0x1FE00500; + static const unsigned int LS2K_BMC_RESET_GPIO = 14; + int ret; + struct gpio_device *gdev __free(gpio_device_put) = NULL; + struct property_entry ls2k_bmc_swnode_properties[2] = { 0 }; + + dev_dbg(ddata->dev, "Searching for GPIO chip at address %pa\n", &LOONGSON_GPIO_REG_BASE); + + gdev = gpio_device_find((void *)LOONGSON_GPIO_REG_BASE, ls2k_bmc_gpiochip_find); + + if (!gdev) { + dev_dbg(ddata->dev, "cannot find GPIO chip at address %pa, deferring\n", + &LOONGSON_GPIO_REG_BASE); + return ERR_PTR(-EPROBE_DEFER); + } + + ls2k_bmc_swnode_properties[0] = PROPERTY_ENTRY_GPIO("gpio", + gpio_dev_get_fwnode(gdev), LS2K_BMC_RESET_GPIO, GPIO_ACTIVE_HIGH); + + ret = device_create_managed_software_node(ddata->dev, ls2k_bmc_swnode_properties, NULL); + if (ret) { + dev_err(ddata->dev, "Failed to create software node for GPIO reset: %d\n", ret); + return ERR_PTR(ret); + } + + return devm_gpiod_get_index(ddata->dev, NULL, 0, GPIOD_IN); +} + static void ls2k_bmc_cancel_wq(void *data) { struct ls2k_bmc_ddata *ddata = data; @@ -384,8 +462,7 @@ static void ls2k_bmc_cancel_wq(void *data) static int ls2k_bmc_init(struct ls2k_bmc_ddata *ddata) { struct pci_dev *pdev = to_pci_dev(ddata->dev); - void __iomem *gpio_base; - int gpio_irq, ret, val; + int gpio_irq, ret; ls2k_bmc_save_pci_data(pdev, ddata); @@ -402,44 +479,36 @@ static int ls2k_bmc_init(struct ls2k_bmc_ddata *ddata) return ret; } - gpio_base = ioremap(LOONGSON_GPIO_REG_BASE, LOONGSON_GPIO_REG_SIZE); - if (!gpio_base) - return -ENOMEM; - - /* Disable GPIO output */ - val = readl(gpio_base + LOONGSON_GPIO_OEN); - writel(val | BIT(LS2K_BMC_RESET_GPIO), gpio_base + LOONGSON_GPIO_OEN); - - /* Enable GPIO functionality */ - val = readl(gpio_base + LOONGSON_GPIO_FUNC); - writel(val & ~BIT(LS2K_BMC_RESET_GPIO), gpio_base + LOONGSON_GPIO_FUNC); - - /* Set GPIO interrupts to low-level active */ - val = readl(gpio_base + LOONGSON_GPIO_INTPOL); - writel(val & ~BIT(LS2K_BMC_RESET_GPIO), gpio_base + LOONGSON_GPIO_INTPOL); - - /* Enable GPIO interrupts */ - val = readl(gpio_base + LOONGSON_GPIO_INTEN); - writel(val | BIT(LS2K_BMC_RESET_GPIO), gpio_base + LOONGSON_GPIO_INTEN); + ddata->reset_gpio = devm_gpiod_get_index_optional(&pdev->dev, NULL, 0, GPIOD_IN); + if (IS_ERR(ddata->reset_gpio)) { + ret = PTR_ERR(ddata->reset_gpio); + ddata->reset_gpio = NULL; + return dev_err_probe(ddata->dev, ret, "Failed to get GPIO pin for reset signal\n"); + } + if (ddata->reset_gpio == NULL) { + ddata->reset_gpio = ls2k_bmc_find_gpio(ddata); + if (IS_ERR(ddata->reset_gpio)) { + ret = PTR_ERR(ddata->reset_gpio); + ddata->reset_gpio = NULL; + return dev_err_probe(ddata->dev, ret, + "Failed to find GPIO pin for reset signal\n"); + } + } - iounmap(gpio_base); + gpio_irq = gpiod_to_irq(ddata->reset_gpio); - /* - * Since gpio_chip->to_irq is not implemented in the Loongson-3 GPIO driver, - * acpi_register_gsi() is used to obtain the GPIO IRQ. The GPIO interrupt is a - * watchdog interrupt that is triggered when the BMC resets. - */ - gpio_irq = acpi_register_gsi(NULL, LS2K_BMC_RESET_GPIO_GSI, ACPI_EDGE_SENSITIVE, - ACPI_ACTIVE_LOW); if (gpio_irq < 0) - return gpio_irq; + return dev_err_probe(ddata->dev, gpio_irq, + "Failed to get IRQ for GPIO reset signal input\n"); - ret = devm_request_irq(ddata->dev, gpio_irq, ls2k_bmc_interrupt, - IRQF_SHARED | IRQF_TRIGGER_FALLING, "ls2kbmc gpio", ddata); - if (ret) - dev_err(ddata->dev, "Failed to request LS2KBMC GPIO IRQ %d.\n", gpio_irq); + ret = devm_request_irq(&pdev->dev, gpio_irq, ls2k_bmc_interrupt, + IRQF_SHARED | IRQF_TRIGGER_FALLING, "ls2kbmc reset", ddata); + + if (ret != 0) + return dev_err_probe(ddata->dev, ret, + "Failed to request IRQ %d for GPIO reset signal input.\n", + gpio_irq); - acpi_unregister_gsi(LS2K_BMC_RESET_GPIO_GSI); return ret; } -- 2.49.0