From: phucduc.bui@gmail.com
To: Adrian Ng <adrianhoyin.ng@altera.com>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 3/4] gpio: mlxbf2: Handle errors from optional IRQ lookup
Date: Fri, 14 Aug 2026 11:30:27 +0700 [thread overview]
Message-ID: <20260814043028.12548-3-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260814043028.12548-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
platform_get_irq_optional() returns a positive IRQ number on success or
a negative error code on failure. For an optional IRQ, -ENXIO indicates
that no optional IRQ is available. Other errors, such as -EPROBE_DEFER
and -EINVAL, should be propagated so that the caller can handle them
appropriately.
Propagate negative errors other than -ENXIO.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
drivers/gpio/gpio-mlxbf2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c
index 4e2f3381d82b..4e5c5d196a50 100644
--- a/drivers/gpio/gpio-mlxbf2.c
+++ b/drivers/gpio/gpio-mlxbf2.c
@@ -394,7 +394,9 @@ mlxbf2_gpio_probe(struct platform_device *pdev)
gc->owner = THIS_MODULE;
irq = platform_get_irq_optional(pdev, 0);
- if (irq >= 0) {
+ if (irq < 0 && irq != -ENXIO)
+ return irq;
+ if (irq > 0) {
girq = &gs->chip.gc.irq;
gpio_irq_chip_set_chip(girq, &mlxbf2_gpio_irq_chip);
girq->handler = handle_simple_irq;
--
2.43.0
next prev parent reply other threads:[~2026-08-14 4:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 4:30 [PATCH 1/4] gpio: realtek-otto: Handle errors from optional IRQ lookup phucduc.bui
2026-08-14 4:30 ` [PATCH 2/4] gpio: mlxbf3: " phucduc.bui
2026-08-14 4:30 ` phucduc.bui [this message]
2026-08-14 4:30 ` [PATCH 4/4] gpio: altera: " phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814043028.12548-3-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=adrianhoyin.ng@altera.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox