From: Andreas Kemnade <andreas@kemnade.info>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: 1298662399@qq.com, linux-gpio@vger.kernel.org,
linux-omap@vger.kernel.org, Bartosz Golaszewski <brgl@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Kevin Hilman <khilman@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] gpio: omap: handle clk_prepare failure in probe
Date: Thu, 20 Aug 2026 11:48:43 +0200 [thread overview]
Message-ID: <20260820114843.1b50783f@kemnade.info> (raw)
In-Reply-To: <b610718b-3c9d-4417-b1b7-69f0ac15dae1@web.de>
On Thu, 20 Aug 2026 11:19:00 +0200
Markus Elfring <Markus.Elfring@web.de> wrote:
> …
> > Check the return value of clk_prepare in omap_gpio_probe. On failure,
> > clear dbck_flag and return the error, preventing unbalanced
> > clk_unprepare in remove or error paths.
>
> How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
>
About adding this to stable:
does it bother anyone?
Is this actually being used with clocks having prepare() ops?
I do not see anything there. SoC-internal clocks are typically not
so easy being rewired.
To be clear, this should be fixed in -next to be prepared if something
more fundamental in clock handling changes.
Regards,
Andreas
> See also once more:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2#n34
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n145
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n792
>
> Regards,
> Markus
>
>
next prev parent reply other threads:[~2026-08-20 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 13:08 [PATCH] gpio: omap: handle clk_prepare failure in probe Jiawen Liu
2026-08-20 9:19 ` Markus Elfring
2026-08-20 9:48 ` Andreas Kemnade [this message]
2026-08-20 10:47 ` Markus Elfring
2026-08-20 13:43 ` Andreas Kemnade
2026-08-20 12:25 ` [PATCH] " Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260820114843.1b50783f@kemnade.info \
--to=andreas@kemnade.info \
--cc=1298662399@qq.com \
--cc=Markus.Elfring@web.de \
--cc=brgl@kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox