From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Ju Nan <junan76@163.com>
Cc: antonio.borneo@foss.st.com, linusw@kernel.org,
alexandre.torgue@foss.st.com, arnd@arndb.de,
clrkwllms@kernel.org, lee@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com,
mcoquelin.stm32@gmail.com, mfd@lists.linux.dev,
rostedt@goodmis.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v3] pinctrl: stm32: program the EXTI mux from .alloc instead of .activate
Date: Thu, 27 Aug 2026 17:10:56 +0200 [thread overview]
Message-ID: <20260827151056.QrjGOPuG@linutronix.de> (raw)
In-Reply-To: <20260804141402.86911-2-junan76@163.com>
On 2026-08-04 22:14:03 [+0800], Ju Nan wrote:
…
> Nothing requires the mux to be reprogrammed at interrupt startup time:
> the domain has no .deactivate, .free() only releases the irqmux_map bit
> without touching the registers, and the resume path reprograms the mux
> itself in stm32_pinctrl_restore_gpio_regs().
The deactivate was last removed in commit db0f032512443 ("pinctrl:
stm32: check for IRQ MUX validity during alloc()")
…
> While moving the code, release the mux reservation when the hwspinlock
> cannot be taken, which the .activate callback had no way of doing.
It makes sense.
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Closes: https://lore.kernel.org/all/20220202174430.pf37tt6lua2op3gc@pengutronix.de/
> Signed-off-by: Ju Nan <junan76@163.com>
Sebastian
next prev parent reply other threads:[~2026-08-27 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 6:17 [PATCH] pinctrl: stm32: use a raw spinlock regmap to program the EXTI mux Ju Nan
2026-08-04 3:22 ` [PATCH v2] pinctrl: stm32: program the EXTI mux from .alloc instead of .activate Ju Nan
2026-08-04 14:14 ` [PATCH v3] " Ju Nan
2026-08-27 15:10 ` Sebastian Andrzej Siewior [this message]
2026-08-28 11:17 ` Antonio Borneo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827151056.QrjGOPuG@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=antonio.borneo@foss.st.com \
--cc=arnd@arndb.de \
--cc=clrkwllms@kernel.org \
--cc=junan76@163.com \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mfd@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox