From: Potin Lai <potin.lai.pt@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: Cosmo Chou <cosmo.chou@quantatw.com>,
Peter Yin <Peter.Yin@quantatw.com>,
Potin Lai <potin.lai@quantatw.com>,
Potin Lai <potin.lai.pt@gmail.com>
Subject: [libgpiod v1.6.5][PATCH] core: gracefully handle disappearing chips during iteration
Date: Tue, 08 Sep 2026 21:05:07 +0800 [thread overview]
Message-ID: <20260908-gpiofind-error-enodev-v1-1-c7756aab9568@gmail.com> (raw)
When hotpluggable GPIO controllers (like USB devices) are dynamically
added or removed, a race condition can occur. A chip's device node might
be present when iterating through /dev, but the chip could disappear by
the time we try to open it or query its lines.
Previously, this caused tools like 'gpiofind' to incorrectly abort with
a 'No such device' (ENODEV) error if any chip on the system vanished
during the search.
Fix this by ignoring ENODEV errors when searching for a line
(in gpiod_line_find()) and by silently skipping chips that fail to open
during iteration (in gpiod_chip_iter_new()).
Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
---
lib/helpers.c | 2 +-
lib/iter.c | 16 ++++------------
2 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/lib/helpers.c b/lib/helpers.c
index 479f370..6d1836a 100644
--- a/lib/helpers.c
+++ b/lib/helpers.c
@@ -423,7 +423,7 @@ struct gpiod_line *gpiod_line_find(const char *name)
return line;
}
- if (errno != ENOENT)
+ if (errno != ENOENT && errno != ENODEV)
goto out;
}
diff --git a/lib/iter.c b/lib/iter.c
index bfd2852..7f5ad9a 100644
--- a/lib/iter.c
+++ b/lib/iter.c
@@ -51,7 +51,7 @@ struct gpiod_chip_iter *gpiod_chip_iter_new(void)
if (!iter)
goto err_free_dirs;
- iter->num_chips = num_chips;
+ iter->num_chips = 0;
iter->offset = 0;
if (num_chips == 0) {
@@ -64,23 +64,15 @@ struct gpiod_chip_iter *gpiod_chip_iter_new(void)
goto err_free_iter;
for (i = 0; i < num_chips; i++) {
- iter->chips[i] = gpiod_chip_open_by_name(dirs[i]->d_name);
- if (!iter->chips[i])
- goto err_close_chips;
+ iter->chips[iter->num_chips] = gpiod_chip_open_by_name(dirs[i]->d_name);
+ if (iter->chips[iter->num_chips])
+ iter->num_chips++;
}
free_dirs(dirs, num_chips);
return iter;
-err_close_chips:
- for (i = 0; i < num_chips; i++) {
- if (iter->chips[i])
- gpiod_chip_close(iter->chips[i]);
- }
-
- free(iter->chips);
-
err_free_iter:
free(iter);
---
base-commit: f1af4b189fb4074b08eecbc50cf33306299d6a51
change-id: 20260908-gpiofind-error-enodev-7e70c48b7e9f
Best regards,
--
Potin Lai <potin.lai.pt@gmail.com>
next reply other threads:[~2026-09-08 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 13:05 Potin Lai [this message]
2026-09-09 12:49 ` [libgpiod v1.6.5][PATCH] core: gracefully handle disappearing chips during iteration Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908-gpiofind-error-enodev-v1-1-c7756aab9568@gmail.com \
--to=potin.lai.pt@gmail.com \
--cc=Peter.Yin@quantatw.com \
--cc=cosmo.chou@quantatw.com \
--cc=linux-gpio@vger.kernel.org \
--cc=potin.lai@quantatw.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox