From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f43.google.com (mail-pz2-f43.google.com [74.125.228.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47FE537B3F2 for ; Tue, 15 Sep 2026 22:26:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789511173; cv=none; b=pxS84vDEmfkN1dy9Jv2/9zpBNLNrUjGfWLyny8iWqtgtcu/xe4nWeSwbBOrL5NfcNEdAYZM4b0xQytLDP7mtMTlPVgkyqFbcVxx6VZwfEmMb67UrcpMpFrilnpBG2I4y9fxePSeVB+xJ2sxIQVrfliBTU4DwfQOjxXX3dbMh36k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789511173; c=relaxed/simple; bh=VQB79XU5ha3TH3L1StabFfXEj3XgXRoI6dRfp1doGPU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NqaMWja+i//oO+PzUxl43w0ngfDR/TjR4TAIs3fjArXHs0FihGgpZgOFT63UFXZZo5vteSsk6GgiVEigPUqCWItp/oqaQE0vWJt+rcPF+vMgJ4qXeKE/At4CbAc9ZKuxImCjJ6BGkwlgdf7OKMCBUXEN30INycTq58IFizf2zr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O0nCYR9t; arc=none smtp.client-ip=74.125.228.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O0nCYR9t" Received: by mail-pz2-f43.google.com with SMTP id d2e1a72fcca58-8674704dab1so316186b3a.2 for ; Tue, 15 Sep 2026 15:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789511172; x=1790115972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ozbdljbJWhuPCjAs3/0Yc8dEEkoSWPAnbLbDIm9pqjk=; b=O0nCYR9t5CXA5OEGWgIFp9eKNYAegQnuAJRK0ALJHvnRQHK97dM8TbQd+0mBfHP1jt vi0X9ryJsQD8ZVUMdseNZRfkN8iI9HolVEkUU9+2uKQZu6Z87v+ril6dmEbBvLS0aSPf hu38Mkg1FLiodPunw5HwElKnOsSBSlXwuIGmTMBiImr89VUW/gpk9eq9VjwDJu3Ug0tw 6BasFvVLlEDkHOX6kcWbnDDL6EZr2lB0Ndzj+sLu/X2GZ2PVy4ny3Zb16bnbl7rRRQwC te729oCQt3+ciu4LqYtlbCJtPXlAKGLyOHzWD8mj3iml7eM69G0pmlWSAyF6wfdqDe6c aWmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789511172; x=1790115972; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ozbdljbJWhuPCjAs3/0Yc8dEEkoSWPAnbLbDIm9pqjk=; b=Elxe+S3OurbwJC1jRgKQrfV/vNNG0q4/IuBDpVdKKhBv9xF2DYaEepOS+PqZS/hj5Y kGmXxF68targ2+yjOE+EzYB7k5Vv66FCN0UV0wyWkmTeAFnEJlXUvmTx42Tv6sYu3Vve uCM6o4E/3EJ01/yY4cEjQurjMhiqrbSAF5j3rXdmStD1W9euKo/rZgHohSAMTp/hAP++ dtBgrYMY2aysR0yGcYzRla2XkpfL3tJxk+qK2/ZSqslZB5rnGaeNflIqI+X+aNWWwrWe 4W4tuGGlZA+pMeep676m7+Fg/DvJSQLStKGtYOwKQaWbvQcA3u+Mo7QhBjylbOIjKNb1 OBYw== X-Gm-Message-State: AFuF++l+8zGzGf3q0AZcoLaVD17haU6hl6oBhoKnMw4D93r1uAWJFdle FfbOWReuHYdviackBSy1m6qevAQZONZCJPHVro5L9glSa/IqJfJmrjy41dnY5Q== X-Gm-Gg: AYBFou0kj8j3bJuKsp1TRH6TxRsZGpAY/QhYRrWOLntEYo/UgUjw3PXpRibR/oOkv5u t3dkDCH+PMZmRpSav47iXk6SrOnX8Sl6QT0HbQSvfWctqIR8IwbJeoZMCdqLXSICjaSk0hySps1 gXxR8TCCU99p7NdXTz7OEtNMsd3cctsc56kguMhAUtkXOy+9G2oDAfLIVlpjxMILzWHM7y81Rpc KFulmJnQT5Sc4N9ZLTbYFe3TIoJaCsC9Z92BzQ1GxkbE0v1hI4E8r2lNAWrf2jo17UrGaVCkwJQ Q/8nTyeP38U80warvEJL4E+Gon7RE1qN+syaHWys4sU6I745j//WzdmGk8ul1GfFmaSFGVh4RA1 /vxttq7tvM6hYc3/nHyAK1Aj1w7RKID7qDO2Irxvcpm41dQBkOpzzfVr/JjFc1RkLj2qgldfSby CDuEmf79hZYPLtG9Em39SZmzl3oQCCk0dPenh2fhJxHu7jofK9dM+vO7dGOjICIfz7lDEiwQ6pm IHHIEFXJnRTNZju2T41QiM7HjxqR7Z0Q9AMq9EC9TKPH17GUUeRZPW3evOm62D3XVtsjGzPUr+1 SgPUgF//LQXQFOKo22Upt21/u7f2pG73F7uw1wWLtfjg3l+D86HSaWqMi8A= X-Received: by 2002:a05:6a00:908d:b0:868:e11b:d859 with SMTP id d2e1a72fcca58-8723adb237bmr222206b3a.2.1789511171577; Tue, 15 Sep 2026 15:26:11 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-871febde2ecsm224189b3a.8.2026.09.15.15.26.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 15:26:10 -0700 (PDT) From: Rosen Penev To: linux-gpio@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , linux-kernel@vger.kernel.org (open list), linux-rt-devel@lists.linux.dev (open list:Real-time Linux (PREEMPT_RT):Keyword:PREEMPT_RT) Subject: [PATCH] gpio: mvebu: use raw spinlock for MMIO regmaps Date: Tue, 15 Sep 2026 15:26:09 -0700 Message-ID: <20260915222609.194216-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The mask/unmask handlers run with the generic irqchip's raw spinlock held and call regmap_read()/regmap_write() on the GPIO regmaps. By default regmap protects itself with a plain spinlock, which becomes a sleeping rt_mutex on CONFIG_PREEMPT_RT; taking it while holding the raw irqchip lock trips might_sleep(), and PROVE_RAW_LOCK_NESTING flags the same nesting on non-RT builds. Configure both GPIO regmaps with .use_raw_spinlock = true so the MMIO accesses stay atomic in hardirq and raw-locked context. Assisted-by: LLM Signed-off-by: Rosen Penev --- drivers/gpio/gpio-mvebu.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 03e977c2a629..674feeb31774 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -598,11 +598,18 @@ static void mvebu_gpio_irq_handler(struct irq_desc *desc) chained_irq_exit(chip, desc); } +/* + * These regmaps are accessed from the mask/unmask handlers while the + * irqchip's raw spinlock is held, so they must use a raw spinlock + * internally. A plain spinlock becomes a sleeping rt_mutex on + * CONFIG_PREEMPT_RT and would trip might_sleep() from that context. + */ static const struct regmap_config mvebu_gpio_regmap_config = { .name = "gpio", .reg_bits = 32, .reg_stride = 4, .val_bits = 32, + .use_raw_spinlock = true, }; static const struct regmap_config mvebu_gpio_percpu_regmap_config = { @@ -610,6 +617,7 @@ static const struct regmap_config mvebu_gpio_percpu_regmap_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, + .use_raw_spinlock = true, }; static const struct regmap_config mvebu_pwm_regmap_config = { -- 2.55.0