From: Karl Mehltretter <kmehltretter@gmail.com>
To: Linus Walleij <linusw@kernel.org>, Bartosz Golaszewski <brgl@kernel.org>
Cc: Karl Mehltretter <kmehltretter@gmail.com>,
Jerome Neanne <jneanne@baylibre.com>,
Jonathan Cormier <jcormier@criticallink.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Shree Ramamoorthy <s-ramamoorthy@ti.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Andreas Kemnade <andreas@kemnade.info>,
Kevin Hilman <khilman@baylibre.com>,
Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] gpio: tps65219: Fix TPS6521x GPIO handling
Date: Sat, 19 Sep 2026 19:10:57 +0200 [thread overview]
Message-ID: <20260919171100.90430-1-kmehltretter@gmail.com> (raw)
I found patch 1 while looking through the tree for code that mixes up
bit numbers and bit masks. Patches 2 and 3 turned up while checking the
nearby TPS65214 code.
Patch 1 fixes TPS65219 input reads. Patches 2 and 3 fix TPS65214
direction handling.
I tested the series under x86_64 QEMU 10.2.1 with a temporary KUnit
suite and a RAM-backed regmap. Both tests failed on the base commit.
The TPS65219 input-high test returned low, and the TPS65214
direction-output test left GPIO_CONFIG clear. Both tests pass with this
series. A W=1 build of drivers/gpio/gpio-tps65219.o also passes.
The KUnit suite is not included. It tests the driver logic, not real
PMIC hardware. I have not tested this on real hardware. Testing on
affected hardware is welcome.
Karl Mehltretter (3):
gpio: tps65219: Fix GPIO input value reads
gpio: tps65219: Use the variant-specific direction callback
gpio: tps65219: Fix TPS65214 GPIO direction programming
drivers/gpio/gpio-tps65219.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
base-commit: 40288c9206c17eb66a603262e06a58d300d0f279
--
2.53.0
next reply other threads:[~2026-09-19 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 17:10 Karl Mehltretter [this message]
2026-09-19 17:10 ` [PATCH 1/3] gpio: tps65219: Fix GPIO input value reads Karl Mehltretter
2026-09-21 15:15 ` Jon Cormier
2026-09-19 17:10 ` [PATCH 2/3] gpio: tps65219: Use the variant-specific direction callback Karl Mehltretter
2026-09-19 17:11 ` [PATCH 3/3] gpio: tps65219: Fix TPS65214 GPIO direction programming Karl Mehltretter
2026-09-24 15:46 ` Andy Shevchenko
2026-09-24 18:03 ` Jon Cormier
2026-09-23 14:42 ` [PATCH 0/3] gpio: tps65219: Fix TPS6521x GPIO handling Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260919171100.90430-1-kmehltretter@gmail.com \
--to=kmehltretter@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@kernel.org \
--cc=jcormier@criticallink.com \
--cc=jneanne@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=s-ramamoorthy@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox