From: Vincent Fazio <vfazio@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: brgl@kernel.org, Vincent Fazio <vfazio@gmail.com>
Subject: [libgpiod][PATCH v2 09/14] bindings: python: chip: use literals for dict/list and declare types
Date: Sat, 24 Oct 2026 15:00:43 -0500 [thread overview]
Message-ID: <20261024200048.25987-1-vfazio@gmail.com> (raw)
Per linter recommendation [0], use the literal form of the dict and list
constructors. The long form is not common in typical Python code so it
stays as readable for someone familiar with the short form syntax and it
has a very negligible performance benefit.
While making this change, specify type annotations for the collections
to reflect their contents so type checkers do not try to determine their
contents implicitly based on assignments.
[0]: https://docs.astral.sh/ruff/rules/unnecessary-collection-call/
Signed-off-by: Vincent Fazio <vfazio@gmail.com>
---
Changes in v2:
- Reword commit message to provide better rationale (Bartosz)
---
bindings/python/gpiod/chip.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/bindings/python/gpiod/chip.py b/bindings/python/gpiod/chip.py
index 8712b2b..94c432a 100644
--- a/bindings/python/gpiod/chip.py
+++ b/bindings/python/gpiod/chip.py
@@ -275,13 +275,13 @@ class Chip:
for line, value in output_values.items()
}
- name_map = dict()
- requested_lines = list()
- global_output_values = list()
- seen_offsets = set()
+ name_map: dict[str, int] = {}
+ requested_lines: list[int | str] = []
+ global_output_values: list[Value] = []
+ seen_offsets: set[int] = set()
for line, settings in config_iter(config):
- offsets = list()
+ offsets: list[int] = []
offset = self.line_offset_from_id(line)
# don't allow offset repetitions or offset-name conflicts.
--
2.43.0
next reply other threads:[~2026-10-24 20:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 20:00 Vincent Fazio [this message]
2026-10-24 20:00 ` [libgpiod][PATCH v2 10/14] bindings: python: bump ruff linter dependency Vincent Fazio
2026-10-24 20:00 ` [libgpiod][PATCH v2 11/14] bindings: python: include Python.h before other headers Vincent Fazio
2026-10-24 20:00 ` [libgpiod][PATCH v2 12/14] bindings: python: advertise Python 3.15 support Vincent Fazio
2026-10-24 20:00 ` [libgpiod][PATCH v2 13/14] bindings: python: fix directory validation in artifact script Vincent Fazio
2026-10-24 20:00 ` [libgpiod][PATCH v2 14/14] bindings: python: bump dependencies " Vincent Fazio
2026-10-28 9:19 ` [libgpiod][PATCH v2 09/14] bindings: python: chip: use literals for dict/list and declare types Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261024200048.25987-1-vfazio@gmail.com \
--to=vfazio@gmail.com \
--cc=brgl@kernel.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox