Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: " Clément Le Goffic" <clegoffic@baylibre.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-gpio@vger.kernel.org,
	Linus Walleij <linusw@kernel.org>,
	Cristian Marussi <cristian.marussi@arm.com>
Subject: [linusw-pinctrl:for-next 7/8] drivers/pinctrl/pinctrl-scmi.c:425:22: error: 'const struct scmi_pinctrl_proto_ops' has no member named 'function_flags_get'; did you mean 'function_groups_get'?
Date: Fri, 13 Nov 2026 18:13:20 +0100	[thread overview]
Message-ID: <202611131822.1IMmC3nP-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git for-next
head:   e45b85490f2d1a00f7e41cb72025fc3fa791e597
commit: 1b5848e1170359a8c708b5527e8f8f20c62f8e2d [7/8] pinctrl: scmi: give no groups to pin-only functions
config: arm64-randconfig-2200-20261113 (https://download.01.org/0day-ci/archive/20261113/202611131822.1IMmC3nP-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 8.5.0
smatch: v0.5.0-9187-g5189e3fb
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261113/202611131822.1IMmC3nP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611131822.1IMmC3nP-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/pinctrl/pinctrl-scmi.c: In function 'pinctrl_scmi_get_functions':
>> drivers/pinctrl/pinctrl-scmi.c:425:22: error: 'const struct scmi_pinctrl_proto_ops' has no member named 'function_flags_get'; did you mean 'function_groups_get'?
      ret = pinctrl_ops->function_flags_get(pmx->ph, i, &pin_only,
                         ^~~~~~~~~~~~~~~~~~
                         function_groups_get


vim +425 drivers/pinctrl/pinctrl-scmi.c

   407	
   408	static int pinctrl_scmi_get_functions(struct scmi_pinctrl *pmx)
   409	{
   410		unsigned int nr_funcs, nr_groups, i, j;
   411		const unsigned int *group_ids;
   412		bool pin_only, gpio;
   413		const char *fname;
   414		const char **gnames;
   415		int ret;
   416	
   417		nr_funcs = pinctrl_ops->count_get(pmx->ph, FUNCTION_TYPE);
   418	
   419		for (i = 0; i < nr_funcs; i++) {
   420			ret = pinctrl_ops->name_get(pmx->ph, i, FUNCTION_TYPE,
   421						    &fname);
   422			if (ret)
   423				return ret;
   424	
 > 425			ret = pinctrl_ops->function_flags_get(pmx->ph, i, &pin_only,
   426							      &gpio);
   427			if (ret)
   428				return ret;
   429	
   430			ret = pinctrl_ops->function_groups_get(pmx->ph, i,
   431							       &nr_groups,
   432							       &group_ids);
   433			if (ret)
   434				return ret;
   435	
   436			if (pin_only)
   437				nr_groups = 0;
   438			else if (!nr_groups)
   439				dev_warn(pmx->dev,
   440					 "Function %s contains no groups\n",
   441					 fname);
   442	
   443			gnames = devm_kmalloc_array(pmx->dev, nr_groups,
   444						    sizeof(*gnames), GFP_KERNEL);
   445			if (!gnames)
   446				return -ENOMEM;
   447	
   448			for (j = 0; j < nr_groups; j++) {
   449				ret = pinctrl_ops->name_get(pmx->ph, group_ids[j],
   450							    GROUP_TYPE, &gnames[j]);
   451				if (ret)
   452					return ret;
   453			}
   454	
   455			ret = pinmux_generic_add_function(pmx->pctldev, fname, gnames,
   456					  nr_groups, NULL);
   457			if (ret < 0)
   458				return ret;
   459			if (ret != i) {
   460				dev_err(pmx->dev,
   461					"Duplicate function name: %s index: %u selector: %d\n",
   462					fname, i, ret);
   463				return -EINVAL;
   464			}
   465		}
   466	
   467		return 0;
   468	}
   469	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-11-13 17:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202611131822.1IMmC3nP-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=clegoffic@baylibre.com \
    --cc=cristian.marussi@arm.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox