From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.43 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794945915; b=UKA4yhiG6nHBjQ/vD9jQsGMNEP3fE4ThLIvynv/SnTqTg0SQhrYMMdSAg1b3N9vT4F+V s24WvIXUCFXVh6v2CFkwobX1VYz5mh9s+oQYRD0wi48qyTIjP/l52iYl8JUUIwldBW4jc XWR4nhqxjoyZWO3nEfuvG7X1tVRXFSxETSmMYuBm/yDowG1V3OxINwpaQ0Jgs6d6dVXKJ 4W/FouvGSxHGex4839XhBUcUjlzeUJPXfM+cxHCU/XSbmv8+GxqPJFPpdpNBp07ovPA91 4VOfmE+ksQrmJrpDhPWYNmHd3Pjn7nlL7OBT1hm9c73zL/J63M2esUN74HRLN93WAIA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794945915; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=I4V/mFDPpkUiPU517GUo/F8CChNGX/URZfOCzHfy5Ek=; b=d8OrbaPrRi9aFKVelZma+dN4AUr4R7NCyPAqNFWDKXXAZaGjDfi57Vk0iNZl31wd1z+k CUbXJmCr3Z4j0y28a7aSyuNO/TY6uhNBm/poVNTN7Y9oiOd+Ua84bGYrZoiGMFsTXlrJL PerbhRM336rLwkI0kYZs97VP3dSohubACTRuDpn2jV9iBuv0Q4VS04shHBG1k7GCjxees rUHNgMgtWLAfer3Yf5RoGp6rkRpE9jF0XlQW3dCPl3JRzexEapikRkxEf7efmI7DQjMGy T2yPokabMWj8WRyH1tSScGAGLKFqNp60GsBMx4JqMIY+uQTQQyg2XT6i1KLbvebZGTQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=SMpoD2pQ; arc=none smtp.remote-ip=209.85.221.43 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B751D60A5BDE for ; Tue, 17 Nov 2026 20:05:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B751D60A5BDE Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=SMpoD2pQ Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-48dee593f18so127095f8f.3 for ; Tue, 17 Nov 2026 12:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794945913; x=1795550713; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I4V/mFDPpkUiPU517GUo/F8CChNGX/URZfOCzHfy5Ek=; b=SMpoD2pQjaA/cYwragUAoL2cukgsQqAGoTUGPepWYe3flBwQMPJYr2+y+F+Ut7Kz+E OtvViQ4W7x5E7+e5G5fCm0nKIraG+qRrtUI6HMDdyQeh7FKYXzyp/7AaQw9uMl7kFF6S mqOpcHdDv35O2pRw8ttbgzFzyxpcUQGPxGB2Ge2naeMbBTSEJOxnvf8liWSxYvtEsIL1 75McRy04KBF+kNYieEZr07EBSyz00zguoprTeNdA2cJn/deMAz6fQ2eS/bk5G91FkAe0 hFeXUG9iDIzGHafEklmHwTxURZbJFyTqF5ghJztE9wemZNwf4wZeyNM272S2hPY6rvc+ GZgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794945913; x=1795550713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=I4V/mFDPpkUiPU517GUo/F8CChNGX/URZfOCzHfy5Ek=; b=dpK37UX1yPR2iRHxgHcQqpGSKOYivaWoYs2vrMwpReKFk4KEkD7sNTxPDBDweTRgxw fDJ6xj6qY6Gg2SOnP92q0RxCA9nTnJH9KhB8EylM7QyWroBJZmBVO93BdVfTW2XThYhU gp95Xls9HuV0zUIu2HEJM2SNz0dFHysGQcHSBFDwgklI3qp+M7KLwhHBTvJpQkBuNjA6 JIvobsF6843qrKEjlgY3QZxToC25sSg0DA8h2p+eJ7cLbIhvINWtLuEOYgTsiQFBaO+/ iSBjyWxSQcdnp0EYSxvpqtnZh0PVIT/nCj+DK6WePWHg+roTLafoDDASg1Jf+sj7Nw8P 2RaA== X-Forwarded-Encrypted: i=1; AL+hErEvWuNZI2TS0HqgIHqJJyvFkuSlWKV2s4gW1h2bKvRkNbnnQtrZG3sX33uWmsU/QHT1oL+8AFkzsrZy@vger.kernel.org X-Gm-Message-State: APuU4Z99F4VheSdZ1tMKbyfmKYVQ2bxhA3bn/qRXzlOruNM4dOanCe6K 211bRd3NeibvYUDpUzlV7ndPlEtF30BHrKaKLuv77bGHRNcynXUblu3h X-Gm-Gg: AZFdTZf0McU+oJoL2SWcXfqczB0f9/Wdsl4xoy7/GPXwXcwB1fqGVbK+UY8jqo7kAdA 19Dbjw1IhMGTziFRMhUzMb9AEIqW3XmRWrnUC4PypX/i+/qnswnkIEpJUp1n0xQtok/WKAOC83M yUx6ZjuDUNqg4hbMUgmdRmQKEjW0CGf8SZnt+JozMNvu/Y7veJ1UgwkTZ1ux6y2bD5SoMBQgYCo /Ke2CNIcrtWVQWnPSLvQriCgK4n9S/UMGM/ODCgEvxzEzPLavmvT3uBAZuBjmArqX50hv5BwqmS BNGtZpmTFGUqGvk+zKj1i/MilNwL7ThQD/YVTz6He6pU7fTXx6CNOCHP5x6ENpucZG2j1opOQMb rBoFbQ3xnODrpnQQQHjiXS617H8h+XUUmDNuTZGmBRRs7Tmm9EPLboJJc6FOnTIsdpegIOGv40n mw7OYeOs3ctK4IEeuhQi8wo5H435j0/96qr42vPxlZ4xDMA92zTcV6YYaydD0hi7ypKLLd9w11E qLK2hgxHPDFdo1jhS7xiS79ziF7yBuz4BR5auoYxOFET8NDHX8rTt/AhfkO2xjwZsNSnPa4MXYn Gfs091cwVg5VWNNQQKH+F6Ep8UR/ X-Received: by 2002:a05:6000:184b:b0:48e:3df8:74cb with SMTP id ffacd0b85a97d-4a6334a76d3mr1304109f8f.6.1794945912888; Tue, 17 Nov 2026 12:05:12 -0800 (PST) Received: from m2.. ([37.142.154.208]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-4a64b60940csm625528f8f.0.2026.11.17.12.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 12:05:12 -0800 (PST) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Raman Varabets , Germain Hebert , Christina Quast , Rio Liu , Bruno Giacomazzi , linux-input@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH v4 05/16] HID: ft260: fix sysfs store failure notice for big numbers Date: Tue, 17 Nov 2026 22:04:11 +0200 Message-ID: <20261117200423.19561-6-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261117200423.19561-1-michael.zaidman@gmail.com> References: <20261117200423.19561-1-michael.zaidman@gmail.com> X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit FT260_ATTR_STORE returned the feature-report transfer length from ft260_hid_feature_report_set() instead of the sysfs write size. For values like 1000, userspace writes more bytes than the HID report length, so the VFS retries the remainder and reports "Invalid argument" even though the attribute was applied correctly: $ echo 1000 > .../clock bash: line 1: echo: write error: Invalid argument $ cat .../clock 1000 Return count when the feature report succeeds, so the full write is consumed, and the error when it fails. Parse a 16-bit attribute, such as clock, into a u16 and convert it with cpu_to_le16(), because the report field is little endian. Before, the value was parsed straight into the __le16 field, which is wrong on a big-endian CPU. Signed-off-by: Michael Zaidman --- v2: Fixes for the issues reported by Sashiko: - A failed feature report is not reported as success. - A 16-bit attribute is converted with cpu_to_le16(), so it is correct on a big-endian CPU. v3: Subject reworded after the original out-of-tree commit, "Get rid of sysfs store big numbers failure notice". The v2 subject read as if the patch hid big values. No i2c: prefix, because FT260_ATTR_STORE serves all store attributes, not only the I2C ones. --- drivers/hid/hid-ft260.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index 1b31b484a11b..bdd55b35df9a 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -1486,56 +1486,60 @@ static void ft260_attr_dummy_func(struct hid_device *hdev, u8 req, u16 value) } #define FT260_SSTAT_ATTR_SHOW(name) \ FT260_ATTR_SHOW(name, ft260_get_system_status_report, \ FT260_SYSTEM_SETTINGS, u8, ft260_byte_show) #define FT260_I2CST_ATTR_SHOW(name) \ FT260_ATTR_SHOW(name, ft260_get_i2c_status_report, \ FT260_I2C_STATUS, __le16, ft260_word_show) -#define FT260_ATTR_STORE(name, reptype, id, req, type, ctype, strtou, func) \ +#define FT260_STORE_NATIVE(v) (v) + +#define FT260_ATTR_STORE(name, reptype, id, req, type, strtou, func, conv) \ static ssize_t name##_store(struct device *kdev, \ struct device_attribute *attr, \ const char *buf, size_t count) \ { \ struct reptype rep; \ struct hid_device *hdev = to_hid_device(kdev); \ struct ft260_device *dev = hid_get_drvdata(hdev); \ type name; \ int ret; \ \ - if (!strtou(buf, 10, (ctype *)&name)) { \ - rep.name = name; \ + if (!strtou(buf, 10, &name)) { \ + rep.name = conv(name); \ rep.report = id; \ rep.request = req; \ mutex_lock(&dev->lock); \ ret = ft260_hid_feature_report_set(hdev, (u8 *)&rep, \ sizeof(rep)); \ if (ret < 0) \ hid_err(hdev, "%s: failed!\n", __func__); \ - else \ + else { \ func(hdev, req, name); \ + ret = count; \ + } \ mutex_unlock(&dev->lock); \ } else { \ ret = -EINVAL; \ } \ return ret; \ } #define FT260_BYTE_ATTR_STORE(name, reptype, req, func) \ FT260_ATTR_STORE(name, reptype, FT260_SYSTEM_SETTINGS, req, \ - u8, u8, kstrtou8, func) + u8, kstrtou8, func, FT260_STORE_NATIVE) #define FT260_WORD_ATTR_STORE(name, reptype, req, func) \ FT260_ATTR_STORE(name, reptype, FT260_SYSTEM_SETTINGS, req, \ - __le16, u16, kstrtou16, func) + u16, kstrtou16, func, cpu_to_le16) FT260_SSTAT_ATTR_SHOW(chip_mode); static DEVICE_ATTR_RO(chip_mode); FT260_SSTAT_ATTR_SHOW(pwren_status); static DEVICE_ATTR_RO(pwren_status); FT260_SSTAT_ATTR_SHOW(suspend_status); static DEVICE_ATTR_RO(suspend_status); -- 2.43.0