From: Dmitry Osipenko <digetx@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-tegra@vger.kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 5/5] gpio: max77620: Move variable declaration
Date: Wed, 8 Jul 2020 12:24:18 +0300 [thread overview]
Message-ID: <204bc417-02cf-1b8f-da99-a598056ff7e4@gmail.com> (raw)
In-Reply-To: <CAHp75VeMhb6BH9LnZxM+_-6nNzDErKN70T_QuuuW_dmLwcpoHg@mail.gmail.com>
08.07.2020 11:47, Andy Shevchenko пишет:
> On Wed, Jul 8, 2020 at 11:29 AM Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> Let's move the virq variable declaration to a top-level scope just to
>> make the code a bit more visually appealing.
>
> To me it sounds like unneeded churn, but it's up to maintainers.
>
I agree that this is an unnecessary change, but I couldn't resist :)
Alright, I'll skip the patches 3-5 in the v2. Thank you very much for
the review!
prev parent reply other threads:[~2020-07-08 9:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 8:26 [PATCH v1 0/5] Improvements for MAX77620 GPIO driver Dmitry Osipenko
2020-07-08 8:26 ` [PATCH v1 1/5] gpio: max77620: Initialize interrupts state Dmitry Osipenko
2020-07-08 8:51 ` Andy Shevchenko
2020-07-08 8:53 ` Andy Shevchenko
2020-07-08 9:09 ` Dmitry Osipenko
2020-07-08 9:41 ` Dmitry Osipenko
2020-07-08 8:26 ` [PATCH v1 2/5] gpio: max77620: Replace 8 with MAX77620_GPIO_NR Dmitry Osipenko
2020-07-08 8:26 ` [PATCH v1 3/5] gpio: max77620: Replace interrupt-enable array with bitmap Dmitry Osipenko
2020-07-08 8:44 ` Andy Shevchenko
2020-07-08 9:08 ` Dmitry Osipenko
2020-07-08 8:26 ` [PATCH v1 4/5] gpio: max77620: Don't handle disabled interrupts Dmitry Osipenko
2020-07-08 8:46 ` Andy Shevchenko
2020-07-08 9:19 ` Dmitry Osipenko
2020-07-08 10:11 ` Andy Shevchenko
2020-07-08 10:54 ` Dmitry Osipenko
2020-07-08 15:31 ` Andy Shevchenko
2020-07-08 8:26 ` [PATCH v1 5/5] gpio: max77620: Move variable declaration Dmitry Osipenko
2020-07-08 8:47 ` Andy Shevchenko
2020-07-08 9:24 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=204bc417-02cf-1b8f-da99-a598056ff7e4@gmail.com \
--to=digetx@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).