From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: sh-pfc: sh7757: Fix duplicate initializer in GPIO pinmux data
Date: Fri, 10 Jun 2016 15:17:48 +0300 [thread overview]
Message-ID: <2053199.LgvzIZkihe@avalon> (raw)
In-Reply-To: <1465552699-5990-1-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Friday 10 Jun 2016 11:58:19 Geert Uytterhoeven wrote:
> With C=1:
>
> drivers/pinctrl/sh-pfc/pfc-sh7757.c:1613:9: warning: Initializer entry
> defined twice drivers/pinctrl/sh-pfc/pfc-sh7757.c:1628:9: also defined
> here
>
> Remove the duplicate initializer to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Based on the comment near the definition of A16_MARK, which states A16
> belongs to the "PTV" section.
>
> I do not have a sh7757 datasheet.
> ---
> drivers/pinctrl/sh-pfc/pfc-sh7757.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-sh7757.c
> b/drivers/pinctrl/sh-pfc/pfc-sh7757.c index
> 0555a1fe076ed353..6d8c31caefc105e0 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-sh7757.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-sh7757.c
> @@ -1625,7 +1625,6 @@ static const struct pinmux_func pinmux_func_gpios[] =
> { GPIO_FN(VBIOS_CS),
>
> /* PTW (mobule: LBSC, EVC, SCIF) */
> - GPIO_FN(A16),
> GPIO_FN(A15),
> GPIO_FN(A14),
> GPIO_FN(A13),
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2016-06-10 12:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 9:58 [PATCH] pinctrl: sh-pfc: sh7757: Fix duplicate initializer in GPIO pinmux data Geert Uytterhoeven
2016-06-10 12:17 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2053199.LgvzIZkihe@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).