From: Heiko Stuebner <heiko@sntech.de>
To: Xing Zheng <zhengxing@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] pinctrl: rockchip: add support for the rk3036
Date: Fri, 28 Aug 2015 09:53:20 +0200 [thread overview]
Message-ID: <2085107.a4DMzAYYyZ@phil> (raw)
In-Reply-To: <1440740808-15004-3-git-send-email-zhengxing@rock-chips.com>
Hi,
Am Freitag, 28. August 2015, 13:46:47 schrieb Xing Zheng:
> Many parts of pinctrl rk3036 are similar to rk2928's.
>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> ---
>
> Changes in v1: None
>
> drivers/pinctrl/pinctrl-rockchip.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
please also add the new "rockchip,rk3036-pinctrl" compatible to
Documentation/devicetree/pinctrl/rockchip,pinctrl.txt
I've checked the values against the rk3036 TRM and everything seems to fit, so
with the missing compatible added to the binding you can add my
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Heiko
next prev parent reply other threads:[~2015-08-28 7:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 5:46 [PATCH v1 0/3] Port and support rk3036 SoC platform Xing Zheng
2015-08-28 5:46 ` [PATCH v1 2/3] pinctrl: rockchip: add support for the rk3036 Xing Zheng
2015-08-28 7:53 ` Heiko Stuebner [this message]
2015-09-25 16:25 ` Linus Walleij
2015-08-28 9:59 ` [PATCH v1 0/3] Port and support rk3036 SoC platform Heiko Stuebner
2015-08-28 10:07 ` Xing Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2085107.a4DMzAYYyZ@phil \
--to=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).