* [PATCH 60/62] gpio: gpio-zynq: Use new GPIO_LINE_DIRECTION [not found] <cover.1572946015.git.matti.vaittinen@fi.rohmeurope.com> @ 2019-11-05 10:40 ` Matti Vaittinen 2019-11-05 10:56 ` Michal Simek 0 siblings, 1 reply; 2+ messages in thread From: Matti Vaittinen @ 2019-11-05 10:40 UTC (permalink / raw) To: matti.vaittinen, mazziesaccount Cc: Linus Walleij, Bartosz Golaszewski, Michal Simek, linux-gpio, linux-arm-kernel, linux-kernel It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> --- drivers/gpio/gpio-zynq.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index cd475ff4bcad..4c3f6370eab4 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers/gpio/gpio-zynq.c @@ -360,7 +360,7 @@ static int zynq_gpio_dir_out(struct gpio_chip *chip, unsigned int pin, * * This function returns the direction of the specified GPIO. * - * Return: 0 for output, 1 for input + * Return: GPIO_LINE_DIRECTION_OUT or GPIO_LINE_DIRECTION_IN */ static int zynq_gpio_get_direction(struct gpio_chip *chip, unsigned int pin) { @@ -372,7 +372,10 @@ static int zynq_gpio_get_direction(struct gpio_chip *chip, unsigned int pin) reg = readl_relaxed(gpio->base_addr + ZYNQ_GPIO_DIRM_OFFSET(bank_num)); - return !(reg & BIT(bank_pin_num)); + if (reg & BIT(bank_pin_num)) + return GPIO_LINE_DIRECTION_OUT; + + return GPIO_LINE_DIRECTION_IN; } /** -- 2.21.0 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =] ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 60/62] gpio: gpio-zynq: Use new GPIO_LINE_DIRECTION 2019-11-05 10:40 ` [PATCH 60/62] gpio: gpio-zynq: Use new GPIO_LINE_DIRECTION Matti Vaittinen @ 2019-11-05 10:56 ` Michal Simek 0 siblings, 0 replies; 2+ messages in thread From: Michal Simek @ 2019-11-05 10:56 UTC (permalink / raw) To: Matti Vaittinen, mazziesaccount Cc: Linus Walleij, Bartosz Golaszewski, Michal Simek, linux-gpio, linux-arm-kernel, linux-kernel On 05. 11. 19 11:40, Matti Vaittinen wrote: > It's hard for occasional GPIO code reader/writer to know if values 0/1 > equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and > GPIO_LINE_DIRECTION_OUT to help them out. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > drivers/gpio/gpio-zynq.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c > index cd475ff4bcad..4c3f6370eab4 100644 > --- a/drivers/gpio/gpio-zynq.c > +++ b/drivers/gpio/gpio-zynq.c > @@ -360,7 +360,7 @@ static int zynq_gpio_dir_out(struct gpio_chip *chip, unsigned int pin, > * > * This function returns the direction of the specified GPIO. > * > - * Return: 0 for output, 1 for input > + * Return: GPIO_LINE_DIRECTION_OUT or GPIO_LINE_DIRECTION_IN > */ > static int zynq_gpio_get_direction(struct gpio_chip *chip, unsigned int pin) > { > @@ -372,7 +372,10 @@ static int zynq_gpio_get_direction(struct gpio_chip *chip, unsigned int pin) > > reg = readl_relaxed(gpio->base_addr + ZYNQ_GPIO_DIRM_OFFSET(bank_num)); > > - return !(reg & BIT(bank_pin_num)); > + if (reg & BIT(bank_pin_num)) > + return GPIO_LINE_DIRECTION_OUT; > + > + return GPIO_LINE_DIRECTION_IN; > } > > /** > Reviewed-by: Michal Simek <michal.simek@xilinx.com> Thanks, Michal ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-05 10:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1572946015.git.matti.vaittinen@fi.rohmeurope.com>
2019-11-05 10:40 ` [PATCH 60/62] gpio: gpio-zynq: Use new GPIO_LINE_DIRECTION Matti Vaittinen
2019-11-05 10:56 ` Michal Simek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).