From: Michael Walle <michael@walle.cc>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v1 1/1] pinctr: microchip-sgpio: Correct the fwnode_irq_get() return value check
Date: Tue, 06 Sep 2022 00:24:43 +0200 [thread overview]
Message-ID: <21f2241f19003a1210bd475883ee077b@walle.cc> (raw)
In-Reply-To: <20220905190849.73194-1-andriy.shevchenko@linux.intel.com>
Am 2022-09-05 21:08, schrieb Andy Shevchenko:
> fwnode_irq_get() may return all possible signed values, such as Linux
> error code. Fix the code to handle this properly.
>
> Fixes: be2dc859abd4 ("pinctrl: pinctrl-microchip-sgpio: Add irq
> support (for sparx5)")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Michael Walle <michael@walle.cc>
Btw. do we care about EPROBE_DEFER?
-michael
next prev parent reply other threads:[~2022-09-05 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 19:08 [PATCH v1 1/1] pinctr: microchip-sgpio: Correct the fwnode_irq_get() return value check Andy Shevchenko
2022-09-05 22:24 ` Michael Walle [this message]
2022-09-06 11:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21f2241f19003a1210bd475883ee077b@walle.cc \
--to=michael@walle.cc \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lars.povlsen@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).